review: correct logger.exception/logger.error use

Author: pjhartzell

src/stapi_fastapi/routers/product_router.py

@@ -279,7 +279,7 @@ async def search_opportunities_sync(
             case Failure(e) if isinstance(e, ConstraintsException):
                 raise e
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while searching opportunities: %s",
                     traceback.format_exception(e),
                 )
@@ -324,7 +324,7 @@ async def search_opportunities_async(
             case Failure(e) if isinstance(e, ConstraintsException):
                 raise e
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while initiating an asynchronous opportunity search: %s",
                     traceback.format_exception(e),
                 )
@@ -366,7 +366,7 @@ async def create_order(
             case Failure(e) if isinstance(e, ConstraintsException):
                 raise e
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while creating order: %s",
                     traceback.format_exception(e),
                 )
@@ -431,7 +431,7 @@ async def get_opportunity_collection(
             case Success(Maybe.empty):
                 raise NotFoundException("Opportunity Collection not found")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while fetching opportunity collection: '%s': %s",
                     opportunity_collection_id,
                     traceback.format_exception(e),

src/stapi_fastapi/routers/root_router.py

@@ -252,7 +252,7 @@ async def get_orders(
             case Failure(ValueError()):
                 raise NotFoundException(detail="Error finding pagination token")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while retrieving orders: %s",
                     traceback.format_exception(e),
                 )
@@ -275,7 +275,7 @@ async def get_order(self, order_id: str, request: Request) -> Order:
             case Success(Maybe.empty):
                 raise NotFoundException("Order not found")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while retrieving order '%s': %s",
                     order_id,
                     traceback.format_exception(e),
@@ -308,7 +308,7 @@ async def get_order_statuses(
             case Failure(ValueError()):
                 raise NotFoundException("Error finding pagination token")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while retrieving order statuses: %s",
                     traceback.format_exception(e),
                 )
@@ -386,7 +386,7 @@ async def get_opportunity_search_records(
             case Failure(ValueError()):
                 raise NotFoundException(detail="Error finding pagination token")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while retrieving opportunity search records: %s",
                     traceback.format_exception(e),
                 )
@@ -413,7 +413,7 @@ async def get_opportunity_search_record(
             case Success(Maybe.empty):
                 raise NotFoundException("Opportunity Search Record not found")
             case Failure(e):
-                logger.exception(
+                logger.error(
                     "An error occurred while retrieving opportunity search record '%s': %s",
                     search_record_id,
                     traceback.format_exception(e),