remove unused Order typing

Author: Phil Varner

bin/server.py

@@ -73,7 +73,7 @@ async def create_order(
         """
         Create a new order.
         """
-        order = Order[MyOpportunityProperties, MyOrderParameters](
+        order = Order(
             id=str(uuid4()),
             geometry=payload.geometry,
             properties={

src/stapi_fastapi/models/order.py

@@ -60,7 +60,7 @@ class OrderSearchParameters(BaseModel):
     filter: CQL2Filter | None = None
 
 
-class OrderProperties(BaseModel, Generic[OPP, ORP]):
+class OrderProperties(BaseModel):
     product_id: str
     created: AwareDatetime
     status: OrderStatus
@@ -72,14 +72,14 @@ class OrderProperties(BaseModel, Generic[OPP, ORP]):
     model_config = ConfigDict(extra="allow")
 
 
-class Order(Feature[Geometry, OrderProperties[OPP, ORP]]):
+class Order(Feature[Geometry, OrderProperties]):
     # We need to enforce that orders have an id defined, as that is required to
     # retrieve them via the API
     id: StrictInt | StrictStr
     type: Literal["Feature"] = "Feature"
     links: list[Link] = Field(default_factory=list)
 
 
-class OrderCollection(FeatureCollection[Order[OPP, ORP]]):
+class OrderCollection(FeatureCollection[Order]):
     type: Literal["FeatureCollection"] = "FeatureCollection"
     links: list[Link] = Field(default_factory=list)

src/stapi_fastapi/routers/product_router.py

@@ -89,19 +89,13 @@ async def _create_order(
         _create_order.__annotations__["payload"] = OrderRequest[
             self.product.order_parameters  # type: ignore
         ]
-        _create_order.__annotations__["return"] = Order[
-            self.product.constraints, self.product.order_parameters  # type: ignore
-        ]
 
         self.add_api_route(
             path="/order",
             endpoint=_create_order,
             name=f"{self.root_router.name}:{self.product.id}:create-order",
             methods=["POST"],
             response_class=GeoJSONResponse,
-            response_model=Order[
-                self.product.constraints, self.product.order_parameters  # type: ignore
-            ],
             status_code=status.HTTP_201_CREATED,
             summary="Create an order for the product",
             tags=["Products"],

tests/backends.py

@@ -16,8 +16,6 @@
 )
 from stapi_fastapi.routers.product_router import ProductRouter
 
-from .shared import SpotlightOpportunityProperties, SpotlightOrderParameters
-
 
 class MockOrderDB(dict[int | str, Order]):
     pass
@@ -67,9 +65,7 @@ async def create_order(
         Create a new order.
         """
         if any(allowed == payload for allowed in self._allowed_payloads):
-            order = Order[
-                SpotlightOpportunityProperties, SpotlightOrderParameters
-            ](
+            order = Order(
                 id=str(uuid4()),
                 geometry=payload.geometry,  # maybe set to a different value by opportunity resolution process
                 properties={