fix exception logging (#125)

* fix exception logging

Author: Phil Varner

CHANGELOG.md

@@ -29,7 +29,7 @@ none
 
 ### Fixed
 
-none
+- Exception logging
 
 ### Security
 

src/stapi_fastapi/routers/product_router.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import logging
+import traceback
 from typing import TYPE_CHECKING, Self
 
 from fastapi import APIRouter, HTTPException, Request, Response, status
@@ -22,6 +23,8 @@
 if TYPE_CHECKING:
     from stapi_fastapi.routers import RootRouter
 
+logger = logging.getLogger(__name__)
+
 
 class ProductRouter(APIRouter):
     def __init__(
@@ -182,7 +185,10 @@ async def search_opportunities(
             case Failure(e) if isinstance(e, ConstraintsException):
                 raise e
             case Failure(e):
-                logging.exception("An error occurred while searching opportunities", e)
+                logger.error(
+                    "An error occurred while searching opportunities: %s",
+                    traceback.format_exception(e),
+                )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
                     detail="Error searching opportunities",
@@ -221,7 +227,10 @@ async def create_order(
             case Failure(e) if isinstance(e, ConstraintsException):
                 raise e
             case Failure(e):
-                logging.exception("An error occurred while creating order", e)
+                logger.error(
+                    "An error occurred while creating order: %s",
+                    traceback.format_exception(e),
+                )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
                     detail="Error creating order",

src/stapi_fastapi/routers/root_router.py

@@ -1,4 +1,5 @@
 import logging
+import traceback
 from typing import Self
 
 from fastapi import APIRouter, HTTPException, Request, status
@@ -23,6 +24,8 @@
 from stapi_fastapi.responses import GeoJSONResponse
 from stapi_fastapi.routers.product_router import ProductRouter
 
+logger = logging.getLogger(__name__)
+
 
 class RootRouter(APIRouter):
     def __init__(
@@ -176,7 +179,10 @@ async def get_orders(self, request: Request) -> OrderCollection:
                     )
                 return orders
             case Failure(e):
-                logging.exception("An error occurred while retrieving orders", e)
+                logger.error(
+                    "An error occurred while retrieving orders: %s",
+                    traceback.format_exception(e),
+                )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
                     detail="Error finding Orders",
@@ -195,8 +201,10 @@ async def get_order(self: Self, order_id: str, request: Request) -> Order:
             case Success(Maybe.empty):
                 raise NotFoundException("Order not found")
             case Failure(e):
-                logging.exception(
-                    f"An error occurred while retrieving order '{order_id}'", e
+                logger.error(
+                    "An error occurred while retrieving order '%s': %s",
+                    order_id,
+                    traceback.format_exception(e),
                 )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
@@ -226,8 +234,9 @@ async def get_order_statuses(
                     ],
                 )
             case Failure(e):
-                logging.exception(
-                    "An error occurred while retrieving order statuses", e
+                logger.error(
+                    "An error occurred while retrieving order statuses: %s",
+                    traceback.format_exception(e),
                 )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
@@ -243,7 +252,10 @@ async def set_order_status(
             case Success(_):
                 return Response(status_code=status.HTTP_202_ACCEPTED)
             case Failure(e):
-                logging.exception("An error occurred while setting order status", e)
+                logger.error(
+                    "An error occurred while setting order status: %s",
+                    traceback.format_exception(e),
+                )
                 raise HTTPException(
                     status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
                     detail="Error setting Order Status",