feat: tweaking mock backend to use list index look up and return empty features after token lookup tests: separating empty orders check to separate test

Author: theodorehreuter

src/stapi_fastapi/routers/root_router.py

@@ -184,7 +184,7 @@ async def get_orders(
                 return collections
             case Failure(e):
                 logging.exception(f"An error occurred while retrieving orders: {e}")
-                if isinstance(e, IndexError):
+                if isinstance(e, ValueError):
                     raise NotFoundException(detail="Error finding pagination token")
                 else:
                     raise HTTPException(

tests/application.py

@@ -55,18 +55,12 @@ async def get_orders(
                 limit = 100
 
             order_ids = [*self._orders_db._orders.keys()]
-            if not order_ids and not next:  # no data in db
-                return Success(
-                    (
-                        OrderCollection(
-                            features=list(self._orders_db._orders.values())
-                        ),
-                        "",
-                    )
-                )
 
             if next:
-                start = [i for i, x in enumerate(order_ids) if x == next][0]
+                start = order_ids.index(next)
+            if not order_ids and not next:  # no data in db
+                return Success((OrderCollection(features=[]), ""))
+
             end = start + limit
             ids = order_ids[start:end]
             feats = [self._orders_db._orders[order_id] for order_id in ids]

tests/test_order.py

@@ -194,19 +194,19 @@ def create_order_payloads() -> list[OrderPayload]:
     return payloads
 
 
-@pytest.fixture
-def prepare_order_pagination(
-    stapi_client: TestClient, create_order_payloads: list[OrderPayload]
-) -> None:
-    product_id = "test-spotlight"
-
-    # check empty
+def test_empty_order(stapi_client: TestClient):
     res = stapi_client.get("/orders")
     default_orders = {"type": "FeatureCollection", "features": [], "links": []}
     assert res.status_code == status.HTTP_200_OK
     assert res.headers["Content-Type"] == "application/geo+json"
     assert res.json() == default_orders
 
+
+@pytest.fixture
+def prepare_order_pagination(
+    stapi_client: TestClient, create_order_payloads: list[OrderPayload]
+) -> None:
+    product_id = "test-spotlight"
     # get uuids created to use as pagination tokens
     for payload in create_order_payloads:
         res = stapi_client.post(