standardize links on models

Author: jkeifer

src/stapi_fastapi/models/opportunity.py

@@ -2,7 +2,7 @@
 
 from geojson_pydantic import Feature, FeatureCollection
 from geojson_pydantic.geometries import Geometry
-from pydantic import BaseModel, ConfigDict
+from pydantic import BaseModel, ConfigDict, Field
 
 from stapi_fastapi.models.shared import Link
 from stapi_fastapi.types.datetime_interval import DatetimeInterval
@@ -29,8 +29,9 @@ class OpportunityRequest(BaseModel):
 
 class Opportunity(Feature[G, P]):
     type: Literal["Feature"] = "Feature"
-    links: list[Link] = []
+    links: list[Link] = Field(default_factory=list)
 
 
 class OpportunityCollection(FeatureCollection[Opportunity[G, P]]):
     type: Literal["FeatureCollection"] = "FeatureCollection"
+    links: list[Link] = Field(default_factory=list)

src/stapi_fastapi/models/order.py

@@ -2,7 +2,7 @@
 
 from geojson_pydantic import Feature, FeatureCollection
 from geojson_pydantic.geometries import Geometry
-from pydantic import BaseModel, ConfigDict, StrictInt, StrictStr
+from pydantic import BaseModel, ConfigDict, Field, StrictInt, StrictStr
 
 from stapi_fastapi.models.shared import Link
 from stapi_fastapi.types.datetime_interval import DatetimeInterval
@@ -18,8 +18,9 @@ class Order(Feature[Geometry, OrderProperties]):
     # retrieve them via the API
     id: StrictInt | StrictStr  # type: ignore
     type: Literal["Feature"] = "Feature"
-    links: list[Link]
+    links: list[Link] = Field(default_factory=list)
 
 
 class OrderCollection(FeatureCollection[Order]):
     type: Literal["FeatureCollection"] = "FeatureCollection"
+    links: list[Link] = Field(default_factory=list)

src/stapi_fastapi/models/product.py

@@ -41,7 +41,7 @@ class Product(BaseModel):
     keywords: list[str] = Field(default_factory=list)
     license: str
     providers: list[Provider] = Field(default_factory=list)
-    links: list[Link]
+    links: list[Link] = Field(default_factory=list)
 
     # we don't want to include these in the model fields
     _constraints: type[OpportunityPropertiesBase]