Skip to content

Commit 582981b

Browse files
staredclaude
andcommitted
Fix LaTeX/Beamer GHA workflow to fail on first error
Previously the workflow would continue even when generation or compilation failed, leading to confusing error messages about missing files. This was caused by: 1. Using || true on generation commands (lines 31-34) 2. Using continue-on-error: true on compilation steps (lines 42,50,58,66) Fixed by: - Removing || true to let generation failures fail the workflow - Removing continue-on-error: true to let compilation failures fail - Adding verification step to check files exist before compilation Now the workflow will fail immediately at the first error with a clear message about what went wrong. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 1a8d682 commit 582981b

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/test-latex-beamer.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,42 +28,43 @@ jobs:
2828

2929
- name: Generate LaTeX files
3030
run: |
31-
pnpm tsx test-latex-export-real.ts || true
32-
pnpm tsx test-beamer-export.ts || true
33-
pnpm tsx test-latex-export-maxwell.ts || true
34-
pnpm tsx test-beamer-export-maxwell.ts || true
31+
pnpm tsx test-latex-export-real.ts
32+
pnpm tsx test-beamer-export.ts
33+
pnpm tsx test-latex-export-maxwell.ts
34+
pnpm tsx test-beamer-export-maxwell.ts
35+
36+
- name: Verify generated files exist
37+
run: |
38+
ls -lh /tmp/test-euler-export.tex /tmp/test-euler-beamer.tex /tmp/test-maxwell.tex /tmp/test-maxwell-beamer.tex
39+
echo "All LaTeX files generated successfully"
3540
3641
- name: Compile Euler LaTeX to PDF
3742
uses: xu-cheng/latex-action@v4
3843
with:
3944
root_file: /tmp/test-euler-export.tex
4045
working_directory: /tmp
4146
latexmk_use_lualatex: false
42-
continue-on-error: true
4347

4448
- name: Compile Euler Beamer to PDF
4549
uses: xu-cheng/latex-action@v4
4650
with:
4751
root_file: /tmp/test-euler-beamer.tex
4852
working_directory: /tmp
4953
latexmk_use_lualatex: false
50-
continue-on-error: true
5154

5255
- name: Compile Maxwell LaTeX to PDF
5356
uses: xu-cheng/latex-action@v4
5457
with:
5558
root_file: /tmp/test-maxwell.tex
5659
working_directory: /tmp
5760
latexmk_use_lualatex: false
58-
continue-on-error: true
5961

6062
- name: Compile Maxwell Beamer to PDF
6163
uses: xu-cheng/latex-action@v4
6264
with:
6365
root_file: /tmp/test-maxwell-beamer.tex
6466
working_directory: /tmp
6567
latexmk_use_lualatex: false
66-
continue-on-error: true
6768

6869
- name: Upload LaTeX artifacts
6970
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)