📝 apply best starkli practices (#189)

* Add starkli, scarb compiler version

* Update first_contract.adoc

Update  this section according to starkli official website suggestion

* Update first_contract.adoc

Author: gianalarcon

chapters/book/modules/chapter_1/pages/first_contract.adoc

@@ -13,6 +13,51 @@ scarb --version  # For Cairo code compilation
 starkli --version  # To interact with Starknet
 ----
 
+== Find the compiler versions supported
+
+We have to make sure that our Starkli compiler version match Scarb compiler version
+
+To find the compiler versions supported by Starkli, execute:
+
+[source,bash]
+----
+starkli declare --help 
+----
+
+You'll see a list of possible compiler versions under the `--compiler-version` flag.
+
+[source,bash]
+----
+--compiler-version <COMPILER_VERSION>
+          Statically-linked Sierra compiler version [possible values: [COMPILER VERSIONS]]]
+----
+
+Note that the Scarb compiler version might not align with Starkli's supported versions. To check Scarb's version:
+
+[source,bash]
+----
+scarb --version
+----
+
+You'll see a list that contains scarb, cairo and sierra version.
+
+[source,bash]
+----
+scarb <SCARB VERSION>
+cairo: <COMPILER VERSION>
+sierra: <SIERRA VERSION>
+----
+
+If there's a mismatch, it is suggested that you install the version of Scarb that uses the compiler version that Starkli supports. You can find previous releases on https://github.com/software-mansion/scarb/releases[Scarb]'s GitHub repo.
+
+To install a specific version, such as 0.6.1, run:
+
+[source,bash]
+----
+curl --proto '=https' --tlsv1.2 -sSf https://docs.swmansion.com/scarb/install.sh | sh -s -- -v 0.6.1
+----
+
+
 == Smart Wallet Setup
 
 A smart wallet comprises a Signer and an Account Descriptor. The Signer is a smart contract with a private key for signing transactions, while the Account Descriptor is a JSON file detailing the wallet's address and public key.
@@ -211,66 +256,32 @@ With the smart contract compiled, we're ready to declare it using Starkli. Befor
 
 There are three main options for RPC providers, sorted by ease of use:
 
-. *Starknet Sequencer's Gateway*: The quickest option and the one we'll use in this tutorial. It's the default for Starkli. As you dig deeper into Starknet, consider other options. The Sequencer's Gateway can get overloaded, causing transaction delays and it will be deprecated in the near future.
+. *Starknet Sequencer's Gateway*: The quickest option and it's the default for Starkli for now. The sequencer gateway is deprecated and will be disabled by StarkWare soon. You're strongly recommended to use a third-party JSON-RPC API provider like Infura, Alchemy, or Chainstack.
 . *Infura or Alchemy*: A step up in complexity. You'll need to set up an API key and choose an endpoint. For Infura, it would look like `https://starknet-goerli.infura.io/v3/<API_KEY>`. Learn more in the https://docs.infura.io/networks/starknet/how-to/choose-a-network[Infura documentation].
 . *Your Own Node*: For those who want full control. It's the most complex but offers the most freedom. Check out https://book.starknet.io/chapter_4/node.html[Chapter 4 of the Starknet Book] or https://www.kasar.io/[Kasar] for setup guides.
 
-=== Declaring Your Contract
-
-Run this command to declare your contract using the default Starknet Sequencer's Gateway:
+In this tutorial, we will use Alchemy. We can set the STARKNET_RPC environment variable to make command invocations easier:
 
 [source,bash]
 ----
-starkli declare target/dev/contracts_Ownable.sierra.json --network=goerli-1 --compiler-version=2.1.0
+export STARKNET_RPC="https://starknet-goerli.g.alchemy.com/v2/<API_KEY>"
 ----
 
-The `--network` and `--compiler-version` flags are critical for successful smart contract declaration and deployment with Starkli. 
-
-* The `--network` flag allows you to specify the target blockchain network, like "mainnet."
-* The `--compiler-version` flag lets you set the version of the Sierra compiler used to compile your contract.
-
-To find the compiler versions supported by Starkli, execute:
-
-[source,bash]
-----
-starkli declare --help 
-----
-
-You'll see a list of possible compiler versions under the `--compiler-version` flag.
-
-[source,bash]
-----
---compiler-version <COMPILER_VERSION>
-          Statically-linked Sierra compiler version [possible values: [COMPILER VERSIONS]]]
-----
+=== Declaring Your Contract
 
-Note that the Scarb compiler version might not align with Starkli's supported versions. To check Scarb's version:
+Run this command to declare your contract using the default Starknet Sequencer's Gateway:
 
 [source,bash]
 ----
-scarb --version
+starkli declare target/dev/contracts_Ownable.sierra.json 
 ----
 
-If there's a mismatch, it is suggested that you install the version of Scarb that uses the compiler version that Starkli supports. You can find previous releases on https://github.com/software-mansion/scarb/releases[Scarb]'s GitHub repo.
-
-To install a specific version, such as 0.6.1, run:
+According to the STARKNET_RPC url, starkli can recognize the target blockchain network, in this case "goerli", so it is not necessary explicitly specify it.
 
-[source,bash]
-----
-curl --proto '=https' --tlsv1.2 -sSf https://docs.swmansion.com/scarb/install.sh | sh -s -- -v 0.6.1
-----
+Unless you're working with custom networks where it's infeasible for Starkli to detect the right compiler version, you shouldn't need to manually choose a version with `--network` and `--compiler-version`.
 
 If you encounter an "Error: Invalid contract class," it likely means your Scarb's compiler version is incompatible with Starkli. Follow the steps above to align the versions. Starkli usually supports compiler versions accepted by mainnet, even if Scarb's latest version is not yet compatible.
 
-If you're using third-party providers like Infura or Alchemy for your Remote Procedure Call (RPC), the declaration command would be modified to include the `--rpc` flag.
-
-[source,bash]
-----
-starkli declare target/dev/contracts_Ownable.sierra.json \
-    --rpc=https://starknet-goerli.infura.io/v3/<API_KEY> \ 
-    --compiler-version=2.1.0
-----
-
 After running the command, you'll receive a contract class hash. This unique hash serves as the identifier for your contract class within Starknet. For example:
 
 [source,bash]
@@ -304,8 +315,7 @@ The command would look like this:
 ----
 starkli deploy \
     <CLASS_HASH> \
-    <CONSTRUCTOR_INPUTS> \
-    --network=goerli-1
+    <CONSTRUCTOR_INPUTS> 
 ----
 
 Here's a specific example with an actual class hash and constructor inputs (as the owner address use the address of your smart wallet so you can invoke the transfer_ownership function later):
@@ -314,8 +324,7 @@ Here's a specific example with an actual class hash and constructor inputs (as t
 ----
 starkli deploy \
     0x04c70a75f0246e572aa2e1e1ec4fffbe95fa196c60db8d5677a5c3a3b5b6a1a8 \
-    0x02cdAb749380950e7a7c0deFf5ea8eDD716fEb3a2952aDd4E5659655077B8510 \
-    --network=goerli-1
+    0x02cdAb749380950e7a7c0deFf5ea8eDD716fEb3a2952aDd4E5659655077B8510 
 ----
 
 After executing the command and entering your password, you should see output like the following:
@@ -344,8 +353,7 @@ The `call` command enables you to query a smart contract function without sendin
 ----
 starkli call \
     <CONTRACT_ADDRESS> \
-    get_owner \
-    --network=goerli-1
+    get_owner 
 ----
 
 Replace `<CONTRACT_ADDRESS>` with the address of your contract. The command will return the owner's address, which was initially set during the contract's deployment:
@@ -366,8 +374,7 @@ You can modify the contract's state using the `invoke` command. For example, let
 starkli invoke \
     <CONTRACT_ADDRESS> \
     transfer_ownership \
-    <NEW_OWNER_ADDRESS> \
-    --network=goerli-1
+    <NEW_OWNER_ADDRESS> 
 ----
 
 Replace `<CONTRACT_ADDRESS>` with the address of the contract and `<NEW_OWNER_ADDRESS>` with the address you want to transfer ownership to. If the smart wallet you're using isn't the contract's owner, an error will appear. Note that the initial owner was set when deploying the contract:
@@ -394,8 +401,7 @@ To verify that the ownership has successfully transferred, you can call the `get
 ----
 starkli call \
     <CONTRACT_ADDRESS> \
-    get_owner \
-    --network=goerli-1
+    get_owner 
 ----
 
 If the function returns the new owner's address, the transfer was successful.