Skip to content

Create new AffinePoint from the compressed point representation #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 15, 2025
Merged

Create new AffinePoint from the compressed point representation #127

merged 9 commits into from
Jul 15, 2025
+50 −0

Conversation

FilipLaurentiu
Copy link
Contributor

Cairo represent points on the curve just with the x coordinate (compressed). This is enough for signature verification but not enough for other operations on EC points.
This update provide a way to create a new AffinePoint from the x cordinate and the parity bit.

Pull Request type

  • Feature

What is the current behavior?

  • No option to create a new AffinePoint instance from the compressed representation.

What is the new behavior?

  • Create AffinePoints just from the x compressed representation

Does this introduce a breaking change?

No

Other information

gabrielbosio
gabrielbosio requested changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@gabrielbosio gabrielbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have left a small comment on the function documentation

@tdelabro tdelabro merged commit f984fb0 into starknet-io:main Jul 15, 2025
3 checks passed
@tdelabro
Copy link
Collaborator

Thanks @FilipLaurentiu, sorry for the 4 month it took us to merge this.
We will be more active on this repo from now on

@FilipLaurentiu
Copy link
Contributor Author

Thanks @FilipLaurentiu, sorry for the 4 month it took us to merge this. We will be more active on this repo from now on

Hey ! Thanks for the review and for the approval 👍

About the delay, the changes were not so impactful, but good to have, avoid the confusion about the point compression, but I notice delays on other, more important repos.
Starknet will benefit from giving more attention to these repos 🙏

@tdelabro
Copy link
Collaborator

@FilipLaurentiu, which other repos are you using where you faced this type of struggle? Maybe we can help improve things

@FilipLaurentiu
Copy link
Contributor Author

@FilipLaurentiu, which other repos are you using where you faced this type of struggle? Maybe we can help improve things

I am looking for some feedback on this one. It should be more involving and probably introduce some breaking changes, but it will be good to know if it's of interest or not.
And it is somehow related to this repo, here is my comment

@tdelabro
Copy link
Collaborator

@FilipLaurentiu do you have a telegram? If so, can you ping me at @tdelabro please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro approved these changes

@gabrielbosio gabrielbosio gabrielbosio approved these changes

@0xLucqs 0xLucqs 0xLucqs approved these changes

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@dan-starkware dan-starkware Awaiting requested review from dan-starkware dan-starkware is a code owner

@maciejka maciejka Awaiting requested review from maciejka

@juanbono juanbono Awaiting requested review from juanbono

@xJonathanLEI xJonathanLEI Awaiting requested review from xJonathanLEI

@antiyro antiyro Awaiting requested review from antiyro

@jbcaron jbcaron Awaiting requested review from jbcaron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FilipLaurentiu @tdelabro @gabrielbosio @0xLucqs