Replies: 2 comments
-
|
To these two kind folks who voted yes: what will you have to change in your workflows? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Scarb 2.3.0-rc0 implements this change 🎉 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello everyone!
We (@starkware-libs & @software-mansion) are considering changing compiled files extension convention, as we are going to introduce new kinds of compiled artifacts in Cairo/Sierra/CASM/Starknet. We'd like to gather quick feedback on this idea.
Context
Currently, the Cairo compiler and Scarb are capable of producing the following file types:
crate.sierracrate.casmcontract.sierra.jsoncontract.casm.jsonWe want to introduce the following new file type:
Proposal
It happens to be unfortunate that we have named Starknet compiler contract classes in a way that clashes with non-Starknet targets, so we propose to introduce a change that is a potentially breaking change for tools that rely on existing state of things (for example by listing files with specific extension):
crate.sierracrate.casmcrate.sierra.jsoncrate.sierra.Xcontract.contract_class.jsoncontract.compiled_contract_class.jsonNotable changes to Cairo compiler
cairo-compilebinary will still produce textual Sierra representation, as this is an internal tool.Notable changes to Scarb
Note
Scarb emits Starknet Artifacts files which, if treated as the only source of truth about generated artifacts, should make this convention change transparent for you tool!
If the community reaches consensus on this manner, the following changes will be implemented immediately:
starknet-contracttarget will start naming files accordingly to the new convention.libtarget will start generatingsierra.jsonfiles if thelib.sierrafield will betrue(which it is by default)libtarget will generatesierrafiles only if thelib.sierra-textfield will betrue(which will be not by default)9 votes ·
Beta Was this translation helpful? Give feedback.
All reactions