Skip to content

performance(ci): Made cairo tests run in release. #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orizi wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −18
Open

performance(ci): Made cairo tests run in release. #9583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,30 +123,20 @@ jobs:
- uses: Swatinem/rust-cache@v2
- run: scripts/cairo_fmt.sh --check

parallel-cairo-tests:
# Checks that all Cairo code tests run correctly.
cairotest:
if: ${{ always() }}
runs-on: ubuntu-latest
strategy:
matrix:
cmd:
- corelib/
- tests/bug_samples --starknet
- crates/cairo-lang-starknet/cairo_level_tests/ --starknet
steps:
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- run: |
cargo run --profile=ci-dev --bin cairo-test -- ${{ matrix.cmd }}
# Checks that all Cairo code tests run correctly.
cairotest:
if: ${{ always() }}
needs: parallel-cairo-tests
runs-on: ubuntu-latest
steps:
- if: needs.parallel-cairo-tests.result == 'success'
run: exit 0
- if: needs.parallel-cairo-tests.result != 'success'
run: exit 1
cargo run --profile=release --bin cairo-test -- corelib/
- run: |
cargo run --profile=release --bin cairo-test -- tests/bug_samples --starknet
- run: |
cargo run --profile=release --bin cairo-test -- crates/cairo-lang-starknet/cairo_level_tests/ --starknet

# Checks that error codes are not duplicated.
error-code-check:
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@ jobs:
- run: >
scripts/clippy.sh

cairotest:
if: ${{ always() }}
needs: parallel-cairo-tests
runs-on: ubuntu-latest
Comment on lines +33 to +36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove nonexistent job dependency

The new nightly cairotest job also declares needs: parallel-cairo-tests, but there is no such job in nightly.yml. GitHub Actions will reject the workflow definition, preventing the nightly schedule from running at all until the dependency is removed or the job is added.

Useful? React with 👍 / 👎.

steps:
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- run: |
cargo run --profile=ci-dev --bin cairo-test -- corelib/
- run: |
cargo run --profile=ci-dev --bin cairo-test -- tests/bug_samples --starknet
- run: |
cargo run --profile=ci-dev --bin cairo-test -- crates/cairo-lang-starknet/cairo_level_tests/ --starknet

docs:
runs-on: ubuntu-latest
steps:
Expand Down