apollo_dashboard: refactor fn with_legends to take interatble and pod label accordingly (#10228)

Author: Itay-Tsabary-Starkware

crates/apollo_dashboard/src/dashboard.rs

@@ -223,13 +223,18 @@ impl Panel {
         self
     }
 
-    pub fn with_legends<S: Into<String>>(mut self, legends: Vec<S>) -> Self {
+    pub fn with_legends<I, S>(mut self, legends: I) -> Self
+    where
+        I: IntoIterator<Item = S>,
+        S: Into<String>,
+    {
+        let legends: Vec<String> = legends.into_iter().map(|s| s.into()).collect();
         assert_eq!(
             legends.len(),
             self.exprs.len(),
             "Number of legends must match number of expressions"
         );
-        self.extra.legends = Some(legends.into_iter().map(|s| s.into()).collect());
+        self.extra.legends = Some(legends);
         self
     }
 
@@ -346,12 +351,7 @@ impl Panel {
             description,
             format!("le, {}", group_label),
         )
-        .with_legends(
-            HISTOGRAM_QUANTILES
-                .iter()
-                .map(|q| format!("{:.2} {{{{{}}}}}", q, group_label))
-                .collect(),
-        )
+        .with_legends(HISTOGRAM_QUANTILES.iter().map(|q| format!("{q:.2} {{{{{group_label}}}}}")))
     }
 }
 

crates/apollo_dashboard/src/infra_panels.rs

@@ -15,6 +15,7 @@ use crate::query_builder::increase;
 
 const INFRA_ROW_TITLE_SUFFIX: &str = "Infra";
 const INFRA_INCREASE_DURATION: &str = "1m";
+pub(crate) const POD_LEGEND: [&str; 1] = ["{{pod}}"];
 
 pub(crate) fn get_component_infra_row(row_name: impl ToString, metrics: &InfraMetrics) -> Row {
     let mut panels: Vec<Panel> = Vec::new();

crates/apollo_dashboard/src/panels/tokio.rs

@@ -11,8 +11,8 @@ use apollo_monitoring_endpoint::tokio_metrics::{
 };
 
 use crate::dashboard::{Panel, PanelType, Row, Unit};
+use crate::infra_panels::POD_LEGEND;
 use crate::query_builder::increase;
-const TOKIO_PANEL_LEGENDS: &[&str] = &["{{pod}}"];
 
 fn get_panel_tokio_total_busy_duration_micros() -> Panel {
     Panel::new(
@@ -21,7 +21,7 @@ fn get_panel_tokio_total_busy_duration_micros() -> Panel {
         increase(&TOKIO_TOTAL_BUSY_DURATION_MICROS, "1m"),
         PanelType::TimeSeries,
     )
-    .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    .with_legends(POD_LEGEND)
     .with_unit(Unit::Microseconds)
 }
 fn get_panel_tokio_min_busy_duration_micros() -> Panel {
@@ -31,7 +31,7 @@ fn get_panel_tokio_min_busy_duration_micros() -> Panel {
         TOKIO_MIN_BUSY_DURATION_MICROS.get_name_with_filter().to_string(),
         PanelType::TimeSeries,
     )
-    .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    .with_legends(POD_LEGEND)
     .with_unit(Unit::Microseconds)
 }
 fn get_panel_tokio_max_busy_duration_micros() -> Panel {
@@ -41,29 +41,24 @@ fn get_panel_tokio_max_busy_duration_micros() -> Panel {
         TOKIO_MAX_BUSY_DURATION_MICROS.get_name_with_filter().to_string(),
         PanelType::TimeSeries,
     )
-    .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    .with_legends(POD_LEGEND)
     .with_unit(Unit::Microseconds)
 }
 
 fn get_panel_tokio_total_park_count() -> Panel {
-    Panel::from_gauge(&TOKIO_TOTAL_PARK_COUNT, PanelType::TimeSeries)
-        .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    Panel::from_gauge(&TOKIO_TOTAL_PARK_COUNT, PanelType::TimeSeries).with_legends(POD_LEGEND)
 }
 fn get_panel_tokio_min_park_count() -> Panel {
-    Panel::from_gauge(&TOKIO_MIN_PARK_COUNT, PanelType::TimeSeries)
-        .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    Panel::from_gauge(&TOKIO_MIN_PARK_COUNT, PanelType::TimeSeries).with_legends(POD_LEGEND)
 }
 fn get_panel_tokio_max_park_count() -> Panel {
-    Panel::from_gauge(&TOKIO_MAX_PARK_COUNT, PanelType::TimeSeries)
-        .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    Panel::from_gauge(&TOKIO_MAX_PARK_COUNT, PanelType::TimeSeries).with_legends(POD_LEGEND)
 }
 fn get_panel_tokio_global_queue_depth() -> Panel {
-    Panel::from_gauge(&TOKIO_GLOBAL_QUEUE_DEPTH, PanelType::TimeSeries)
-        .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    Panel::from_gauge(&TOKIO_GLOBAL_QUEUE_DEPTH, PanelType::TimeSeries).with_legends(POD_LEGEND)
 }
 fn get_panel_tokio_workers_count() -> Panel {
-    Panel::from_gauge(&TOKIO_WORKERS_COUNT, PanelType::TimeSeries)
-        .with_legends(TOKIO_PANEL_LEGENDS.to_vec())
+    Panel::from_gauge(&TOKIO_WORKERS_COUNT, PanelType::TimeSeries).with_legends(POD_LEGEND)
 }
 
 pub(crate) fn get_tokio_row() -> Row {