Skip to content

Commit 2e942e2

Browse files
apollo_storage,apollo_rpc: migrate hyper to 1.x PART 10 (#12074)
1 parent 854ea51 commit 2e942e2

File tree

7 files changed

+77
-95
lines changed

7 files changed

+77
-95
lines changed

Cargo.lock

Lines changed: 31 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ async-recursion = "1.1.0"
218218
async-stream = "0.3.3"
219219
async-trait = "0.1.79"
220220
asynchronous-codec = "0.7.0"
221+
# TODO(victork): finalise migration to hyper 1.x
221222
axum_08 = { package = "axum", version = "0.8" }
222223
base64 = "0.13.0"
223224
bench_tools.path = "crates/bench_tools"
@@ -276,9 +277,7 @@ insta = "1.29.0"
276277
integer-encoding = "3.0.4"
277278
itertools = "0.12.1"
278279
json-patch = "4.1.0"
279-
tower = { package = "tower", version = "0.4.13" }
280-
# TODO(victork): upgrade to jsonrpsee 0.26+ (uses tower 0.5, but has breaking API changes in RpcServiceT)
281-
jsonrpsee = "0.24.10"
280+
jsonrpsee = "0.26.0"
282281
jsonschema = "0.17.0"
283282
keccak = "0.1.3"
284283
lazy_static = "1.5.0"
@@ -376,6 +375,7 @@ tokio-test = "0.4.4"
376375
tokio-util = "0.7.13"
377376
toml = "0.8"
378377
toml_test_utils.path = "toml_test_utils"
378+
tower = { package = "tower", version = "0.4.13" }
379379
tower_05 = { package = "tower", version = "0.5.2" }
380380
tracing = "0.1.37"
381381
tracing-subscriber = "0.3.16"

crates/apollo_rpc/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ serde_json = { workspace = true, features = ["arbitrary_precision"] }
3030
starknet-types-core.workspace = true
3131
starknet_api.workspace = true
3232
tokio = { workspace = true, features = ["full", "sync"] }
33-
# tower 0.4 is required for jsonrpsee 0.24 http middleware compatibility (jsonrpsee expects tower 0.4 types)
34-
tower = { version = "0.4.13", features = ["full"] }
3533
tower_05 = { workspace = true, features = ["full"] }
3634
tracing.workspace = true
3735
validator = { workspace = true, features = ["derive"] }

crates/apollo_rpc/src/lib.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ use apollo_storage::state::StateStorageReader;
3333
use apollo_storage::{StorageReader, StorageScope, StorageTxn};
3434
use jsonrpsee::core::RpcResult;
3535
use jsonrpsee::server::middleware::rpc::RpcServiceBuilder;
36-
use jsonrpsee::server::{Server, ServerHandle};
36+
use jsonrpsee::server::{Server, ServerConfig, ServerHandle};
3737
use jsonrpsee::types::error::ErrorCode::InternalError;
3838
use jsonrpsee::types::error::INTERNAL_ERROR_MSG;
3939
use jsonrpsee::types::ErrorObjectOwned;
@@ -44,6 +44,7 @@ use serde::{Deserialize, Serialize};
4444
use starknet_api::block::{BlockHashAndNumber, BlockNumber, BlockStatus};
4545
use starknet_api::core::ChainId;
4646
use tokio::sync::RwLock;
47+
use tower_05::ServiceBuilder;
4748
use tracing::{debug, error, info, instrument};
4849
// Aliasing the latest version of the RPC.
4950
use v0_8 as latest;
@@ -244,9 +245,10 @@ pub async fn run_server(
244245
);
245246
let addr;
246247
let handle;
248+
let server_config = ServerConfig::builder().max_request_body_size(SERVER_MAX_BODY_SIZE).build();
247249
let server_builder = Server::builder()
248-
.max_request_body_size(SERVER_MAX_BODY_SIZE)
249-
.set_http_middleware(tower::ServiceBuilder::new().filter_async(proxy_rpc_request));
250+
.set_config(server_config)
251+
.set_http_middleware(ServiceBuilder::new().filter_async(proxy_rpc_request));
250252

251253
let server_address = SocketAddr::new(config.ip, config.port);
252254

crates/apollo_rpc/src/middleware.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use jsonrpsee::core::http_helpers::read_body;
22
use jsonrpsee::server::HttpRequest;
33
use regex::Regex;
4-
use tower::BoxError;
4+
use tower_05::BoxError;
55
use tracing::debug;
66

77
use crate::version_config::{VERSION_0_8, VERSION_PATTERN};

0 commit comments

Comments
 (0)