starknet_os: add proof virtual os output header

Author: meship-starkware

crates/apollo_consensus_orchestrator/resources/central_invoke_tx_client_side_proving.json

@@ -35,9 +35,12 @@
         "proof_facts": [
             "0x5649525455414c5f534e4f53",
             "0x4",
+            "0x0",
             "0x7a0",
             "0x2fa80",
-            "0x1"
+            "0x1",
+            "0x10",
+            "0x0"
         ],
         "type": "INVOKE_FUNCTION"
     },

crates/apollo_consensus_orchestrator/resources/central_preconfirmed_block.json

@@ -60,9 +60,12 @@
             "proof_facts": [
                 "0x5649525455414c5f534e4f53",
                 "0x4",
+                "0x0",
                 "0x7a0",
                 "0x2fa80",
-                "0x1"
+                "0x1",
+                "0x10",
+                "0x0"
             ],
             "type":"INVOKE_FUNCTION"
         },

crates/apollo_http_server/resources/deprecated_gateway/invoke_tx_client_side_proving.json

@@ -29,9 +29,12 @@
   "proof_facts": [
     "0x5649525455414c5f534e4f53",
     "0x4",
+    "0x0",
     "0x7a0",
     "0x2fa80",
-    "0x1"
+    "0x1",
+    "0x10",
+    "0x0"
   ],
   "proof": [
     1,

crates/apollo_starknet_client/resources/reader/invoke_v3_client_side_proving.json

@@ -35,8 +35,11 @@
     "proof_facts": [
         "0x5649525455414c5f534e4f53",
         "0x4",
+        "0x0",
         "0x7a0",
         "0x2fa80",
-        "0x1"
+        "0x1",
+        "0x10",
+        "0x0"
     ]
 }

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/os_utils__virtual.cairo

@@ -3,11 +3,11 @@ from starkware.cairo.common.bool import FALSE, TRUE
 from starkware.cairo.common.cairo_builtins import EcOpBuiltin, PoseidonBuiltin
 from starkware.cairo.common.dict_access import DictAccess
 from starkware.cairo.common.memcpy import memcpy
-from starkware.cairo.common.serialize import serialize_word
 from starkware.starknet.core.os.block_context import BlockContext, OsGlobalContext, VirtualOsConfig
 from starkware.starknet.core.os.block_hash import get_block_hashes
 from starkware.starknet.core.os.output import OsOutput, OsOutputHeader
 from starkware.starknet.core.os.state.commitment import CommitmentUpdate
+from starkware.starknet.core.os.virtual_os_output import VirtualOsOutputHeader
 
 const VIRTUAL_OS_OUTPUT_VERSION = 0;
 
@@ -66,20 +66,28 @@ func process_os_output{
     assert n_blocks = 1;
     let os_output = os_outputs[0];
 
-    // Serialize the header.
+    // Serialize the header using memcpy to enforce struct field order.
     let header = os_output.header;
-    serialize_word(VIRTUAL_OS_OUTPUT_VERSION);
-    serialize_word(header.prev_block_number);
-    serialize_word(header.prev_block_hash);
-    serialize_word(header.starknet_os_config_hash);
-    serialize_word(os_global_context.virtual_os_config.authorized_account_address);
 
     // TODO(Yoni): output the hash of the messages instead.
     let messages_to_l1_segment_size = (
         os_output.final_carried_outputs.messages_to_l1 -
         os_output.initial_carried_outputs.messages_to_l1
     );
-    serialize_word(messages_to_l1_segment_size);
+
+    // Create the virtual OS output header.
+    tempvar virtual_os_output_header = new VirtualOsOutputHeader(
+        version=VIRTUAL_OS_OUTPUT_VERSION,
+        prev_block_number=header.prev_block_number,
+        prev_block_hash=header.prev_block_hash,
+        starknet_os_config_hash=os_global_context.starknet_os_config_hash,
+        authorized_account_address=os_global_context.virtual_os_config.authorized_account_address,
+        messages_to_l1_segment_size=messages_to_l1_segment_size,
+    );
+
+    // Copy the header to the output.
+    memcpy(dst=output_ptr, src=virtual_os_output_header, len=VirtualOsOutputHeader.SIZE);
+    let output_ptr = &output_ptr[VirtualOsOutputHeader.SIZE];
 
     // Copy 'messages_to_l1_segment' to the correct place in the output segment.
     memcpy(

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo

@@ -0,0 +1,8 @@
+struct VirtualOsOutputHeader {
+    version: felt,
+    prev_block_number: felt,
+    prev_block_hash: felt,
+    starknet_os_config_hash: felt,
+    authorized_account_address: felt,
+    messages_to_l1_segment_size: felt,
+}

crates/apollo_starknet_os_program/src/program_hash.json

@@ -1,6 +1,6 @@
 {
   "os": "0x1d1dc21f9e82e8dc91f1703d8544ae0aa6814b557aa85a87068bb79ecc0c649",
-  "virtual_os": "0x4d734178c8a8415d26bd4623ee06b630d718f88a03d714fac0f89674b1f9cf0",
+  "virtual_os": "0x68097237de5c60d6a971c768006d147913f44c5e48061a6cf8fae1765572411",
   "aggregator": "0x63868c8dbf389119d95bae88b80043f5d237d3ddec072fb8f2095fcfacb9b1c",
   "aggregator_with_prefix": "0xd892fd2fd978d8c2749a6678457ca99161f3d1822e4c3b8c03914817c6de1a"
 }

crates/apollo_starknet_os_program/src/virtual_os_test.rs

@@ -22,7 +22,7 @@ fn test_program_bytecode_lengths() {
     "#]]
     .assert_debug_eq(&OS_PROGRAM.data_len());
     expect![[r#"
-        11615
+        11604
     "#]]
     .assert_debug_eq(&VIRTUAL_OS_PROGRAM.data_len());
 }

crates/starknet_api/src/test_utils.rs

@@ -375,6 +375,7 @@ impl ProofFacts {
     /// See [`crate::transaction::fields::ProofFacts`].
     pub fn snos_proof_facts_for_testing() -> Self {
         let program_hash = felt!("0x4");
+        let version = felt!("0x0");
         let block_hash_history_start = CURRENT_BLOCK_NUMBER - BLOCK_HASH_HISTORY_RANGE;
         let block_number = felt!(block_hash_history_start + 2);
         let block_hash = block_number * felt!(100_u64);
@@ -385,7 +386,20 @@ impl ProofFacts {
         );
         // TODO(AvivG): Change to valid values when available.
         let config_hash = felt!("0x1");
-        proof_facts![felt!(VIRTUAL_SNOS), program_hash, block_number, block_hash, config_hash]
+        // This fields are verified only by the contract but assumed as part of the proof facts in
+        // the OS.
+        let authorized_account_address = felt!("0x10");
+        let messages_to_l1_segment_size = felt!("0x0");
+        proof_facts![
+            felt!(VIRTUAL_SNOS),
+            program_hash,
+            version,
+            block_number,
+            block_hash,
+            config_hash,
+            authorized_account_address,
+            messages_to_l1_segment_size
+        ]
     }
 }
 

crates/starknet_api/src/transaction/fields.rs

@@ -662,7 +662,8 @@ impl TryFrom<&ProofFacts> for ProofFactsVariant {
             )));
         }
 
-        let [program_hash, block_number_felt, block_hash, config_hash, ..] = snos_fields else {
+        let [program_hash, _version, block_number_felt, block_hash, config_hash, ..] = snos_fields
+        else {
             return Err(StarknetApiError::InvalidProofFacts(format!(
                 "SNOS proof facts must have at least 5 fields, got {}",
                 proof_facts.0.len()