apollo_gateway: create GCS client and write proof to GCS (#11497)

Author: einat-starkware

Cargo.lock

@@ -17,7 +17,7 @@
   "gateway_config.contract_class_manager_config.native_compiler_config.max_memory_usage": 16106127360,
   "gateway_config.contract_class_manager_config.native_compiler_config.max_memory_usage.#is_none": false,
   "gateway_config.contract_class_manager_config.native_compiler_config.optimization_level": 2,
-  "gateway_config.proof_archive_writer_config.bucket_name": "proof-archive",
+  "gateway_config.proof_archive_writer_config.bucket_name": "",
   "gateway_config.stateful_tx_validator_config.max_allowed_nonce_gap": 200,
   "gateway_config.stateful_tx_validator_config.max_nonce_for_validation_skip": "0x1",
   "gateway_config.stateful_tx_validator_config.min_gas_price_percentage": 100,

crates/apollo_deployments/resources/app_configs/gateway_config.json

@@ -17,7 +17,7 @@
   "gateway_config.contract_class_manager_config.native_compiler_config.max_memory_usage": 16106127360,
   "gateway_config.contract_class_manager_config.native_compiler_config.max_memory_usage.#is_none": false,
   "gateway_config.contract_class_manager_config.native_compiler_config.optimization_level": 2,
-  "gateway_config.proof_archive_writer_config.bucket_name": "proof-archive",
+  "gateway_config.proof_archive_writer_config.bucket_name": "$$$_GATEWAY_CONFIG-PROOF_ARCHIVE_WRITER_CONFIG-BUCKET_NAME_$$$",
   "gateway_config.stateful_tx_validator_config.max_allowed_nonce_gap": "$$$_GATEWAY_CONFIG-STATEFUL_TX_VALIDATOR_CONFIG-MAX_ALLOWED_NONCE_GAP_$$$",
   "gateway_config.stateful_tx_validator_config.max_nonce_for_validation_skip": "0x1",
   "gateway_config.stateful_tx_validator_config.min_gas_price_percentage": 100,

crates/apollo_deployments/resources/app_configs/replacer_gateway_config.json

@@ -75,6 +75,7 @@ pub static KEYS_TO_BE_REPLACED: phf::Set<&'static str> = phf_set! {
     "gateway_config.authorized_declarer_accounts.#is_none",
     "gateway_config.authorized_declarer_accounts",
     "gateway_config.contract_class_manager_config.native_compiler_config.max_cpu_time",
+    "gateway_config.proof_archive_writer_config.bucket_name",
     "gateway_config.stateful_tx_validator_config.max_allowed_nonce_gap",
     "gateway_config.stateless_tx_validator_config.min_gas_price",
     "http_server_config.static_config.port",

crates/apollo_deployments/src/service.rs

@@ -38,6 +38,7 @@ blockifier.workspace = true
 blockifier_test_utils = { workspace = true, optional = true }
 cairo-lang-starknet-classes.workspace = true
 clap.workspace = true
+google-cloud-storage.workspace = true
 mempool_test_utils.workspace = true
 mockall.workspace = true
 num-rational.workspace = true

crates/apollo_gateway/Cargo.toml

@@ -43,7 +43,11 @@ use crate::errors::{
     GatewayResult,
 };
 use crate::metrics::{register_metrics, GatewayMetricHandle, GATEWAY_ADD_TX_LATENCY};
-use crate::proof_archive_writer::{GcsProofArchiveWriter, ProofArchiveWriterTrait};
+use crate::proof_archive_writer::{
+    GcsProofArchiveWriter,
+    NoOpProofArchiveWriter,
+    ProofArchiveWriterTrait,
+};
 use crate::state_reader::StateReaderFactory;
 use crate::stateful_transaction_validator::{
     StatefulTransactionValidatorFactory,
@@ -246,8 +250,15 @@ pub fn create_gateway(
     let stateless_tx_validator = Arc::new(StatelessTransactionValidator {
         config: config.stateless_tx_validator_config.clone(),
     });
-    let proof_archive_writer =
-        Arc::new(GcsProofArchiveWriter::new(config.proof_archive_writer_config.clone()));
+
+    // Create proof archive writer: use NoOp if bucket name is empty, otherwise use real GCS.
+    let proof_archive_writer: Arc<dyn ProofArchiveWriterTrait> =
+        if config.proof_archive_writer_config.bucket_name.is_empty() {
+            Arc::new(NoOpProofArchiveWriter)
+        } else {
+            Arc::new(GcsProofArchiveWriter::new(config.proof_archive_writer_config.clone()))
+        };
+
     Gateway::new(
         config,
         state_reader_factory,

crates/apollo_gateway/src/gateway.rs

@@ -1,5 +1,7 @@
 use apollo_gateway_config::config::ProofArchiveWriterConfig;
 use async_trait::async_trait;
+use google_cloud_storage::client::{Client, ClientConfig};
+use google_cloud_storage::http::objects::upload::{Media, UploadObjectRequest, UploadType};
 #[cfg(any(feature = "testing", test))]
 use mockall::automock;
 use starknet_api::transaction::fields::{Proof, ProofFacts};
@@ -22,27 +24,61 @@ pub enum ProofArchiveError {
     WriteError(String),
 }
 
-#[derive(Clone, Default)]
+#[derive(Clone)]
 pub struct GcsProofArchiveWriter {
-    // TODO(Einat): remove #[allow(dead_code)] once implemented.
-    #[allow(dead_code)]
     config: ProofArchiveWriterConfig,
+    client: Client,
 }
 
 impl GcsProofArchiveWriter {
     pub fn new(config: ProofArchiveWriterConfig) -> Self {
-        Self { config }
+        let client = Client::new(ClientConfig::default());
+        Self { config, client }
     }
 }
 
 #[async_trait]
 impl ProofArchiveWriterTrait for GcsProofArchiveWriter {
+    async fn set_proof(
+        &self,
+        proof_facts: ProofFacts,
+        proof: Proof,
+    ) -> Result<(), ProofArchiveError> {
+        let facts_hash = proof_facts.hash();
+        let proof_bytes: Vec<u8> = proof.0.iter().flat_map(|&val| val.to_be_bytes()).collect();
+        let object_name = format!("proofs/{}", facts_hash);
+
+        self.client
+            .upload_object(
+                &UploadObjectRequest {
+                    bucket: self.config.bucket_name.clone(),
+                    ..Default::default()
+                },
+                proof_bytes,
+                &UploadType::Simple(Media::new(object_name)),
+            )
+            .await
+            .map_err(|e| {
+                ProofArchiveError::WriteError(format!("Failed to upload to GCS: {}", e))
+            })?;
+
+        Ok(())
+    }
+}
+
+/// No-op proof archive writer that does nothing.
+/// Used in tests and when proof archiving is disabled.
+#[derive(Clone, Default)]
+pub struct NoOpProofArchiveWriter;
+
+#[async_trait]
+impl ProofArchiveWriterTrait for NoOpProofArchiveWriter {
     async fn set_proof(
         &self,
         _proof_facts: ProofFacts,
         _proof: Proof,
     ) -> Result<(), ProofArchiveError> {
-        // TODO(Einat): Write proof to GCS.
+        // No-op: do nothing in test environments.
         Ok(())
     }
 }

crates/apollo_gateway/src/proof_archive_writer.rs

@@ -281,12 +281,21 @@ impl Default for ProofArchiveWriterConfig {
     }
 }
 
+#[cfg(any(feature = "testing", test))]
+impl ProofArchiveWriterConfig {
+    pub fn create_for_testing() -> Self {
+        // Use empty bucket name for tests to trigger mock proof writer.
+        Self { bucket_name: String::new() }
+    }
+}
+
 impl SerializeConfig for ProofArchiveWriterConfig {
     fn dump(&self) -> BTreeMap<ParamPath, SerializedParam> {
         BTreeMap::from_iter([ser_param(
             "bucket_name",
             &self.bucket_name,
-            "The name of the bucket to write proofs to.",
+            "The name of the bucket to write proofs to. An empty string indicates a test \
+             environment that does not connect to GCS.",
             ParamPrivacyInput::Public,
         )])
     }

crates/apollo_gateway_config/src/config.rs

@@ -29,7 +29,7 @@ apollo_consensus_manager_config.workspace = true
 apollo_consensus_orchestrator.workspace = true
 apollo_consensus_orchestrator_config.workspace = true
 apollo_deployments.workspace = true
-apollo_gateway_config.workspace = true
+apollo_gateway_config = { workspace = true, features = ["testing"] }
 apollo_http_server = { workspace = true, features = ["testing"] }
 apollo_infra = { workspace = true, features = ["testing"] }
 apollo_infra_utils = { workspace = true, features = ["testing"] }

crates/apollo_integration_tests/Cargo.toml

@@ -630,7 +630,7 @@ pub fn create_gateway_config(
         ..Default::default()
     };
     let contract_class_manager_config = ContractClassManagerConfig::default();
-    let proof_archive_writer_config = ProofArchiveWriterConfig::default();
+    let proof_archive_writer_config = ProofArchiveWriterConfig::create_for_testing();
 
     GatewayConfig {
         stateless_tx_validator_config,