starknet_os: run tests directly (#7675)

Author: nimrod-starkware

Cargo.lock

@@ -28,10 +28,6 @@ cairo-vm = { workspace = true, features = [
   "cairo-0-data-availability-hints",
   "cairo-0-secp-hints",
 ] }
-# Should be moved under `testing` feature, when it exists.
-num-bigint = { workspace = true, features = ["rand"] }
-# Should be moved under `testing` feature, when it exists.
-num-integer.workspace = true
 clap = { workspace = true, features = ["cargo", "derive"] }
 derive_more.workspace = true
 ethnum.workspace = true

crates/starknet_committer_and_os_cli/Cargo.toml

@@ -1,5 +1,2 @@
-pub mod aliases;
-pub mod bls_field;
 pub mod python_tests;
 pub mod types;
-pub mod utils;

crates/starknet_committer_and_os_cli/src/os_cli/tests.rs

@@ -3,15 +3,11 @@ use starknet_os::test_utils::errors::OsSpecificTestError;
 use starknet_types_core::felt::Felt;
 
 use crate::os_cli::commands::{validate_os_input, OsCliInput};
-use crate::os_cli::tests::aliases::aliases_test;
-use crate::os_cli::tests::bls_field::test_bls_field;
 use crate::os_cli::tests::types::{OsPythonTestError, OsPythonTestResult};
 use crate::shared_utils::types::{PythonTestError, PythonTestRunner};
 
 // Enum representing different Python tests.
 pub enum OsPythonTestRunner {
-    AliasesTest,
-    BlsFieldTest,
     InputDeserialization,
     EncodeFelts,
 }
@@ -22,8 +18,6 @@ impl TryFrom<String> for OsPythonTestRunner {
 
     fn try_from(value: String) -> Result<Self, Self::Error> {
         match value.as_str() {
-            "aliases_test" => Ok(Self::AliasesTest),
-            "bls_field_test" => Ok(Self::BlsFieldTest),
             "input_deserialization" => Ok(Self::InputDeserialization),
             "encode_felts" => Ok(Self::EncodeFelts),
             _ => Err(PythonTestError::UnknownTestName(value)),
@@ -36,8 +30,6 @@ impl PythonTestRunner for OsPythonTestRunner {
     #[allow(clippy::result_large_err)]
     async fn run(&self, input: Option<&str>) -> OsPythonTestResult {
         match self {
-            Self::AliasesTest => aliases_test(),
-            Self::BlsFieldTest => test_bls_field(),
             Self::InputDeserialization => input_deserialization(Self::non_optional_input(input)?),
             Self::EncodeFelts => {
                 let felts: Vec<Felt> = serde_json::from_str(Self::non_optional_input(input)?)?;

crates/starknet_committer_and_os_cli/src/os_cli/tests/python_tests.rs

@@ -54,9 +54,11 @@ strum_macros.workspace = true
 thiserror.workspace = true
 
 [dev-dependencies]
+apollo_starknet_os_program = { workspace = true, features = ["test_programs"] }
 assert_matches.workspace = true
 blockifier = { workspace = true, features = ["testing"] }
 blockifier_test_utils.workspace = true
+ethnum.workspace = true
 rand.workspace = true
 rstest.workspace = true
 starknet_patricia = { workspace = true, features = ["testing"] }

crates/starknet_committer_and_os_cli/src/os_cli/tests/utils.rs

@@ -7,4 +7,6 @@ pub mod runner;
 pub mod syscall_handler_utils;
 #[cfg(any(test, feature = "testing"))]
 pub mod test_utils;
+#[cfg(test)]
+pub(crate) mod tests;
 pub mod vm_utils;

crates/starknet_os/Cargo.toml

@@ -1,3 +1,4 @@
 pub mod cairo_runner;
 pub mod errors;
+#[cfg(test)]
 pub mod utils;

crates/starknet_os/src/lib.rs

@@ -1,8 +1,14 @@
 use std::any::Any;
 use std::collections::HashMap;
+use std::sync::LazyLock;
 
+use ethnum::U256;
+use num_bigint::{BigInt, Sign};
+use rand::rngs::StdRng;
+use rand::SeedableRng;
 use starknet_types_core::felt::Felt;
 
+use crate::hints::hint_implementation::kzg::utils::BASE;
 use crate::test_utils::cairo_runner::{
     run_cairo_0_entry_point,
     Cairo0EntryPointRunnerResult,
@@ -55,3 +61,65 @@ pub fn create_squashed_cairo_dict(
     }
     PointerArg::Composed(squashed_dict)
 }
+
+// 2**251 + 17 * 2**192 + 1
+pub static DEFAULT_PRIME: LazyLock<BigInt> = LazyLock::new(|| {
+    BigInt::from_bytes_be(
+        Sign::Plus,
+        &(U256::from(2_u32).pow(251) + 17 * U256::from(2_u32).pow(192) + 1).to_be_bytes(),
+    )
+});
+
+#[allow(clippy::too_many_arguments, dead_code)]
+pub(crate) fn test_cairo_function(
+    runner_config: &EntryPointRunnerConfig,
+    program_bytes: &[u8],
+    function_name: &str,
+    explicit_args: &[EndpointArg],
+    implicit_args: &[ImplicitArg],
+    expected_explicit_retdata: &[EndpointArg],
+    expected_implicit_retdata: &[EndpointArg],
+    hint_locals: HashMap<String, Box<dyn Any>>,
+) {
+    run_cairo_function_and_check_result(
+        runner_config,
+        program_bytes,
+        function_name,
+        explicit_args,
+        implicit_args,
+        expected_explicit_retdata,
+        expected_implicit_retdata,
+        hint_locals,
+    )
+    .unwrap();
+}
+
+#[allow(dead_code)]
+pub(crate) fn seeded_random_prng() -> StdRng {
+    StdRng::seed_from_u64(42)
+}
+
+/// Returns the lift of the given field element, val, as a `BigInt` in the range
+/// (-prime/2, prime/2).
+// TODO(Amos): Use cairo VM version if it is made public:
+// https://github.com/lambdaclass/cairo-vm/blob/052e7cef977b336305c869fccbf24e1794b116ff/vm/src/hint_processor/builtin_hint_processor/kzg_da/mod.rs#L90
+fn as_int(val: &Felt, prime: &BigInt) -> BigInt {
+    let val = val.to_bigint();
+    if val < (prime / BigInt::from(2)) {
+        return val.clone();
+    }
+    val - prime
+}
+
+/// Takes a BigInt3 struct represented by the limbs (d0, d1, d2) of
+/// and reconstructs the corresponding integer (see split_bigint3()).
+/// Note that the limbs do not have to be in the range [0, BASE).
+/// Prime is used to handle negative values of the limbs.
+// TODO(Amos): Use cairo VM version if it is made public:
+// https://github.com/lambdaclass/cairo-vm/blob/052e7cef977b336305c869fccbf24e1794b116ff/vm/src/hint_processor/builtin_hint_processor/kzg_da/mod.rs#L99
+pub fn pack_bigint3(limbs: &[Felt]) -> BigInt {
+    assert!(limbs.len() == 3, "Expected 3 limbs, got {}", limbs.len());
+    limbs.iter().enumerate().fold(BigInt::ZERO, |acc, (i, &limb)| {
+        acc + as_int(&limb, &DEFAULT_PRIME) * BASE.pow(i.try_into().unwrap())
+    })
+}

crates/starknet_os/src/test_utils.rs

@@ -0,0 +1,2 @@
+pub(crate) mod aliases;
+pub(crate) mod bls_field;