starknet_os: refactor nondet hint IsBlockNumberInBlockHashBuffer (#11096)

Author: dorimedini-starkware

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/execution/syscall_impls.cairo

@@ -718,10 +718,9 @@ func execute_get_block_hash{
 
     // A block number is a u64. STORED_BLOCK_HASH_BUFFER is 10.
     // The following computations will not overflow.
-    if (nondet %{
-            ids.request_block_number > \
-                       ids.current_block_number - ids.STORED_BLOCK_HASH_BUFFER
-        %} != FALSE) {
+    local is_block_number_in_block_hash_buffer;
+    %{ IsBlockNumberInBlockHashBuffer %}
+    if (is_block_number_in_block_hash_buffer != FALSE) {
         assert_lt(current_block_number, request_block_number + STORED_BLOCK_HASH_BUFFER);
         write_failure_response(
             remaining_gas=remaining_gas, failure_felt=ERROR_BLOCK_NUMBER_OUT_OF_RANGE

crates/apollo_starknet_os_program/src/program_hash.json

@@ -1,5 +1,5 @@
 {
-  "os": "0x4637bc6cf77c7dae823d849d8a7b04ba63c2992f7176f7b72a683d2665a352f",
+  "os": "0x78de920a6e5b0f1d08410961ba9997181139e260a6dcbdce9e185d4f6fb9162",
   "aggregator": "0x9b8449bd89d58c92904972e8be142e87b00edc38c19e0a331c30790771653",
   "aggregator_with_prefix": "0x606fbb6fd6b4d56443467ac666fba1dc41e291f2faf3729aff708318d193f63"
 }

crates/starknet_os/src/hints/enum_definition.rs

@@ -418,13 +418,7 @@ define_hint_enum!(
 
 define_stateless_hint_enum!(
     StatelessHint,
-    (
-        IsBlockNumberInBlockHashBuffer,
-        is_block_number_in_block_hash_buffer,
-        // CHANGED: whitespaces.
-        r#"memory[ap] = to_felt_or_relocatable(ids.request_block_number > \
-           ids.current_block_number - ids.STORED_BLOCK_HASH_BUFFER)"#
-    ),
+    (IsBlockNumberInBlockHashBuffer, is_block_number_in_block_hash_buffer),
     (GetBlockHashMapping, get_block_hash_mapping),
     (IsLeaf, is_leaf),
     // Builtin selection hints are non-whitelisted hints that are part of cairo common.

crates/starknet_os/src/hints/hint_implementation/execute_syscalls.rs

@@ -2,7 +2,7 @@ use blockifier::state::state_api::StateReader;
 use cairo_vm::hint_processor::builtin_hint_processor::hint_utils::{
     get_integer_from_var_name,
     get_ptr_from_var_name,
-    insert_value_into_ap,
+    insert_value_from_var_name,
 };
 use starknet_types_core::felt::Felt;
 
@@ -22,7 +22,13 @@ pub(crate) fn is_block_number_in_block_hash_buffer(
     let stored_block_hash_buffer = Const::StoredBlockHashBuffer.fetch(constants)?;
     let is_block_number_in_block_hash_buffer =
         request_block_number > current_block_number - stored_block_hash_buffer;
-    insert_value_into_ap(vm, Felt::from(is_block_number_in_block_hash_buffer))?;
+    insert_value_from_var_name(
+        Ids::IsBlockNumberInBlockHashBuffer.into(),
+        Felt::from(is_block_number_in_block_hash_buffer),
+        vm,
+        ids_data,
+        ap_tracking,
+    )?;
     Ok(())
 }
 

crates/starknet_os/src/hints/vars.rs

@@ -191,6 +191,7 @@ define_string_enum! {
         (InitialGas),
         (InnerRemainingGas),
         (InitialRoot),
+        (IsBlockNumberInBlockHashBuffer),
         (IsLeaf),
         (IsNUpdatesSmall),
         (IsOnCurve),