blockifier: add validation for contract class manager config

Author: ArniStarkware

crates/blockifier/src/blockifier/config.rs

@@ -139,6 +139,7 @@ impl SerializeConfig for WorkerPoolConfig {
 
 #[derive(Clone, Debug, Deserialize, PartialEq, Serialize, Validate)]
 pub struct ContractClassManagerConfig {
+    #[validate(nested)]
     pub cairo_native_run_config: CairoNativeRunConfig,
     pub contract_cache_size: usize,
     #[validate(nested)]
@@ -241,7 +242,8 @@ impl NativeClassesWhitelist {
     }
 }
 
-#[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, PartialEq, Serialize, Validate)]
+#[validate(schema(function = "validate_run_cairo_native"))]
 pub struct CairoNativeRunConfig {
     pub run_cairo_native: bool,
     pub wait_on_native_compilation: bool,
@@ -302,3 +304,16 @@ impl SerializeConfig for CairoNativeRunConfig {
         ])
     }
 }
+
+fn validate_run_cairo_native(
+    cairo_native_run_config: &CairoNativeRunConfig,
+) -> Result<(), validator::ValidationError> {
+    if cairo_native_run_config.wait_on_native_compilation
+        && !cairo_native_run_config.run_cairo_native
+    {
+        return Err(validator::ValidationError::new(
+            "`wait_on_native_compilation` requires `run_cairo_native` to be enabled",
+        ));
+    }
+    Ok(())
+}

crates/blockifier/src/blockifier/config_test.rs

@@ -1,8 +1,9 @@
 use rstest::rstest;
 use serde_json;
 use starknet_api::class_hash;
+use validator::Validate;
 
-use crate::blockifier::config::NativeClassesWhitelist;
+use crate::blockifier::config::{CairoNativeRunConfig, NativeClassesWhitelist};
 
 #[rstest]
 #[case::all(NativeClassesWhitelist::All)]
@@ -14,3 +15,19 @@ fn test_native_classes_whitelist_serializes_and_back(#[case] value: NativeClasse
     let deserialized: NativeClassesWhitelist = serde_json::from_str(&serialized).unwrap();
     assert_eq!(deserialized, value);
 }
+
+#[rstest]
+#[case(true, true, true)]
+#[case(true, false, true)]
+#[case(false, true, false)]
+#[case(false, false, true)]
+fn test_validate_run_cairo_native(
+    #[case] run_cairo_native: bool,
+    #[case] wait_on_native_compilation: bool,
+    #[case] should_be_valid: bool,
+) {
+    let config =
+        CairoNativeRunConfig { run_cairo_native, wait_on_native_compilation, ..Default::default() };
+    let result = config.validate();
+    assert_eq!(result.is_ok(), should_be_valid, "unexpected validation result {result:?}");
+}

crates/blockifier/src/state/native_class_manager.rs

@@ -12,6 +12,7 @@ use starknet_api::class_cache::GlobalContractCache;
 use starknet_api::core::{ClassHash, CompiledClassHash};
 use starknet_api::state::SierraContractClass;
 use thiserror::Error;
+use validator::Validate;
 
 use crate::blockifier::config::{CairoNativeRunConfig, ContractClassManagerConfig};
 use crate::execution::contract_class::{CompiledClassV1, RunnableCompiledClass};
@@ -64,6 +65,7 @@ impl NativeClassManager {
     /// 2. `config.run_cairo_native` is `false`.
     /// 3. `config.wait_on_native_compilation` is `true`.
     pub fn start(config: ContractClassManagerConfig) -> NativeClassManager {
+        config.validate().expect("Invalid contract class manager config");
         // TODO(Avi, 15/12/2024): Add the size of the channel to the config.
         let class_cache = RawClassCache::new(config.contract_cache_size);
         let compiled_class_hash_v2_cache = GlobalContractCache::new(config.contract_cache_size);
@@ -122,8 +124,6 @@ impl NativeClassManager {
         if let CompiledClasses::V1(..) = cached_class {
             // When `wait_on_native_compilation` is active, all V1 classes should have been compiled
             // to native synchronously. A V1 cache entry indicates a pipeline bug.
-            // TODO(Yoni): make sure `wait_on_native_compilation` cannot be set to true while
-            // `run_cairo_native` is false.
             assert!(
                 !self.wait_on_native_compilation(),
                 "Manager did not wait on native compilation."
@@ -154,7 +154,6 @@ impl NativeClassManager {
             CompiledClasses::V1(compiled_class_v1, sierra_contract_class) => {
                 // TODO(Yoni): instead of these two flag, use an enum.
                 if self.wait_on_native_compilation() {
-                    assert!(self.run_cairo_native(), "Native compilation is disabled.");
                     let compiler = self.compiler.as_ref().expect("Compiler not available.");
                     // After this point, the Native class should be cached and available through
                     // `get_runnable` access.

crates/blockifier/src/state/native_class_manager_test.rs

@@ -11,7 +11,11 @@ use rstest::rstest;
 use starknet_api::class_cache::GlobalContractCache;
 use starknet_api::core::ClassHash;
 
-use crate::blockifier::config::{CairoNativeRunConfig, NativeClassesWhitelist};
+use crate::blockifier::config::{
+    CairoNativeRunConfig,
+    ContractClassManagerConfig,
+    NativeClassesWhitelist,
+};
 use crate::execution::contract_class::{CompiledClassV1, RunnableCompiledClass};
 use crate::state::global_cache::{
     CachedCairoNative,
@@ -29,6 +33,25 @@ use crate::test_utils::contracts::FeatureContractTrait;
 
 const TEST_CHANNEL_SIZE: usize = 10;
 
+#[rstest]
+#[should_panic(expected = "Invalid contract class manager config:")]
+#[case::invalid_contract_cache_size(ContractClassManagerConfig { contract_cache_size: 0, ..Default::default() })]
+#[should_panic(expected = "Invalid contract class manager config:")]
+#[case::invalid_cairo_native_run_config(ContractClassManagerConfig {
+    cairo_native_run_config: CairoNativeRunConfig {
+        run_cairo_native: false,
+        wait_on_native_compilation: true,
+        ..Default::default()
+    },
+    ..Default::default()
+})]
+fn test_start_invalid_contract_class_manager_config_panics(
+    #[case] config: ContractClassManagerConfig,
+) {
+    // This should panic after failing validation.
+    let _manager = NativeClassManager::start(config.clone());
+}
+
 fn get_casm(test_contract: FeatureContract) -> CompiledClassV1 {
     match test_contract.get_runnable_class() {
         RunnableCompiledClass::V1(casm) => casm,