apollo_integration_tests: add proposal margins to end to end flow args

Author: ArniStarkware

crates/apollo_integration_tests/src/flow_test_setup.rs

@@ -65,6 +65,7 @@ use crate::utils::{
     spawn_local_eth_to_strk_oracle,
     spawn_local_success_recorder,
     AccumulatedTransactions,
+    ProposalMarginMillis,
 };
 
 pub const NUM_OF_SEQUENCERS: usize = 2;
@@ -95,6 +96,7 @@ impl FlowTestSetup {
         test_unique_index: u16,
         block_max_capacity_gas: GasAmount,
         allow_bootstrap_txs: bool,
+        proposal_margin_millis: Option<ProposalMarginMillis>,
     ) -> Self {
         let chain_info = ChainInfo::create_for_testing();
         let mut available_ports = AvailablePorts::new(test_unique_index, 0);
@@ -104,6 +106,7 @@ impl FlowTestSetup {
             create_consensus_manager_configs_and_channels(
                 available_ports.get_next_ports(NUM_OF_SEQUENCERS + 1),
                 &chain_info.chain_id,
+                proposal_margin_millis,
             );
         let [sequencer_0_consensus_manager_config, sequencer_1_consensus_manager_config] =
             consensus_manager_configs.try_into().unwrap();
@@ -322,6 +325,7 @@ impl FlowSequencerSetup {
 pub fn create_consensus_manager_configs_and_channels(
     ports: Vec<u16>,
     chain_id: &ChainId,
+    proposal_margin_millis: Option<ProposalMarginMillis>,
 ) -> (
     Vec<ConsensusManagerConfig>,
     BroadcastTopicChannels<StreamMessage<ProposalPart, HeightAndRound>>,
@@ -335,6 +339,7 @@ pub fn create_consensus_manager_configs_and_channels(
         network_configs,
         n_network_configs,
         chain_id,
+        proposal_margin_millis,
     );
 
     for (i, config) in consensus_manager_configs.iter_mut().enumerate() {

crates/apollo_integration_tests/src/integration_test_manager.rs

@@ -1111,6 +1111,7 @@ async fn get_sequencer_setup_configs(
         ),
         component_configs_len,
         &chain_info.chain_id,
+        None,
     );
 
     let node_indices: HashSet<usize> = (0..component_configs_len).collect();

crates/apollo_integration_tests/src/utils.rs

@@ -101,6 +101,21 @@ pub type CreateL1ToL2MessagesArgsFn =
     fn(&mut MultiAccountTransactionGenerator) -> Vec<L1HandlerTransaction>;
 pub type TestTxHashesFn = fn(&[TransactionHash]) -> Vec<TransactionHash>;
 
+#[derive(Clone, Copy, Debug)]
+pub struct ProposalMarginMillis {
+    pub build_proposal_margin_millis: Duration,
+    pub validate_proposal_margin_millis: Duration,
+}
+
+impl ProposalMarginMillis {
+    pub fn new(build_proposal_margin_millis: u64, validate_proposal_margin_millis: u64) -> Self {
+        Self {
+            build_proposal_margin_millis: Duration::from_millis(build_proposal_margin_millis),
+            validate_proposal_margin_millis: Duration::from_millis(validate_proposal_margin_millis),
+        }
+    }
+}
+
 pub trait TestScenario {
     fn create_txs(
         &self,
@@ -339,6 +354,7 @@ pub(crate) fn create_consensus_manager_configs_from_network_configs(
     network_configs: Vec<NetworkConfig>,
     n_composed_nodes: usize,
     chain_id: &ChainId,
+    proposal_margin_millis: Option<ProposalMarginMillis>,
 ) -> Vec<ConsensusManagerConfig> {
     let num_validators = u64::try_from(n_composed_nodes).unwrap();
     let mut timeouts = TimeoutsConfig::default();
@@ -347,7 +363,21 @@ pub(crate) fn create_consensus_manager_configs_from_network_configs(
     network_configs
         .into_iter()
         // TODO(Matan): Get config from default config file.
-        .map(|network_config| ConsensusManagerConfig {
+        .map(|network_config| {
+            let mut context_config = ContextConfig {
+                static_config: ContextStaticConfig {
+                    num_validators,
+                    chain_id: chain_id.clone(),
+                    builder_address: ContractAddress::from(4_u128),
+                    ..Default::default()
+                },
+                ..Default::default()
+            };
+            if let Some(build_margin_millis) = proposal_margin_millis {
+                context_config.static_config.build_proposal_margin_millis = build_margin_millis.build_proposal_margin_millis;
+                context_config.static_config.validate_proposal_margin_millis = build_margin_millis.validate_proposal_margin_millis;
+            }
+            ConsensusManagerConfig {
             network_config,
             consensus_manager_config: ConsensusConfig {
                 dynamic_config: ConsensusDynamicConfig {
@@ -365,21 +395,13 @@ pub(crate) fn create_consensus_manager_configs_from_network_configs(
                     startup_delay: Duration::from_secs(15),
                 },
             },
-            context_config: ContextConfig {
-                static_config: ContextStaticConfig {
-                    num_validators,
-                    chain_id: chain_id.clone(),
-                    builder_address: ContractAddress::from(4_u128),
-                    ..Default::default()
-                },
-                ..Default::default()
-            },
+            context_config,
             cende_config: CendeConfig {
                 ..Default::default()
             },
             assume_no_malicious_validators: true,
             ..Default::default()
-        })
+        }})
         .collect()
 }
 

crates/apollo_integration_tests/tests/common/mod.rs

@@ -19,6 +19,7 @@ use apollo_integration_tests::utils::{
     run_test_scenario,
     CreateL1ToL2MessagesArgsFn,
     CreateRpcTxsFn,
+    ProposalMarginMillis,
     TestTxHashesFn,
 };
 use metrics_exporter_prometheus::{PrometheusBuilder, PrometheusHandle};
@@ -34,6 +35,7 @@ pub struct EndToEndFlowArgs {
     pub expecting_full_blocks: bool,
     pub expecting_reverted_transactions: bool,
     pub allow_bootstrap_txs: bool,
+    pub proposal_margin_millis: Option<ProposalMarginMillis>,
 }
 
 impl EndToEndFlowArgs {
@@ -49,6 +51,7 @@ impl EndToEndFlowArgs {
             expecting_full_blocks: false,
             expecting_reverted_transactions: false,
             allow_bootstrap_txs: false,
+            proposal_margin_millis: None,
         }
     }
 
@@ -63,6 +66,20 @@ impl EndToEndFlowArgs {
     pub fn allow_bootstrap_txs(self) -> Self {
         Self { allow_bootstrap_txs: true, ..self }
     }
+
+    pub fn proposal_margin_millis(
+        self,
+        build_proposal_margin_millis: u64,
+        validate_proposal_margin_millis: u64,
+    ) -> Self {
+        Self {
+            proposal_margin_millis: Some(ProposalMarginMillis::new(
+                build_proposal_margin_millis,
+                validate_proposal_margin_millis,
+            )),
+            ..self
+        }
+    }
 }
 
 // Note: run integration/flow tests from separate files in `tests/`, which helps cargo ensure
@@ -76,6 +93,7 @@ pub async fn end_to_end_flow(args: EndToEndFlowArgs) {
         expecting_full_blocks,
         expecting_reverted_transactions,
         allow_bootstrap_txs,
+        proposal_margin_millis,
     } = args;
     configure_tracing().await;
 
@@ -91,6 +109,7 @@ pub async fn end_to_end_flow(args: EndToEndFlowArgs) {
         test_identifier.into(),
         block_max_capacity_gas,
         allow_bootstrap_txs,
+        proposal_margin_millis,
     )
     .await;
 

crates/apollo_integration_tests/tests/end_to_end_flow_test.rs

@@ -25,11 +25,14 @@ mod common;
 /// Number of threads is 3 = Num of sequencer + 1 for the test thread.
 #[tokio::test(flavor = "multi_thread", worker_threads = 3)]
 async fn test_end_to_end_flow() {
-    end_to_end_flow(EndToEndFlowArgs::new(
-        TestIdentifier::EndToEndFlowTest,
-        create_test_scenarios(),
-        BouncerWeights::default().proving_gas,
-    ))
+    end_to_end_flow(
+        EndToEndFlowArgs::new(
+            TestIdentifier::EndToEndFlowTest,
+            create_test_scenarios(),
+            BouncerWeights::default().proving_gas,
+        )
+        .proposal_margin_millis(100, 1000),
+    )
     .await
 }