starknet_os_flow_tests: remove unnecessary impl of FlowTestState (#11429)

Author: Yoni-Starkware

crates/starknet_os_flow_tests/src/initial_state.rs

@@ -1,6 +1,7 @@
 use std::collections::{BTreeMap, HashMap, HashSet};
 
 use blockifier::context::BlockContext;
+use blockifier::state::state_api::UpdatableState;
 use blockifier::transaction::transaction_execution::Transaction;
 use blockifier_test_utils::cairo_versions::{CairoVersion, RunnableCairo1};
 use blockifier_test_utils::calldata::create_calldata;
@@ -35,7 +36,6 @@ use starknet_committer::db::facts_db::db::FactsDb;
 use starknet_patricia_storage::map_storage::MapStorage;
 use starknet_types_core::felt::Felt;
 
-use crate::state_trait::FlowTestState;
 use crate::test_manager::{
     block_context_for_flow_tests,
     EXPECTED_STRK_FEE_TOKEN_ADDRESS,
@@ -58,6 +58,10 @@ const STRK_TOKEN_NAME: &[u8] = b"StarkNet Token";
 const STRK_SYMBOL: &[u8] = b"STRK";
 const STRK_DECIMALS: u8 = 18;
 
+/// Trait alias for state readers used in flow tests.
+pub(crate) trait FlowTestState: Default + UpdatableState + Send {}
+impl<S: Default + UpdatableState + Send> FlowTestState for S {}
+
 /// Gathers the information needed to execute a flow test.
 pub(crate) struct InitialStateData<S: FlowTestState> {
     pub(crate) initial_state: InitialState<S>,
@@ -140,7 +144,7 @@ pub(crate) async fn create_default_initial_state_data<S: FlowTestState, const N:
         extra_contracts_addresses,
     ) = create_default_initial_state_txs_and_contracts(extra_contracts);
     // Execute these 4 txs.
-    let initial_state_reader = S::create_empty_state();
+    let initial_state_reader = S::default();
     let initial_block_number = BlockNumber(CURRENT_BLOCK_NUMBER);
     let use_kzg_da = false;
     let block_context = block_context_for_flow_tests(initial_block_number, use_kzg_da);

crates/starknet_os_flow_tests/src/lib.rs

@@ -2,7 +2,6 @@
 
 pub(crate) mod initial_state;
 pub(crate) mod special_contracts;
-pub(crate) mod state_trait;
 pub(crate) mod test_manager;
 pub(crate) mod tests;
 pub(crate) mod utils;

crates/starknet_os_flow_tests/src/state_trait.rs

@@ -79,11 +79,11 @@ use starknet_types_core::felt::Felt;
 use crate::initial_state::{
     create_default_initial_state_data,
     get_initial_deploy_account_tx,
+    FlowTestState,
     InitialState,
     InitialStateData,
     OsExecutionContracts,
 };
-use crate::state_trait::FlowTestState;
 use crate::tests::NON_TRIVIAL_RESOURCE_BOUNDS;
 use crate::utils::{
     commit_state_diff,