apollo_starknet_os_program: prune deprecated syscalls code from the virtual OS (#11509)

Author: Yoni-Starkware

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/os.cairo

@@ -30,9 +30,6 @@ from starkware.starknet.core.os.contract_class.compiled_class import (
 from starkware.starknet.core.os.contract_class.deprecated_compiled_class import (
     deprecated_load_compiled_class_facts,
 )
-from starkware.starknet.core.os.execution.deprecated_execute_syscalls import (
-    execute_deprecated_syscalls,
-)
 from starkware.starknet.core.os.execution.execute_syscalls import execute_syscalls
 from starkware.starknet.core.os.execution.execute_transactions import execute_transactions
 from starkware.starknet.core.os.os_config.os_config import (
@@ -42,6 +39,7 @@ from starkware.starknet.core.os.os_config.os_config import (
 )
 from starkware.starknet.core.os.os_utils import (
     get_block_os_output_header,
+    get_execute_deprecated_syscalls_ptr,
     get_virtual_os_config,
     pre_process_block,
     process_os_output,
@@ -310,9 +308,7 @@ func get_os_global_context{
 
     // Function pointers.
     let (execute_syscalls_ptr) = get_label_location(label_value=execute_syscalls);
-    let (execute_deprecated_syscalls_ptr) = get_label_location(
-        label_value=execute_deprecated_syscalls
-    );
+    let (execute_deprecated_syscalls_ptr) = get_execute_deprecated_syscalls_ptr();
 
     let virtual_os_config = get_virtual_os_config();
     tempvar os_global_context: OsGlobalContext* = new OsGlobalContext(

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/os_utils.cairo

@@ -3,6 +3,7 @@ from starkware.cairo.common.cairo_builtins import EcOpBuiltin, PoseidonBuiltin
 from starkware.cairo.common.dict import dict_update
 from starkware.cairo.common.dict_access import DictAccess
 from starkware.cairo.common.math_cmp import is_nn
+from starkware.cairo.common.registers import get_label_location
 from starkware.starknet.core.aggregator.combine_blocks import combine_blocks
 from starkware.starknet.core.os.block_context import BlockContext, OsGlobalContext, VirtualOsConfig
 from starkware.starknet.core.os.block_hash import get_block_hashes
@@ -17,6 +18,9 @@ from starkware.starknet.core.os.contract_class.compiled_class import CompiledCla
 from starkware.starknet.core.os.contract_class.poseidon_compiled_class_hash import (
     compiled_class_hash as poseidon_compiled_class_hash,
 )
+from starkware.starknet.core.os.execution.deprecated_execute_syscalls import (
+    execute_deprecated_syscalls,
+)
 from starkware.starknet.core.os.output import OsOutput, OsOutputHeader, serialize_os_output
 from starkware.starknet.core.os.state.commitment import CommitmentUpdate, StateEntry
 
@@ -193,3 +197,8 @@ func get_virtual_os_config() -> VirtualOsConfig* {
     );
     return virtual_os_config;
 }
+
+// Returns a function pointer to execute_deprecated_syscalls.
+func get_execute_deprecated_syscalls_ptr() -> (res: felt*) {
+    return get_label_location(label_value=execute_deprecated_syscalls);
+}

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/os_utils__virtual.cairo

@@ -99,3 +99,9 @@ func get_virtual_os_config() -> VirtualOsConfig* {
     // The authorized account address will be set during transaction execution.
     return virtual_os_config;
 }
+
+// Returns a function pointer to execute_deprecated_syscalls.
+// In virtual OS mode, deprecated syscalls are not supported, so we return 0.
+func get_execute_deprecated_syscalls_ptr() -> (res: felt*) {
+    return (res=cast(0, felt*));
+}

crates/apollo_starknet_os_program/src/program_hash.json

@@ -1,6 +1,6 @@
 {
-  "os": "0x7edaf9251ec7a175fe40f6831b301938db479ff67a3c817dc44ad1443188d52",
-  "virtual_os": "0x3f526c2c3d0b4c2cd32817a976604f5ea84db5e1f947d8b61f5e666b9bc2d4c",
+  "os": "0x61c7948fcef576eb2ebc29e32935936fce23a096df5f082a789d5088ca84a7b",
+  "virtual_os": "0x49068c40ae9cc36fa84cd89ea7a2e6b66c4b257e9449235d6a68360e910716e",
   "aggregator": "0x63868c8dbf389119d95bae88b80043f5d237d3ddec072fb8f2095fcfacb9b1c",
   "aggregator_with_prefix": "0xd892fd2fd978d8c2749a6678457ca99161f3d1822e4c3b8c03914817c6de1a"
 }

crates/apollo_starknet_os_program/src/virtual_os_test.rs

@@ -17,11 +17,11 @@ fn test_virtual_os_swapped_files() {
 #[test]
 fn test_program_bytecode_lengths() {
     expect![[r#"
-        15555
+        15558
     "#]]
     .assert_debug_eq(&OS_PROGRAM.data_len());
     expect![[r#"
-        12971
+        12133
     "#]]
     .assert_debug_eq(&VIRTUAL_OS_PROGRAM.data_len());
 }