apollo_network: struct that holds the reason the peer is considered bad

Author: guy-starkware

crates/apollo_consensus/src/manager.rs

@@ -188,7 +188,7 @@ pub enum RunHeightRes {
 
 type ProposalReceiverTuple<T> = (ProposalInit, mpsc::Receiver<T>);
 
-// TODO(guyn): remove allow dead code once we use the duplicate vote report.
+// TODO(guyn): remove allow(dead_code) once we use this struct.
 #[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct EquivocationVoteReport {

crates/apollo_network_types/src/network_types.rs

@@ -24,12 +24,12 @@ impl OpaquePeerId {
     }
 }
 
-// TODO(guyn): remove allow dead code once we use the duplicate vote report.
+// TODO(guyn): remove allow dead code once we use this struct.
 #[allow(dead_code)]
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
 pub struct BadPeerReport {
     pub peer_id: OpaquePeerId,
-    pub reason: String,
+    pub reason: BadPeerReason,
     pub penalty_card: PenaltyCard,
 }
 
@@ -42,3 +42,12 @@ pub enum PenaltyCard {
     /// Possibly sent malicious data on accident, will be considered malicious on repeat offenses.
     Yellow,
 }
+
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
+pub enum BadPeerReason {
+    /// Protobuf conversion has failed.
+    ConversionError(String),
+    /// Duplicate and conflicting vote was received from the same peer for the same height, round,
+    /// and phase.
+    EquivocationVote(String),
+}