workspace: add Copy derive to fieldless enums and all-Copy structs

Author: dan-starkware

crates/apollo_consensus_orchestrator_config/src/config.rs

@@ -20,7 +20,7 @@ use starknet_api::core::{ChainId, ContractAddress};
 use url::Url;
 use validator::Validate;
 
-#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "lowercase")]
 pub enum DeploymentMode {
     // Production mode.

crates/apollo_gateway/src/test_utils.rs

@@ -55,7 +55,7 @@ pub fn create_sierra_program(version_id: &VersionId) -> Vec<Felt> {
     ]
 }
 
-#[derive(Clone)]
+#[derive(Clone, Copy)]
 pub enum TransactionType {
     Declare,
     DeployAccount,

crates/apollo_l1_provider_types/src/lib.rs

@@ -451,7 +451,7 @@ impl std::fmt::Display for ProviderState {
     }
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)]
 pub enum SessionState {
     Propose,
     Validate,

crates/apollo_node/src/servers.rs

@@ -685,7 +685,7 @@ fn create_wrapper_servers(
     components: &mut SequencerNodeComponents,
 ) -> WrapperServers {
     let config_manager_runner_server = create_wrapper_server!(
-        &config.components.config_manager.execution_mode.clone().into(),
+        &config.components.config_manager.execution_mode.into(),
         components.config_manager_runner
     );
 
@@ -713,12 +713,12 @@ fn create_wrapper_servers(
     );
 
     let mempool_p2p_runner_server = create_wrapper_server!(
-        &config.components.mempool_p2p.execution_mode.clone().into(),
+        &config.components.mempool_p2p.execution_mode.into(),
         components.mempool_p2p_runner
     );
 
     let state_sync_runner_server = create_wrapper_server!(
-        &config.components.state_sync.execution_mode.clone().into(),
+        &config.components.state_sync.execution_mode.into(),
         components.state_sync_runner
     );
 

crates/apollo_node_config/src/component_execution_config.rs

@@ -27,7 +27,7 @@ pub trait ExpectedComponentConfig {
     fn is_running_locally(&self) -> bool;
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]
 pub enum ReactiveComponentExecutionMode {
     Disabled,
     Remote,
@@ -47,7 +47,7 @@ impl ExpectedComponentConfig for ReactiveComponentExecutionMode {
     }
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]
 pub enum ActiveComponentExecutionMode {
     Disabled,
     Enabled,

crates/apollo_rpc/src/v0_8/transaction.rs

@@ -868,7 +868,7 @@ pub struct L1HandlerTransactionOutput {
 // Note: This is not the same as the Builtins in starknet_api, the serialization of SegmentArena is
 // different.
 // TODO(yair): remove this once a newer version of the API is published.
-#[derive(Debug, Clone, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]
+#[derive(Debug, Clone, Copy, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]
 pub enum Builtin {
     #[serde(rename = "range_check_builtin_applications")]
     RangeCheck,
@@ -954,7 +954,7 @@ impl Add for ExecutionResources {
                 // and not as the trait Add.
                 Some(v_ref) => *v_ref = (*v_ref).saturating_add((*v).into()),
                 None => {
-                    self.computation_resources.builtin_instance_counter.insert(k.clone(), *v);
+                    self.computation_resources.builtin_instance_counter.insert(*k, *v);
                 }
             }
         }

crates/blockifier/src/blockifier/concurrent_transaction_executor.rs

@@ -48,7 +48,7 @@ impl<S: StateReader + Send + 'static> ConcurrentTransactionExecutor<S> {
             &block_context.versioned_constants.os_constants,
         )?;
 
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         let worker_executor = Arc::new(WorkerExecutor::initialize(
             block_state,
             vec![],
@@ -70,7 +70,7 @@ impl<S: StateReader + Send + 'static> ConcurrentTransactionExecutor<S> {
         worker_pool: Arc<WorkerPool<CachedState<S>>>,
         block_deadline: Option<Instant>,
     ) -> Self {
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         let worker_executor = Arc::new(WorkerExecutor::initialize(
             block_state,
             vec![],

crates/blockifier/src/blockifier/transaction_executor.rs

@@ -130,7 +130,7 @@ impl<S: StateReader> TransactionExecutor<S> {
         config: TransactionExecutorConfig,
         worker_pool: Option<Arc<WorkerPool<CachedState<S>>>>,
     ) -> Self {
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         // Note: the state might not be empty even at this point; it is the creator's
         // responsibility to tune the bouncer according to pre and post block process.
         Self {

crates/blockifier/src/blockifier/transaction_executor_test.rs

@@ -378,8 +378,7 @@ fn test_execute_txs_bouncing(#[case] concurrency_enabled: bool, #[case] external
     assert_eq!(remaining_tx_results.len(), 0);
 
     // Reset the bouncer and add the remaining transactions.
-    tx_executor.bouncer =
-        Mutex::new(Bouncer::new(tx_executor.block_context.bouncer_config.clone())).into();
+    tx_executor.bouncer = Mutex::new(Bouncer::new(tx_executor.block_context.bouncer_config)).into();
     let remaining_tx_results = tx_executor.execute_txs(remaining_txs, None);
 
     assert_eq!(remaining_tx_results.len(), 2);

crates/blockifier/src/bouncer.rs

@@ -70,7 +70,7 @@ macro_rules! impl_field_wise_ops {
     };
 }
 
-#[derive(Clone, Debug, Default, Deserialize, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, Default, Deserialize, PartialEq, Serialize)]
 pub struct BouncerConfig {
     pub block_max_capacity: BouncerWeights,
     pub builtin_weights: BuiltinWeights,