workspace: add Copy derive to fieldless enums and all-Copy structs

dan-starkware · dan-starkware · commit 68faeea63127 · 2026-02-14T21:28:12.000+02:00
diff --git a/crates/apollo_consensus_orchestrator_config/src/config.rs b/crates/apollo_consensus_orchestrator_config/src/config.rs
@@ -18,7 +18,7 @@ use starknet_api::core::{ChainId, ContractAddress};
 use url::Url;
 use validator::Validate;
 
-#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "lowercase")]
 pub enum DeploymentMode {
     // Production mode.
diff --git a/crates/apollo_dashboard/src/panel.rs b/crates/apollo_dashboard/src/panel.rs
@@ -24,7 +24,7 @@ pub(crate) enum PanelType {
     BarGauge,
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq)]
 pub enum Unit {
     Bytes,
     Seconds,
@@ -53,7 +53,7 @@ impl Serialize for Unit {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, PartialEq, Serialize)]
 #[serde(rename_all = "lowercase")]
 pub enum ThresholdMode {
     #[allow(dead_code)] // TODO(Ron): use in panels
diff --git a/crates/apollo_gateway/src/test_utils.rs b/crates/apollo_gateway/src/test_utils.rs
@@ -48,7 +48,7 @@ pub fn create_sierra_program(version_id: &VersionId) -> Vec<Felt> {
     ]
 }
 
-#[derive(Clone)]
+#[derive(Clone, Copy)]
 pub enum TransactionType {
     Declare,
     DeployAccount,
diff --git a/crates/apollo_l1_provider_types/src/lib.rs b/crates/apollo_l1_provider_types/src/lib.rs
@@ -451,7 +451,7 @@ impl std::fmt::Display for ProviderState {
     }
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)]
 pub enum SessionState {
     Propose,
     Validate,
diff --git a/crates/apollo_node/src/servers.rs b/crates/apollo_node/src/servers.rs
@@ -653,7 +653,7 @@ fn create_wrapper_servers(
     components: &mut SequencerNodeComponents,
 ) -> WrapperServers {
     let config_manager_runner_server = create_wrapper_server!(
-        &config.components.config_manager.execution_mode.clone().into(),
+        &config.components.config_manager.execution_mode.into(),
         components.config_manager_runner
     );
 
@@ -681,12 +681,12 @@ fn create_wrapper_servers(
     );
 
     let mempool_p2p_runner_server = create_wrapper_server!(
-        &config.components.mempool_p2p.execution_mode.clone().into(),
+        &config.components.mempool_p2p.execution_mode.into(),
         components.mempool_p2p_runner
     );
 
     let state_sync_runner_server = create_wrapper_server!(
-        &config.components.state_sync.execution_mode.clone().into(),
+        &config.components.state_sync.execution_mode.into(),
         components.state_sync_runner
     );
 
diff --git a/crates/apollo_node_config/src/component_execution_config.rs b/crates/apollo_node_config/src/component_execution_config.rs
@@ -27,7 +27,7 @@ pub trait ExpectedComponentConfig {
     fn is_running_locally(&self) -> bool;
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]
 pub enum ReactiveComponentExecutionMode {
     Disabled,
     Remote,
@@ -47,7 +47,7 @@ impl ExpectedComponentConfig for ReactiveComponentExecutionMode {
     }
 }
 
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]
 pub enum ActiveComponentExecutionMode {
     Disabled,
     Enabled,
diff --git a/crates/apollo_rpc/src/v0_8/transaction.rs b/crates/apollo_rpc/src/v0_8/transaction.rs
@@ -863,7 +863,7 @@ pub struct L1HandlerTransactionOutput {
 // Note: This is not the same as the Builtins in starknet_api, the serialization of SegmentArena is
 // different.
 // TODO(yair): remove this once a newer version of the API is published.
-#[derive(Debug, Clone, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]
+#[derive(Debug, Clone, Copy, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]
 pub enum Builtin {
     #[serde(rename = "range_check_builtin_applications")]
     RangeCheck,
@@ -949,7 +949,7 @@ impl Add for ExecutionResources {
                 // and not as the trait Add.
                 Some(v_ref) => *v_ref = (*v_ref).saturating_add((*v).into()),
                 None => {
-                    self.computation_resources.builtin_instance_counter.insert(k.clone(), *v);
+                    self.computation_resources.builtin_instance_counter.insert(*k, *v);
                 }
             }
         }
diff --git a/crates/blockifier/src/blockifier/concurrent_transaction_executor.rs b/crates/blockifier/src/blockifier/concurrent_transaction_executor.rs
@@ -48,7 +48,7 @@ impl<S: StateReader + Send + 'static> ConcurrentTransactionExecutor<S> {
             &block_context.versioned_constants.os_constants,
         )?;
 
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         let worker_executor = Arc::new(WorkerExecutor::initialize(
             block_state,
             vec![],
@@ -70,7 +70,7 @@ impl<S: StateReader + Send + 'static> ConcurrentTransactionExecutor<S> {
         worker_pool: Arc<WorkerPool<CachedState<S>>>,
         block_deadline: Option<Instant>,
     ) -> Self {
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         let worker_executor = Arc::new(WorkerExecutor::initialize(
             block_state,
             vec![],
diff --git a/crates/blockifier/src/blockifier/transaction_executor.rs b/crates/blockifier/src/blockifier/transaction_executor.rs
@@ -130,7 +130,7 @@ impl<S: StateReader> TransactionExecutor<S> {
         config: TransactionExecutorConfig,
         worker_pool: Option<Arc<WorkerPool<CachedState<S>>>>,
     ) -> Self {
-        let bouncer_config = block_context.bouncer_config.clone();
+        let bouncer_config = block_context.bouncer_config;
         // Note: the state might not be empty even at this point; it is the creator's
         // responsibility to tune the bouncer according to pre and post block process.
         Self {
diff --git a/crates/blockifier/src/blockifier/transaction_executor_test.rs b/crates/blockifier/src/blockifier/transaction_executor_test.rs
@@ -378,8 +378,7 @@ fn test_execute_txs_bouncing(#[case] concurrency_enabled: bool, #[case] external
     assert_eq!(remaining_tx_results.len(), 0);
 
     // Reset the bouncer and add the remaining transactions.
-    tx_executor.bouncer =
-        Mutex::new(Bouncer::new(tx_executor.block_context.bouncer_config.clone())).into();
+    tx_executor.bouncer = Mutex::new(Bouncer::new(tx_executor.block_context.bouncer_config)).into();
     let remaining_tx_results = tx_executor.execute_txs(remaining_txs, None);
 
     assert_eq!(remaining_tx_results.len(), 2);
diff --git a/crates/blockifier/src/bouncer.rs b/crates/blockifier/src/bouncer.rs
@@ -64,7 +64,7 @@ macro_rules! impl_field_wise_ops {
     };
 }
 
-#[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, Deserialize, PartialEq, Serialize)]
 pub struct BouncerConfig {
     pub block_max_capacity: BouncerWeights,
     pub builtin_weights: BuiltinWeights,
diff --git a/crates/blockifier/src/concurrency/worker_logic_test.rs b/crates/blockifier/src/concurrency/worker_logic_test.rs
@@ -99,7 +99,7 @@ pub fn test_commit_tx() {
     .into_iter()
     .map(Transaction::Account)
     .collect::<Vec<Transaction>>();
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let cached_state =
         test_state(&block_context.chain_info, BALANCE, &[(account, 1), (test_contract, 1)]);
     let versioned_state = safe_versioned_state_for_testing(cached_state);
@@ -219,7 +219,7 @@ fn test_commit_tx_when_sender_is_sequencer() {
         nonce!(0_u8),
     ))];
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
 
     let state = test_state(&block_context.chain_info, BALANCE, &[(account, 1), (test_contract, 1)]);
     let versioned_state = safe_versioned_state_for_testing(state);
@@ -289,7 +289,7 @@ pub fn test_validate_after_commit_tx() {
         nonce!(0_u8),
     ))];
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let cached_state =
         test_state(&block_context.chain_info, BALANCE, &[(account, 1), (test_contract, 1)]);
     let versioned_state = safe_versioned_state_for_testing(cached_state);
@@ -383,7 +383,7 @@ fn test_worker_execute(default_all_resource_bounds: ValidResourceBounds) {
         .map(Transaction::Account)
         .collect::<Vec<Transaction>>();
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let worker_executor = WorkerExecutor::new(
         safe_versioned_state.clone(),
         txs.to_vec(),
@@ -551,7 +551,7 @@ fn test_worker_validate(default_all_resource_bounds: ValidResourceBounds) {
         .map(Transaction::Account)
         .collect::<Vec<Transaction>>();
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let worker_executor = WorkerExecutor::new(
         safe_versioned_state.clone(),
         txs.to_vec(),
@@ -668,7 +668,7 @@ fn test_deploy_before_declare(
     let txs =
         [declare_tx, invoke_tx].into_iter().map(Transaction::Account).collect::<Vec<Transaction>>();
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let worker_executor = WorkerExecutor::new(
         safe_versioned_state,
         txs.to_vec(),
@@ -750,7 +750,7 @@ fn test_worker_commit_phase(default_all_resource_bounds: ValidResourceBounds) {
         })
         .collect::<Vec<Transaction>>();
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let worker_executor = WorkerExecutor::new(
         safe_versioned_state,
         txs.to_vec(),
@@ -852,7 +852,7 @@ fn test_worker_commit_phase_with_halt() {
         })
         .collect::<Vec<Transaction>>();
 
-    let bouncer = Bouncer::new(block_context.bouncer_config.clone());
+    let bouncer = Bouncer::new(block_context.bouncer_config);
     let worker_executor = WorkerExecutor::new(
         safe_versioned_state,
         txs.to_vec(),
diff --git a/crates/blockifier/src/context.rs b/crates/blockifier/src/context.rs
@@ -173,7 +173,7 @@ impl BlockContext {
             block_timestamp: BlockTimestamp(rounded_timestamp),
             sequencer_address: 0_u128.into(),
             // TODO(Yoni): consider setting here trivial prices if and when this field is exposed.
-            gas_prices: self.block_info.gas_prices.clone(),
+            gas_prices: self.block_info.gas_prices,
             use_kzg_da: self.block_info.use_kzg_da,
             starknet_version: self.block_info.starknet_version,
         }
diff --git a/crates/blockifier/src/execution/stack_trace.rs b/crates/blockifier/src/execution/stack_trace.rs
@@ -26,7 +26,7 @@ pub const TRACE_LENGTH_CAP: usize = 15000;
 pub const TRACE_EXTRA_CHARS_SLACK: usize = 100;
 
 #[cfg_attr(feature = "transaction_serde", derive(serde::Serialize, serde::Deserialize))]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq)]
 pub enum PreambleType {
     CallContract,
     LibraryCall,
@@ -126,7 +126,7 @@ impl From<&ErrorStackSegment> for String {
 }
 
 #[cfg_attr(feature = "transaction_serde", derive(serde::Serialize, serde::Deserialize))]
-#[derive(Clone, Debug, Default, PartialEq)]
+#[derive(Clone, Copy, Debug, Default, PartialEq)]
 pub enum ErrorStackHeader {
     Constructor,
     Execution,
diff --git a/crates/blockifier_reexecution/src/cli.rs b/crates/blockifier_reexecution/src/cli.rs
@@ -20,7 +20,7 @@ pub struct BlockifierReexecutionCliArgs {
     pub command: Command,
 }
 
-#[derive(clap::ValueEnum, Clone, Debug)]
+#[derive(clap::ValueEnum, Clone, Copy, Debug)]
 pub enum SupportedChainId {
     Mainnet,
     Testnet,
diff --git a/crates/native_blockifier/src/py_block_executor.rs b/crates/native_blockifier/src/py_block_executor.rs
@@ -138,7 +138,7 @@ impl PyBlockExecutor {
             next_block_info.try_into()?,
             self.chain_info.clone(),
             self.versioned_constants.clone(),
-            self.bouncer_config.clone(),
+            self.bouncer_config,
         );
         let next_block_number = block_context.block_info().block_number;
 
diff --git a/crates/starknet_api/src/block.rs b/crates/starknet_api/src/block.rs
@@ -575,7 +575,7 @@ macro_rules! impl_try_from_uint_for_nonzero_gas_price {
 impl_try_from_uint_for_nonzero_gas_price!(u8, u16, u32, u64, u128);
 
 // TODO(Arni): Remove derive of Default. Gas prices should always be set.
-#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
 pub struct GasPriceVector {
     pub l1_gas_price: NonzeroGasPrice,
     pub l1_data_gas_price: NonzeroGasPrice,
@@ -589,7 +589,7 @@ pub enum FeeType {
 }
 
 // TODO(Arni): Remove derive of Default. Gas prices should always be set.
-#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
 pub struct GasPrices {
     pub eth_gas_prices: GasPriceVector,  // In wei.
     pub strk_gas_prices: GasPriceVector, // In fri.
diff --git a/crates/starknet_api/src/block_hash/block_hash_calculator.rs b/crates/starknet_api/src/block_hash/block_hash_calculator.rs
@@ -50,7 +50,7 @@ static STARKNET_GAS_PRICES0: LazyLock<Felt> = LazyLock::new(|| {
 });
 
 #[allow(non_camel_case_types)]
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd)]
 pub enum BlockHashVersion {
     V0_13_2,
     V0_13_4,
@@ -209,7 +209,7 @@ pub fn calculate_block_hash(
     let block_commitments = &partial_block_hash_components.header_commitments;
     Ok(BlockHash(
         HashChain::new()
-            .chain(&block_hash_version.clone().into())
+            .chain(&block_hash_version.into())
             .chain(&partial_block_hash_components.block_number.0.into())
             .chain(&state_root.0)
             .chain(&partial_block_hash_components.sequencer.0)
diff --git a/crates/starknet_api/src/block_hash/block_hash_calculator_test.rs b/crates/starknet_api/src/block_hash/block_hash_calculator_test.rs
@@ -99,7 +99,7 @@ async fn test_block_hash_regression(
             price_in_wei: 9_u8.into(),
         },
         l2_gas_price: GasPricePerToken { price_in_fri: 11_u8.into(), price_in_wei: 12_u8.into() },
-        starknet_version: block_hash_version.clone().into(),
+        starknet_version: block_hash_version.into(),
         header_commitments: block_commitments,
     };
 
diff --git a/crates/starknet_api/src/deprecated_contract_class.rs b/crates/starknet_api/src/deprecated_contract_class.rs
@@ -96,7 +96,7 @@ pub enum L1HandlerType {
 }
 
 /// A function state mutability.
-#[derive(Debug, Clone, Default, Eq, PartialEq, Deserialize, Serialize)]
+#[derive(Debug, Clone, Copy, Default, Eq, PartialEq, Deserialize, Serialize)]
 pub enum FunctionStateMutability {
     #[serde(rename = "view")]
     #[default]
diff --git a/crates/starknet_api/src/execution_resources.rs b/crates/starknet_api/src/execution_resources.rs
@@ -236,7 +236,7 @@ pub struct ExecutionResources {
     pub gas_consumed: GasVector,
 }
 
-#[derive(Clone, Debug, Deserialize, EnumIter, Eq, Hash, PartialEq, Serialize)]
+#[derive(Clone, Copy, Debug, Deserialize, EnumIter, Eq, Hash, PartialEq, Serialize)]
 pub enum Builtin {
     #[serde(rename = "range_check_builtin_applications")]
     RangeCheck,
diff --git a/crates/starknet_committer/src/patricia_merkle_tree/leaf/leaf_serde.rs b/crates/starknet_committer/src/patricia_merkle_tree/leaf/leaf_serde.rs
@@ -15,7 +15,7 @@ use crate::db::serde_db_utils::{deserialize_felt_no_packing, serialize_felt_no_p
 use crate::patricia_merkle_tree::leaf::leaf_impl::ContractState;
 use crate::patricia_merkle_tree::types::{fixed_hex_string_no_prefix, CompiledClassHash};
 
-#[derive(Clone, Debug)]
+#[derive(Clone, Copy, Debug)]
 pub enum CommitterLeafPrefix {
     StorageLeaf,
     StateTreeLeaf,

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ pub(crate) enum PanelType {`
`24`	`24`	`BarGauge,`
`25`	`25`	`}`
`26`	`26`
`27`		`-#[derive(Debug, Clone, PartialEq)]`
	`27`	`+#[derive(Debug, Clone, Copy, PartialEq)]`
`28`	`28`	`pub enum Unit {`
`29`	`29`	`Bytes,`
`30`	`30`	`Seconds,`
`@@ -53,7 +53,7 @@ impl Serialize for Unit {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`-#[derive(Clone, Debug, PartialEq, Serialize)]`
	`56`	`+#[derive(Clone, Copy, Debug, PartialEq, Serialize)]`
`57`	`57`	`#[serde(rename_all = "lowercase")]`
`58`	`58`	`pub enum ThresholdMode {`
`59`	`59`	`#[allow(dead_code)] // TODO(Ron): use in panels`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ pub fn create_sierra_program(version_id: &VersionId) -> Vec<Felt> {`
`48`	`48`	`]`
`49`	`49`	`}`
`50`	`50`
`51`		`-#[derive(Clone)]`
	`51`	`+#[derive(Clone, Copy)]`
`52`	`52`	`pub enum TransactionType {`
`53`	`53`	`Declare,`
`54`	`54`	`DeployAccount,`
Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ impl std::fmt::Display for ProviderState {`
`451`	`451`	`}`
`452`	`452`	`}`
`453`	`453`
`454`		`-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]`
	`454`	`+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)]`
`455`	`455`	`pub enum SessionState {`
`456`	`456`	`Propose,`
`457`	`457`	`Validate,`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ pub trait ExpectedComponentConfig {`
`27`	`27`	`fn is_running_locally(&self) -> bool;`
`28`	`28`	`}`
`29`	`29`
`30`		`-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]`
	`30`	`+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]`
`31`	`31`	`pub enum ReactiveComponentExecutionMode {`
`32`	`32`	`Disabled,`
`33`	`33`	`Remote,`
`@@ -47,7 +47,7 @@ impl ExpectedComponentConfig for ReactiveComponentExecutionMode {`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`
`50`		`-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]`
	`50`	`+#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)]`
`51`	`51`	`pub enum ActiveComponentExecutionMode {`
`52`	`52`	`Disabled,`
`53`	`53`	`Enabled,`
Original file line number	Diff line number	Diff line change
`@@ -863,7 +863,7 @@ pub struct L1HandlerTransactionOutput {`
`863`	`863`	`// Note: This is not the same as the Builtins in starknet_api, the serialization of SegmentArena is`
`864`	`864`	`// different.`
`865`	`865`	`// TODO(yair): remove this once a newer version of the API is published.`
`866`		`-#[derive(Debug, Clone, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]`
	`866`	`+#[derive(Debug, Clone, Copy, Eq, Hash, PartialEq, Deserialize, Serialize, PartialOrd, Ord)]`
`867`	`867`	`pub enum Builtin {`
`868`	`868`	`#[serde(rename = "range_check_builtin_applications")]`
`869`	`869`	`RangeCheck,`
`@@ -949,7 +949,7 @@ impl Add for ExecutionResources {`
`949`	`949`	`// and not as the trait Add.`
`950`	`950`	`Some(v_ref) => v_ref = (v_ref).saturating_add((*v).into()),`
`951`	`951`	`None => {`
`952`		`- self.computation_resources.builtin_instance_counter.insert(k.clone(), *v);`
	`952`	`+ self.computation_resources.builtin_instance_counter.insert(k, v);`
`953`	`953`	`}`
`954`	`954`	`}`
`955`	`955`	`}`