Skip to content

Commit 7ab8c08

Browse files
chore: fix conflicts
Signed-off-by: Dori Medini <dori@starkware.co>
1 parent 59b132f commit 7ab8c08

File tree

25 files changed

+34
-403
lines changed

25 files changed

+34
-403
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ apollo_network.path = "crates/apollo_network"
128128
apollo_network_types.path = "crates/apollo_network_types"
129129
apollo_node.path = "crates/apollo_node"
130130
apollo_p2p_sync.path = "crates/apollo_p2p_sync"
131-
apollo_proc_macros = { path = "crates/apollo_proc_macros", version = "0.15.0-rc.2" }
131+
apollo_proc_macros = { path = "crates/apollo_proc_macros", version = "0.0.0" }
132132
apollo_proc_macros_tests.path = "crates/apollo_proc_macros_tests"
133133
apollo_protobuf.path = "crates/apollo_protobuf"
134134
apollo_reverts.path = "crates/apollo_reverts"

crates/apollo_config/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ license-file.workspace = true
77
description = "A library for handling node configuration."
88

99
[dependencies]
10-
apollo_infra_utils = { workspace = true, optional = true }
10+
apollo_infra_utils.workspace = true
1111
clap = { workspace = true, features = ["env", "string"] }
1212
colored = { workspace = true, optional = true }
1313
const_format.workspace = true

crates/apollo_config/src/converters.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ where
128128
let mut output = Vec::with_capacity(number_of_items);
129129
for item in raw.split_whitespace() {
130130
let value: UrlAndHeaders = serde_json::from_str(item)
131-
.map_err(|e| D::Error::custom(format!("Invalid JSON '{}': {}", item, e)))?;
131+
.map_err(|e| D::Error::custom(format!("Invalid JSON '{item}': {e}")))?;
132132
output.push(value);
133133
}
134134
Ok(Some(output))
@@ -199,6 +199,6 @@ where
199199
}
200200

201201
raw.split_whitespace()
202-
.map(|s| Url::parse(s).map_err(|e| D::Error::custom(format!("Invalid URL '{}': {}", s, e))))
202+
.map(|s| Url::parse(s).map_err(|e| D::Error::custom(format!("Invalid URL '{s}': {e}"))))
203203
.collect()
204204
}

crates/apollo_consensus_orchestrator/src/validate_proposal.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -298,13 +298,10 @@ async fn is_block_info_valid(
298298
block_info_proposed,
299299
block_info_validation,
300300
format!(
301-
"L1 gas price mismatch: expected L1 gas price FRI={}, proposed={}, expected L1 \
302-
data gas price FRI={}, proposed={}, l1_gas_price_margin_percent={}",
303-
l1_gas_price_fri,
304-
l1_gas_price_fri_proposed,
305-
l1_data_gas_price_fri,
306-
l1_data_gas_price_fri_proposed,
307-
l1_gas_price_margin_percent
301+
"L1 gas price mismatch: expected L1 gas price FRI={l1_gas_price_fri}, \
302+
proposed={l1_gas_price_fri_proposed}, expected L1 data gas price \
303+
FRI={l1_data_gas_price_fri}, proposed={l1_data_gas_price_fri_proposed}, \
304+
l1_gas_price_margin_percent={l1_gas_price_margin_percent}"
308305
),
309306
));
310307
}

crates/apollo_deployments/src/config_override.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ impl ConfigOverride {
4040
create: bool,
4141
) -> ConfigOverrideWithPaths {
4242
let deployment_path = deployment_config_override_dir.join(DEPLOYMENT_FILE_NAME);
43-
let instance_path = deployment_config_override_dir.join(format!("{}.json", instance_name));
43+
let instance_path = deployment_config_override_dir.join(format!("{instance_name}.json"));
4444

4545
if create {
4646
serialize_to_file(

crates/apollo_deployments/src/deployment.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,7 @@ pub(crate) fn build_service_namespace_domain_address(
156156
namespace: &str,
157157
domain: &str,
158158
) -> String {
159-
<<<<<<< HEAD
160-
format!("{service_name}.{namespace}.{domain}")
161-
||||||| 3f74dd8a6
162-
format!("{}.{}.{}", service_name, namespace, domain)
163-
=======
164-
format!("{}.{}.{}", node_service, namespace, domain)
165-
>>>>>>> origin/main-v0.14.0
159+
format!("{node_service}.{namespace}.{domain}")
166160
}
167161

168162
// TODO(Tsabary): when transitioning runnings nodes in different clusters, this enum should be

crates/apollo_deployments/src/deployment_definitions_test.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,10 @@ fn secrets_config_and_private_parameters_config_schema_compatibility() {
105105

106106
if !(only_in_config.is_empty() && only_in_schema.is_empty()) {
107107
panic!(
108-
"Secrets config override schema mismatch:\nSecrets provided by config: {:?}\nSecrets \
109-
required by schema: {:?}\nOnly in config: {:?}\nOnly in schema: {:?}",
110-
secrets_provided_by_config, secrets_required_by_schema, only_in_config, only_in_schema
108+
"Secrets config override schema mismatch:\nSecrets provided by config: \
109+
{secrets_provided_by_config:?}\nSecrets required by schema: \
110+
{secrets_required_by_schema:?}\nOnly in config: {only_in_config:?}\nOnly in schema: \
111+
{only_in_schema:?}"
111112
);
112113
}
113114
}

crates/apollo_deployments/src/deployments/hybrid.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,8 @@ use crate::k8s::{
2929
use crate::service::{GetComponentConfigs, NodeService, ServiceNameInner};
3030
use crate::utils::{determine_port_numbers, get_secret_key, get_validator_id};
3131

32-
<<<<<<< HEAD
3332
pub const HYBRID_NODE_REQUIRED_PORTS_NUM: usize = 10;
34-
||||||| 3f74dd8a6
35-
pub const HYBRID_NODE_REQUIRED_PORTS_NUM: usize = 9;
36-
=======
37-
pub const HYBRID_NODE_REQUIRED_PORTS_NUM: usize = 9;
3833
pub(crate) const INSTANCE_NAME_FORMAT: Template = Template("hybrid_{}");
39-
>>>>>>> origin/main-v0.14.0
4034

4135
const BASE_PORT: u16 = 55000; // TODO(Tsabary): arbitrary port, need to resolve.
4236
const CORE_STORAGE: usize = 1000;

crates/apollo_deployments/src/service.rs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -282,31 +282,7 @@ impl NodeType {
282282
self.to_string()
283283
}
284284

285-
<<<<<<< HEAD
286-
pub fn add_path_suffix(&self, path: PathBuf, instance_name: &str) -> PathBuf {
287-
let deployment_name_dir = path.join(self.get_folder_name());
288-
let deployment_with_instance = deployment_name_dir.join(instance_name);
289-
290-
let s = deployment_with_instance.to_string_lossy();
291-
let modified = if s.ends_with('/') { s.into_owned() } else { format!("{s}/") };
292-
modified.into()
293-
}
294-
295-
pub fn all_service_names(&self) -> Vec<ServiceName> {
296-
||||||| 3f74dd8a6
297-
pub fn add_path_suffix(&self, path: PathBuf, instance_name: &str) -> PathBuf {
298-
let deployment_name_dir = path.join(self.get_folder_name());
299-
let deployment_with_instance = deployment_name_dir.join(instance_name);
300-
301-
let s = deployment_with_instance.to_string_lossy();
302-
let modified = if s.ends_with('/') { s.into_owned() } else { format!("{}/", s) };
303-
modified.into()
304-
}
305-
306-
pub fn all_service_names(&self) -> Vec<ServiceName> {
307-
=======
308285
pub fn all_service_names(&self) -> Vec<NodeService> {
309-
>>>>>>> origin/main-v0.14.0
310286
match self {
311287
// TODO(Tsabary): find a way to avoid this code duplication.
312288
Self::Consolidated => {

0 commit comments

Comments
 (0)