starknet_os: refactor nondet hint IsReverted (#11122)

Author: dorimedini-starkware

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/execution/execute_transactions.cairo

@@ -479,7 +479,9 @@ func execute_invoke_function_transaction{
         execution_context=tx_execution_context
     );
 
-    if (nondet %{ execution_helper.tx_execution_info.is_reverted %} == FALSE) {
+    local is_reverted;
+    %{ IsReverted %}
+    if (is_reverted == FALSE) {
         // Execute only non-reverted transactions.
         with remaining_gas {
             cap_remaining_gas(max_gas=EXECUTE_MAX_SIERRA_GAS);
@@ -522,8 +524,10 @@ func execute_l1_handler_transaction{
     alloc_locals;
 
     %{ StartTx %}
+    local is_reverted;
+    %{ IsReverted %}
     // Skip the execution step for reverted transaction.
-    if (nondet %{ execution_helper.tx_execution_info.is_reverted %} != FALSE) {
+    if (is_reverted != FALSE) {
         %{ EndTx %}
         return ();
     }

crates/apollo_starknet_os_program/src/program_hash.json

@@ -1,6 +1,6 @@
 {
-  "os": "0x4567945373ae6aaacb9693b027795ef43d298e313a720e127ba2e4f7098b193",
-  "virtual_os": "0x1824f5cc61f95707596b6a189ff174e283dd101a79628f82b80ed3bce740f2c",
+  "os": "0x2cea6229ce04c350f1a56f359f0a700efa077d45cef3646d9f6643078d4e8f4",
+  "virtual_os": "0x32c2f13056b9125a20d30c94921e56e25243968ce4ad7a11373ca3996384272",
   "aggregator": "0x5757cea9a318eac0cb302b71e8fd14552074bab56932641e748094654a62aaa",
   "aggregator_with_prefix": "0x5513f3b2381c0e7a0ab8e70add986be3dffd8413356f8df4e941bf3bfe572b3"
 }

crates/starknet_os/src/hints/enum_definition.rs

@@ -675,18 +675,14 @@ define_hint_enum!(
     (TxAccountDeploymentData, tx_account_deployment_data),
     (TxProofFacts, tx_proof_facts),
     (GenSignatureArg, gen_signature_arg),
-    (
-        IsReverted,
-        is_reverted,
-        "memory[ap] = to_felt_or_relocatable(execution_helper.tx_execution_info.is_reverted)"
-    ),
+    (IsReverted, is_reverted),
     (CheckExecutionAndExitCall, check_execution_and_exit_call),
     (CheckSyscallResponse, check_syscall_response),
     (CheckNewCallContractResponse, check_new_call_contract_response),
     (CheckNewDeployResponse, check_new_deploy_response),
     (LogEnterSyscall, log_enter_syscall),
     (SetApToTxNonce, set_ap_to_tx_nonce, "memory[ap] = to_felt_or_relocatable(tx.nonce)"),
-    (SetFpToTxNonce, set_fp_to_tx_nonce, "memory[fp + 5] = to_felt_or_relocatable(tx.nonce)"),
+    (SetFpToTxNonce, set_fp_to_tx_nonce, "memory[fp + 6] = to_felt_or_relocatable(tx.nonce)"),
     (WriteSyscallResultDeprecated, write_syscall_result_deprecated),
     (WriteSyscallResult, write_syscall_result),
     (DeclareTxFields, declare_tx_fields),

crates/starknet_os/src/hints/hint_implementation/execution/implementation.rs

@@ -541,7 +541,7 @@ pub(crate) fn gen_signature_arg<S: StateReader>(
 
 pub(crate) fn is_reverted<S: StateReader>(
     hint_processor: &mut SnosHintProcessor<'_, S>,
-    HintArgs { vm, .. }: HintArgs<'_>,
+    HintArgs { vm, ids_data, ap_tracking, .. }: HintArgs<'_>,
 ) -> OsHintResult {
     let is_reverted = hint_processor
         .execution_helpers_manager
@@ -550,7 +550,13 @@ pub(crate) fn is_reverted<S: StateReader>(
         .get_tx_execution_info_ref()?
         .tx_execution_info
         .is_reverted();
-    insert_value_into_ap(vm, Felt::from(is_reverted))?;
+    insert_value_from_var_name(
+        Ids::IsReverted.into(),
+        Felt::from(is_reverted),
+        vm,
+        ids_data,
+        ap_tracking,
+    )?;
     Ok(())
 }
 

crates/starknet_os/src/hints/nondet_offsets.rs

@@ -19,7 +19,7 @@ pub mod test;
 /// implementation should be fetched from this map.
 pub(crate) static NONDET_FP_OFFSETS: LazyLock<HashMap<AllHints, usize>> = LazyLock::new(|| {
     HashMap::from([
-        (AllHints::OsHint(OsHint::SetFpToTxNonce), 5),
+        (AllHints::OsHint(OsHint::SetFpToTxNonce), 6),
         (AllHints::OsHint(OsHint::GetBlocksNumber), 3),
     ])
 });

crates/starknet_os/src/hints/vars.rs

@@ -209,6 +209,7 @@ define_string_enum! {
         (IsNUpdatesSmall),
         (IsOnCurve),
         (IsRemainingGasLtInitialBudget),
+        (IsReverted),
         (IsSierraGasMode),
         (Key),
         (KeyLtMinAliasAllocValue),