starknet_os_runner: run virtual os with state changes test (#12305)

Author: AvivYossef-starkware

crates/starknet_os_runner/src/lib.rs

@@ -12,6 +12,8 @@ pub mod virtual_snos_prover;
 #[cfg(test)]
 mod classes_provider_test;
 #[cfg(test)]
+mod runner_test;
+#[cfg(test)]
 mod storage_proofs_test;
 #[cfg(test)]
 pub mod test_utils;

crates/starknet_os_runner/src/runner.rs

@@ -209,8 +209,11 @@ where
         let tx_execution_infos =
             execution_data.execution_outputs.into_iter().map(|output| output.0.into()).collect();
 
-        // Add class hash to compiled class hash mappings from the classes provider.
+        // The extended_initial_reads from storage proofs already has class_hashes, nonces,
+        // and storage values. We just need to add compiled class hashes from the classes provider.
         let mut extended_initial_reads = storage_proofs.extended_initial_reads;
+
+        // Add class hash to compiled class hash mappings from the classes provider.
         extended_initial_reads
             .compiled_class_hashes
             .extend(&classes.class_hash_to_compiled_class_hash);

crates/starknet_os_runner/src/runner_test.rs

@@ -0,0 +1,51 @@
+//! Integration tests for the Runner.
+
+use blockifier_reexecution::state_reader::rpc_objects::BlockId;
+use blockifier_test_utils::calldata::create_calldata;
+use rstest::rstest;
+use starknet_api::core::ContractAddress;
+use starknet_api::invoke_tx_args;
+use starknet_api::test_utils::invoke::invoke_tx;
+
+use crate::runner::VirtualSnosRunner;
+use crate::test_utils::{
+    default_resource_bounds_for_client_side_tx,
+    sepolia_runner_factory,
+    DUMMY_ACCOUNT_ADDRESS,
+    STRK_TOKEN_ADDRESS_SEPOLIA,
+};
+
+/// Integration test for the full Runner flow with a balance_of transaction.
+/// # Running
+///
+/// ```bash
+/// SEPOLIA_NODE_URL=https://your-rpc-node cargo test -p starknet_os_runner test_run_os_with_balance_of_transaction -- --ignored
+/// ```
+#[rstest]
+#[tokio::test(flavor = "multi_thread")]
+#[ignore] // Requires RPC access.
+async fn test_run_os_with_balance_of_transaction() {
+    // Creates an invoke transaction that calls `balanceOf` on the STRK token.
+    let strk_token = ContractAddress::try_from(STRK_TOKEN_ADDRESS_SEPOLIA).unwrap();
+    let account = ContractAddress::try_from(DUMMY_ACCOUNT_ADDRESS).unwrap();
+
+    // Calldata matches dummy account's __execute__(contract_address, selector, calldata).
+    let calldata = create_calldata(strk_token, "balanceOf", &[account.into()]);
+    let resource_bounds = default_resource_bounds_for_client_side_tx();
+
+    let invoke_tx = invoke_tx(invoke_tx_args! {
+        sender_address: account,
+        calldata,
+        resource_bounds,
+    });
+
+    // Create a custom factory with the specified run_committer setting.
+    let factory = sepolia_runner_factory();
+    let block_id = BlockId::Latest;
+
+    // Verify execution succeeds.
+    factory
+        .run_virtual_os(block_id, vec![(invoke_tx)])
+        .await
+        .expect("run_virtual_os should succeed");
+}

crates/starknet_os_runner/src/test_utils.rs

@@ -1,16 +1,27 @@
 use std::env;
 
+use blockifier::blockifier::config::ContractClassManagerConfig;
+use blockifier::state::contract_class_manager::ContractClassManager;
 use blockifier_reexecution::state_reader::rpc_objects::BlockId;
 use blockifier_reexecution::state_reader::rpc_state_reader::RpcStateReader;
 use rstest::fixture;
-use starknet_api::block::BlockNumber;
+use starknet_api::block::{BlockNumber, GasPrice};
 use starknet_api::core::ChainId;
+use starknet_api::execution_resources::GasAmount;
+use starknet_api::transaction::fields::{AllResourceBounds, ResourceBounds, ValidResourceBounds};
 use starknet_types_core::felt::Felt;
 use url::Url;
 
-use crate::storage_proofs::RpcStorageProofsProvider;
+use crate::runner::{RpcRunnerFactory, RunnerConfig};
+use crate::storage_proofs::{RpcStorageProofsProvider, StorageProofConfig};
 use crate::virtual_block_executor::RpcVirtualBlockExecutor;
 
+// ================================================================================================
+// Constants
+// ================================================================================================
+
+// --- Mainnet ---
+
 /// Block number to use for testing (mainnet block with known state).
 pub const TEST_BLOCK_NUMBER: u64 = 800000;
 
@@ -22,12 +33,36 @@ pub const STRK_TOKEN_ADDRESS: Felt =
 pub const SENDER_ADDRESS: Felt =
     Felt::from_hex_unchecked("0x01176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8");
 
-/// Gets the RPC URL from the environment (NODE_URL).
+// --- Sepolia ---
+
+/// STRK token contract address on Sepolia.
+pub const STRK_TOKEN_ADDRESS_SEPOLIA: Felt =
+    Felt::from_hex_unchecked("0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d");
+
+/// Dummy account on Sepolia (no signature validation required).
+/// This account uses the `account_with_dummy_validate` contract which always returns VALIDATED.
+pub const DUMMY_ACCOUNT_ADDRESS: Felt =
+    Felt::from_hex_unchecked("0x0786ed7d8dcbf1489241d65a4dd55f18b984c078558ce12def69802526fa918e");
+
+// ================================================================================================
+// RPC URL Helpers
+// ================================================================================================
+
+/// Gets the mainnet RPC URL from the environment (NODE_URL).
 pub fn get_rpc_url() -> String {
     env::var("NODE_URL").expect("NODE_URL environment variable required for this test")
 }
 
-/// Fixture that creates an RpcStateReader for testing.
+/// Gets the Sepolia RPC URL (defaults to local node, can be overridden via SEPOLIA_NODE_URL).
+pub fn get_sepolia_rpc_url() -> String {
+    env::var("SEPOLIA_NODE_URL").unwrap_or_else(|_| "http://localhost:9546/rpc/v0_10".to_string())
+}
+
+// ================================================================================================
+// Mainnet Fixtures
+// ================================================================================================
+
+/// Fixture that creates an RpcStateReader for mainnet testing.
 #[fixture]
 pub fn rpc_state_reader() -> RpcStateReader {
     let node_url = get_rpc_url();
@@ -38,6 +73,7 @@ pub fn rpc_state_reader() -> RpcStateReader {
     )
 }
 
+/// Fixture that creates an RpcVirtualBlockExecutor for mainnet testing.
 #[fixture]
 pub fn rpc_virtual_block_executor(rpc_state_reader: RpcStateReader) -> RpcVirtualBlockExecutor {
     RpcVirtualBlockExecutor {
@@ -47,10 +83,45 @@ pub fn rpc_virtual_block_executor(rpc_state_reader: RpcStateReader) -> RpcVirtua
     }
 }
 
-/// Fixture that creates an RpcStorageProofsProvider for testing.
+/// Fixture that creates an RpcStorageProofsProvider for mainnet testing.
 #[fixture]
 pub fn rpc_provider() -> RpcStorageProofsProvider {
-    let rpc_url_str = get_rpc_url();
-    let rpc_url = Url::parse(&rpc_url_str).expect("Invalid RPC URL");
+    let rpc_url = Url::parse(&get_rpc_url()).expect("Invalid RPC URL");
     RpcStorageProofsProvider::new(rpc_url)
 }
+
+// ================================================================================================
+// Sepolia Fixtures
+// ================================================================================================
+
+/// Fixture that creates an RpcRunnerFactory for Sepolia with committer enabled.
+///
+/// This factory is configured to run the committer, meaning it will:
+/// - Build a FactsDb from RPC proofs and execution data.
+/// - Execute the committer to compute new state roots.
+/// - Generate commitment infos with actual root changes.
+#[fixture]
+pub fn sepolia_runner_factory() -> RpcRunnerFactory {
+    let rpc_url = Url::parse(&get_sepolia_rpc_url()).expect("Invalid Sepolia RPC URL");
+    let contract_class_manager = ContractClassManager::start(ContractClassManagerConfig::default());
+
+    let runner_config =
+        RunnerConfig { storage_proof_config: StorageProofConfig { include_state_changes: true } };
+
+    RpcRunnerFactory::new(rpc_url, ChainId::Sepolia, contract_class_manager, runner_config)
+}
+
+// ================================================================================================
+// Transaction Helpers
+// ================================================================================================
+
+pub(crate) fn default_resource_bounds_for_client_side_tx() -> ValidResourceBounds {
+    ValidResourceBounds::AllResources(AllResourceBounds {
+        l1_gas: ResourceBounds { max_amount: GasAmount(0), max_price_per_unit: GasPrice(0) },
+        l2_gas: ResourceBounds {
+            max_amount: GasAmount(10_000_000),
+            max_price_per_unit: GasPrice(0),
+        },
+        l1_data_gas: ResourceBounds { max_amount: GasAmount(0), max_price_per_unit: GasPrice(0) },
+    })
+}