starknet_os: load proof facts from invoke transaction in the os (#10749)

Author: meship-starkware

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/execution/execute_transactions.cairo

@@ -482,6 +482,10 @@ func execute_invoke_function_transaction{
     local account_deployment_data: felt* = cast(
         nondet %{ segments.gen_arg(tx.account_deployment_data) %}, felt*
     );
+    local proof_facts_size;
+    local proof_facts: felt*;
+    %{ TxProofFacts %}
+
     let poseidon_ptr = builtin_ptrs.selectable.poseidon;
     // TODO(Meshi): use the invoke transaction proof facts once implemented.
     with poseidon_ptr {
@@ -502,14 +506,13 @@ func execute_invoke_function_transaction{
 
     // Write the transaction info and complete the ExecutionInfo struct.
     tempvar tx_info = tx_execution_info.tx_info;
-    // TODO(Meshi): use the invoke transaction proof facts once implemented.
     fill_account_tx_info(
         transaction_hash=transaction_hash,
         common_tx_fields=common_tx_fields,
         account_deployment_data_size=account_deployment_data_size,
         account_deployment_data=account_deployment_data,
-        proof_facts_size=0,
-        proof_facts=cast(0, felt*),
+        proof_facts_size=proof_facts_size,
+        proof_facts=proof_facts,
         tx_info_dst=tx_info,
         deprecated_tx_info_dst=tx_execution_context.deprecated_tx_info,
     );

crates/apollo_starknet_os_program/src/program_hash.json

@@ -1,5 +1,5 @@
 {
-  "os": "0x6d4d7cc0d4fce1cfd9236e3cd173e7ea44c8d0acdbfca8b5c8c579df0443740",
+  "os": "0x55015a0e25ba9a0064c6fb6c78d28a3e47eae9833cc101ad45a125e3261ce63",
   "aggregator": "0x9b8449bd89d58c92904972e8be142e87b00edc38c19e0a331c30790771653",
   "aggregator_with_prefix": "0x606fbb6fd6b4d56443467ac666fba1dc41e291f2faf3729aff708318d193f63"
 }

crates/starknet_api/src/executable_transaction.rs

@@ -20,6 +20,7 @@ use crate::transaction::fields::{
     ContractAddressSalt,
     Fee,
     PaymasterData,
+    ProofFacts,
     Tip,
     TransactionSignature,
     ValidResourceBounds,
@@ -327,7 +328,8 @@ impl InvokeTransaction {
         (nonce_data_availability_mode, DataAvailabilityMode),
         (fee_data_availability_mode, DataAvailabilityMode),
         (paymaster_data, PaymasterData),
-        (account_deployment_data, AccountDeploymentData)
+        (account_deployment_data, AccountDeploymentData),
+        (proof_facts, ProofFacts)
     );
     implement_getter_calls!((tx_hash, TransactionHash));
 

crates/starknet_api/src/transaction.rs

@@ -723,7 +723,8 @@ impl InvokeTransaction {
         (nonce_data_availability_mode, DataAvailabilityMode),
         (fee_data_availability_mode, DataAvailabilityMode),
         (paymaster_data, PaymasterData),
-        (account_deployment_data, AccountDeploymentData)
+        (account_deployment_data, AccountDeploymentData),
+        (proof_facts, ProofFacts)
     );
 
     pub fn nonce(&self) -> Nonce {

crates/starknet_os/src/hints/enum_definition.rs

@@ -123,6 +123,7 @@ use crate::hints::hint_implementation::execution::implementation::{
     tx_nonce_data_availability_mode,
     tx_paymaster_data,
     tx_paymaster_data_len,
+    tx_proof_facts,
     tx_tip,
     tx_version,
     write_old_block_to_storage,
@@ -1415,6 +1416,7 @@ ids.contract_class_component_hashes = segments.gen_arg(class_component_hashes)"#
         tx_account_deployment_data,
         "memory[ap] = to_felt_or_relocatable(segments.gen_arg(tx.account_deployment_data))"
     ),
+    (TxProofFacts, tx_proof_facts, "TxProofFacts"),
     (
         GenSignatureArg,
         gen_signature_arg,

crates/starknet_os/src/hints/hint_implementation/execution/implementation.rs

@@ -30,6 +30,7 @@ use crate::hints::hint_implementation::execution::utils::{
     extract_actual_retdata,
     get_account_deployment_data,
     get_calldata,
+    get_proof_facts,
     set_state_entry,
 };
 use crate::hints::nondet_offsets::insert_nondet_hint_value;
@@ -524,6 +525,33 @@ pub(crate) fn tx_account_deployment_data<S: StateReader>(
     Ok(())
 }
 
+pub(crate) fn tx_proof_facts<S: StateReader>(
+    hint_processor: &mut SnosHintProcessor<'_, S>,
+    HintArgs { vm, ids_data, ap_tracking, .. }: HintArgs<'_>,
+) -> OsHintResult {
+    let proof_facts: Vec<_> = get_proof_facts(hint_processor.get_current_execution_helper()?)?
+        .0
+        .iter()
+        .map(MaybeRelocatable::from)
+        .collect();
+    let proof_facts_base = vm.gen_arg(&proof_facts)?;
+    insert_value_from_var_name(
+        Ids::ProofFacts.into(),
+        proof_facts_base,
+        vm,
+        ids_data,
+        ap_tracking,
+    )?;
+    insert_value_from_var_name(
+        Ids::ProofFactsSize.into(),
+        proof_facts.len(),
+        vm,
+        ids_data,
+        ap_tracking,
+    )?;
+    Ok(())
+}
+
 pub(crate) fn gen_signature_arg<S: StateReader>(
     hint_processor: &mut SnosHintProcessor<'_, S>,
     HintArgs { ids_data, ap_tracking, vm, .. }: HintArgs<'_>,

crates/starknet_os/src/hints/hint_implementation/execution/utils.rs

@@ -17,6 +17,7 @@ use starknet_api::transaction::fields::{
     valid_resource_bounds_as_felts,
     AccountDeploymentData,
     Calldata,
+    ProofFacts,
     ResourceAsFelts,
     ValidResourceBounds,
 };
@@ -93,6 +94,18 @@ pub(crate) fn get_account_deployment_data<S: StateReader>(
     }
 }
 
+pub(crate) fn get_proof_facts<S: StateReader>(
+    execution_helper: &OsExecutionHelper<'_, S>,
+) -> Result<ProofFacts, OsHintError> {
+    let tx = execution_helper.tx_tracker.get_account_tx()?;
+    match tx {
+        AccountTransaction::Invoke(invoke) => Ok(invoke.proof_facts()),
+        AccountTransaction::DeployAccount(_) | AccountTransaction::Declare(_) => {
+            Err(OsHintError::UnexpectedTxType(tx.tx_type()))
+        }
+    }
+}
+
 pub(crate) fn get_calldata<'a, S: StateReader>(
     execution_helper: &OsExecutionHelper<'a, S>,
 ) -> Result<&'a Calldata, OsHintError> {

crates/starknet_os/src/hints/vars.rs

@@ -237,6 +237,8 @@ define_string_enum! {
         (PrevAliasesStateEntry),
         (PrevRoot),
         (PrevValue),
+        (ProofFacts),
+        (ProofFactsSize),
         (PublicKeys),
         (SnPrivateKeys),
         (RangeCheck96Ptr, "range_check96_ptr"),

crates/starknet_os_flow_tests/resources/hint_coverage/declare_deploy_scenario_n_blocks_1_use_kzg_da_false_full_output_false.json

@@ -305,6 +305,9 @@
   {
     "OsHint": "TxAccountDeploymentData"
   },
+  {
+    "OsHint": "TxProofFacts"
+  },
   {
     "OsHint": "GenSignatureArg"
   },

crates/starknet_os_flow_tests/resources/hint_coverage/declare_deploy_scenario_n_blocks_1_use_kzg_da_false_full_output_true.json

@@ -284,6 +284,9 @@
   {
     "OsHint": "TxAccountDeploymentData"
   },
+  {
+    "OsHint": "TxProofFacts"
+  },
   {
     "OsHint": "GenSignatureArg"
   },