starknet_patricia_storage: non mut get in storage trait

Author: nimrod-starkware

crates/starknet_committer_cli/src/commands.rs

@@ -376,7 +376,7 @@ fn apply_interference<S: AsyncStorage>(
     n_updates_arg: usize,
     block_number: usize,
     task_set: &mut JoinSet<()>,
-    mut storage: S,
+    storage: S,
     rng: &mut SmallRng,
 ) {
     match interference_type {

crates/starknet_patricia_storage/src/aerospike_storage.rs

@@ -117,7 +117,7 @@ impl Storage for AerospikeStorage {
     type Stats = NoStats;
     type Config = EmptyStorageConfig;
 
-    async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         let record = self
             .client
             .get(&self.config.read_policy, &self.get_key(key.clone())?, Bins::All)
@@ -136,7 +136,7 @@ impl Storage for AerospikeStorage {
             .await?)
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         let mut ops = Vec::new();
         for key in keys.iter() {
             ops.push(BatchOperation::read(

crates/starknet_patricia_storage/src/map_storage.rs

@@ -51,11 +51,11 @@ impl Storage for MapStorage {
         Ok(())
     }
 
-    async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         Ok(self.0.get(key).cloned())
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         Ok(keys.iter().map(|key| self.0.get(key).cloned()).collect())
     }
 
@@ -222,7 +222,7 @@ impl<S: Storage> Storage for CachedStorage<S> {
     type Stats = CachedStorageStats<S::Stats>;
     type Config = CachedStorageConfig<S::Config>;
 
-    async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         if let Some(cached_value) = self.cache.get(key) {
             return Ok(cached_value);
         }
@@ -239,7 +239,7 @@ impl<S: Storage> Storage for CachedStorage<S> {
         Ok(())
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         let mut values = vec![None; keys.len()]; // The None values are placeholders.
         let mut keys_to_fetch = Vec::new();
         let mut indices_to_fetch = Vec::new();

crates/starknet_patricia_storage/src/mdbx_storage.rs

@@ -103,7 +103,7 @@ impl Storage for MdbxStorage {
     type Stats = MdbxStorageStats;
     type Config = EmptyStorageConfig;
 
-    async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         let txn = self.db.begin_ro_txn()?;
         let table = txn.open_table(None)?;
         Ok(txn.get(&table, &key.0)?.map(DbValue))
@@ -117,7 +117,7 @@ impl Storage for MdbxStorage {
         Ok(())
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         let txn = self.db.begin_ro_txn()?;
         let table = txn.open_table(None)?;
         let mut res = Vec::with_capacity(keys.len());

crates/starknet_patricia_storage/src/rocksdb_storage.rs

@@ -277,15 +277,15 @@ impl Storage for RocksDbStorage {
     type Stats = RocksDbStats;
     type Config = RocksDbStorageConfig;
 
-    async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         Ok(self.db.get(&key.0)?.map(DbValue))
     }
 
     async fn set(&mut self, key: DbKey, value: DbValue) -> PatriciaStorageResult<()> {
         Ok(self.db.put_opt(&key.0, &value.0, &self.options.write_options)?)
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         let raw_keys = keys.iter().map(|k| &k.0);
         let res = self
             .db

crates/starknet_patricia_storage/src/short_key_storage.rs

@@ -50,15 +50,15 @@ macro_rules! define_short_key_storage {
             type Stats = S::Stats;
             type Config = EmptyStorageConfig;
 
-            async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+            async fn get(&self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
                 self.storage.get(&Self::small_key(key)).await
             }
 
             async fn set(&mut self, key: DbKey, value: DbValue) -> PatriciaStorageResult<()> {
                 self.storage.set(Self::small_key(&key), value).await
             }
 
-            async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+            async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
                 let small_keys = keys
                     .iter()
                     .map(|key| Self::small_key(key))

crates/starknet_patricia_storage/src/storage_test.rs

@@ -37,7 +37,7 @@ async fn test_storage_concurrent_access(#[case] mut storage: impl AsyncStorage)
     // Parallel reads from the storage while some writes are happening.
     let mut tasks = JoinSet::new();
     for i in 0..10u8 {
-        let mut cloned_storage = storage.clone();
+        let cloned_storage = storage.clone();
         tasks.spawn(async move {
             let result = cloned_storage.get(&DbKey(vec![i])).await.unwrap().unwrap().0[0];
             // The result is either the original value or the new value.

crates/starknet_patricia_storage/src/storage_trait.rs

@@ -103,7 +103,7 @@ pub trait Storage: Send + Sync {
     // https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html#async-fn-in-public-traits
     // for details.
     fn get(
-        &mut self,
+        &self,
         key: &DbKey,
     ) -> impl Future<Output = PatriciaStorageResult<Option<DbValue>>> + Send;
 
@@ -123,7 +123,7 @@ pub trait Storage: Send + Sync {
     // https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html#async-fn-in-public-traits
     // for details.
     fn mget(
-        &mut self,
+        &self,
         keys: &[&DbKey],
     ) -> impl Future<Output = PatriciaStorageResult<Vec<Option<DbValue>>>> + Send;
 
@@ -194,15 +194,15 @@ impl Storage for NullStorage {
     type Stats = NoStats;
     type Config = EmptyStorageConfig;
 
-    async fn get(&mut self, _key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
+    async fn get(&self, _key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
         Ok(None)
     }
 
     async fn set(&mut self, _key: DbKey, _value: DbValue) -> PatriciaStorageResult<()> {
         Ok(())
     }
 
-    async fn mget(&mut self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
+    async fn mget(&self, keys: &[&DbKey]) -> PatriciaStorageResult<Vec<Option<DbValue>>> {
         Ok(vec![None; keys.len()])
     }