Skip to content

Commit b58d052

Browse files
apollo_l1_provider: fix info log on wrong height (#10903)
1 parent 6ba872f commit b58d052

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

crates/apollo_l1_provider/src/l1_provider.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,16 @@ impl L1Provider {
327327
);
328328
} else {
329329
info!(
330-
"Provider received a block_height ({height}) that is higher than the \
330+
"Provider received a block_height ({height}) that is different than the \
331331
current height ({}), starting catch-up process.",
332332
self.current_height
333333
);
334+
// TODO(guyn): in case block_height is lower than current_height, should we
335+
// still go to catchup? Perhaps it is better to return an
336+
// error and let the batcher keep going without the Provider?
337+
// Do we need to check that the blocks getting committed are consistent with the
338+
// provider records? Can we just accept the block without an
339+
// error if we do that check?
334340
self.start_catching_up(height);
335341
}
336342
Err(err)

0 commit comments

Comments
 (0)