apollo_proof_manager: test fs proof storage

Author: einat-starkware

crates/apollo_proof_manager/src/proof_storage.rs

@@ -9,6 +9,10 @@ use starknet_api::transaction::fields::Proof;
 use starknet_types_core::felt::Felt;
 use thiserror::Error;
 
+#[cfg(test)]
+#[path = "proof_storage_test.rs"]
+mod proof_storage_test;
+
 pub trait ProofStorage: Send + Sync {
     type Error: Error;
     fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), Self::Error>;
@@ -91,7 +95,6 @@ impl FsProofStorage {
 
     /// Writes a proof to a file in binary format.
     /// The file is named `proof` inside the given directory.
-    #[allow(dead_code)]
     fn write_proof_to_file(&self, path: &Path, proof: &Proof) -> FsProofStorageResult<()> {
         let path = path.join("proof");
         if let Some(parent) = path.parent() {
@@ -168,6 +171,9 @@ impl ProofStorage for FsProofStorage {
 
         match self.read_proof_from_file(facts_hash) {
             Ok(proof) => Ok(Some(proof)),
+            Err(FsProofStorageError::IoError(e)) if e.kind() == std::io::ErrorKind::NotFound => {
+                Ok(None)
+            }
             Err(e) => Err(e),
         }
     }

crates/apollo_proof_manager/src/proof_storage_test.rs

@@ -0,0 +1,42 @@
+use std::path::PathBuf;
+
+use starknet_api::transaction::fields::Proof;
+use starknet_types_core::felt::Felt;
+
+use crate::proof_storage::{FsProofStorage, ProofStorage};
+
+fn new_fs_proof_storage() -> FsProofStorage {
+    let tmp_dir = tempfile::tempdir().unwrap();
+    let persistent_root: PathBuf = tmp_dir.path().to_path_buf();
+    FsProofStorage::new(persistent_root).expect("Failed to create FsProofStorage")
+}
+
+fn sample_facts_hash() -> Felt {
+    Felt::from(0x1234_u64)
+}
+
+fn sample_proof() -> Proof {
+    Proof::from(vec![1_u32, 2_u32, 3_u32, 4_u32, 5_u32])
+}
+
+#[test]
+fn fs_proof_storage_get_before_set_returns_none() {
+    let storage = new_fs_proof_storage();
+    let facts_hash = sample_facts_hash();
+
+    let res = storage.get_proof(facts_hash);
+    assert!(res.is_ok());
+    assert!(res.unwrap().is_none());
+}
+
+#[test]
+fn fs_proof_storage_roundtrip() {
+    let storage = new_fs_proof_storage();
+    let facts_hash = sample_facts_hash();
+    let proof = sample_proof();
+
+    storage.set_proof(facts_hash, proof.clone()).unwrap();
+
+    let retrieved = storage.get_proof(sample_facts_hash()).unwrap();
+    assert_eq!(retrieved, Some(proof));
+}