Skip to content

Commit d69d8d3

Browse files
committed
apollo_integration_tests: clean old todos
1 parent 7a3abbf commit d69d8d3

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

crates/apollo_integration_tests/tests/common/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Each test module is compiled as a separate crate, and all can declare the common module.
22
// This means that any peace of code in this module that is not used by *all* test modules will be
33
// identified as unused code by clippy (for one of the crates).
4+
// TODO(Arni): Fix this.
45
#![allow(dead_code)]
56

67
use std::time::Duration;
@@ -203,7 +204,7 @@ fn assert_full_blocks_flow(recorder_handle: &PrometheusHandle, expecting_full_bl
203204
}
204205
// Just because we don't expect full blocks, doesn't mean we should assert that the metric is 0.
205206
// It is possible that a block is filled, no need to assert that this is not the case.
206-
// TODO(AlonH): In the `else` case, assert that some block closed due to time.
207+
// TODO(Arni): In the `else` case, assert that some block closed due to time.
207208
}
208209

209210
fn assert_on_number_of_reverted_transactions_flow(

crates/apollo_integration_tests/tests/end_to_end_flow_test.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ use crate::common::{end_to_end_flow, test_single_tx, EndToEndFlowArgs, TestScena
1515

1616
mod common;
1717

18-
// TODO(Meshi): Fail the test if no class have migrated.
1918
/// Number of threads is 3 = Num of sequencer + 1 for the test thread.
2019
#[tokio::test(flavor = "multi_thread", worker_threads = 3)]
2120
async fn test_end_to_end_flow() {
@@ -31,7 +30,6 @@ fn create_test_scenarios() -> Vec<TestScenario> {
3130
vec![
3231
// This block should be the first to be tested, as the addition of L1 handler transaction
3332
// does not work smoothly with the current architecture of the test.
34-
// TODO(Arni): Fix this. Move the L1 handler to be not the first block.
3533
TestScenario {
3634
create_rpc_txs_fn: |_| vec![],
3735
create_l1_to_l2_messages_args_fn: create_l1_to_l2_message_args,

0 commit comments

Comments
 (0)