apollo_consensus: add helper function to report peer

Author: guy-starkware

crates/apollo_consensus/src/manager.rs

@@ -783,6 +783,21 @@ impl<ContextT: ConsensusContext> MultiHeightManager<ContextT> {
         }
     }
 
+    fn report_peer(
+        &self,
+        broadcast_channels: &mut BroadcastVoteChannel,
+        metadata: &BroadcastedMessageMetadata,
+    ) {
+        if broadcast_channels
+            .broadcast_topic_client
+            .report_peer(metadata.clone())
+            .now_or_never()
+            .is_none()
+        {
+            error!("Unable to send report_peer. {:?}", metadata);
+        }
+    }
+
     async fn handle_proposal_known_block_info(
         &mut self,
         context: &mut ContextT,
@@ -822,14 +837,7 @@ impl<ContextT: ConsensusContext> MultiHeightManager<ContextT> {
             }
             (Err(e), metadata) => {
                 // Failed to parse consensus message. Report the peer and drop the vote.
-                if broadcast_channels
-                    .broadcast_topic_client
-                    .report_peer(metadata.clone())
-                    .now_or_never()
-                    .is_none()
-                {
-                    error!("Unable to send report_peer. {:?}", metadata)
-                }
+                self.report_peer(broadcast_channels, &metadata);
                 warn!(
                     "Failed to parse incoming consensus vote, dropping vote. Error: {e}. Vote \
                      metadata: {metadata:?}"