feat(starknet_os): remove the program from the OS runner inputs

Author: dorimedini-starkware

Cargo.lock

@@ -1,4 +1,3 @@
-use std::fs;
 use std::path::Path;
 
 use apollo_starknet_os_program::test_programs::ALIASES_TEST_BYTES;
@@ -26,9 +25,6 @@ use crate::shared_utils::read::{load_input, write_to_file};
 #[derive(Deserialize, Debug)]
 /// Input to the os runner.
 pub(crate) struct Input {
-    // A path to a compiled program that its hint set should be a subset of those defined in
-    // starknet-os.
-    pub compiled_os_path: String,
     pub layout: LayoutName,
     pub os_hints: OsHints,
     pub cairo_pie_zip_path: String,
@@ -77,15 +73,11 @@ pub fn validate_input(os_input: &StarknetOsInput) {
 }
 
 pub fn parse_and_run_os(input_path: String, output_path: String) {
-    let Input { compiled_os_path, layout, os_hints, cairo_pie_zip_path } = load_input(input_path);
+    let Input { layout, os_hints, cairo_pie_zip_path } = load_input(input_path);
     validate_input(&os_hints.os_input);
 
-    // Load the compiled_os from the compiled_os_path.
-    let compiled_os =
-        fs::read(Path::new(&compiled_os_path)).expect("Failed to read compiled_os file");
-
     let StarknetOsRunnerOutput { os_output, cairo_pie, unused_hints } =
-        run_os_stateless(&compiled_os, layout, os_hints)
+        run_os_stateless(layout, os_hints)
             .unwrap_or_else(|err| panic!("OS run failed. Error: {}", err));
     serialize_os_runner_output(
         &OsCliOutput { os_output, unused_hints },

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs

@@ -17,6 +17,7 @@ testing = ["blockifier/testing", "starknet_patricia/testing"]
 
 [dependencies]
 apollo_infra_utils.workspace = true
+apollo_starknet_os_program.workspace = true
 ark-bls12-381.workspace = true
 ark-ff.workspace = true
 ark-poly.workspace = true

crates/starknet_os/Cargo.toml

@@ -1081,6 +1081,7 @@ segments.write_arg(ids.sha256_ptr_end, padding)"#}
         indoc! {r#"
     if execution_helper.debug_mode:
         # Validate the predicted gas cost.
+        # TODO(Yoni, 1/1/2025): remove this check once Cairo 0 is not supported.
         actual = ids.remaining_gas - ids.entry_point_return_values.gas_builtin
         predicted = execution_helper.call_info.gas_consumed
         if execution_helper.call_info.tracked_resource.is_sierra_gas():
@@ -1408,6 +1409,7 @@ segments.write_arg(ids.sha256_ptr_end, padding)"#}
         onchain_data_start = ids.da_start
         onchain_data_size = ids.output_ptr - onchain_data_start
 
+        # TODO(Yoni,20/07/2023): Take from input.
         max_page_size = 3800
         n_pages = div_ceil(onchain_data_size, max_page_size)
         for i in range(n_pages):

crates/starknet_os/src/hints/enum_definition.rs

@@ -1,7 +1,7 @@
+use apollo_starknet_os_program::OS_PROGRAM;
 use blockifier::state::state_api::StateReader;
 use cairo_vm::cairo_run::CairoRunConfig;
 use cairo_vm::types::layout_name::LayoutName;
-use cairo_vm::types::program::Program;
 use cairo_vm::vm::errors::vm_exception::VmException;
 use cairo_vm::vm::runners::cairo_runner::CairoRunner;
 
@@ -17,7 +17,6 @@ use crate::io::os_output::{get_run_output, StarknetOsRunnerOutput};
 
 #[allow(clippy::result_large_err)]
 pub fn run_os<S: StateReader>(
-    compiled_os: &[u8],
     layout: LayoutName,
     OsHints {
         os_hints_config,
@@ -36,12 +35,9 @@ pub fn run_os<S: StateReader>(
         CairoRunConfig { layout, relocate_mem: true, trace_enabled: true, ..Default::default() };
     let allow_missing_builtins = cairo_run_config.allow_missing_builtins.unwrap_or(false);
 
-    // Load the Starknet OS Program.
-    let os_program = Program::from_bytes(compiled_os, Some(cairo_run_config.entrypoint))?;
-
     // Init cairo runner.
     let mut cairo_runner = CairoRunner::new(
-        &os_program,
+        &OS_PROGRAM,
         cairo_run_config.layout,
         cairo_run_config.dynamic_layout_params,
         cairo_run_config.proof_mode,
@@ -58,7 +54,7 @@ pub fn run_os<S: StateReader>(
 
     // Create the hint processor.
     let mut snos_hint_processor = SnosHintProcessor::new(
-        &os_program,
+        &OS_PROGRAM,
         os_hints_config,
         os_block_inputs.iter().collect(),
         cached_state_inputs,
@@ -112,10 +108,9 @@ pub fn run_os<S: StateReader>(
 /// not pre-loaded as part of the input.
 #[allow(clippy::result_large_err)]
 pub fn run_os_stateless(
-    compiled_os: &[u8],
     layout: LayoutName,
     os_hints: OsHints,
 ) -> Result<StarknetOsRunnerOutput, StarknetOsError> {
     let n_blocks = os_hints.os_input.os_block_inputs.len();
-    run_os(compiled_os, layout, os_hints, vec![PanickingStateReader; n_blocks])
+    run_os(layout, os_hints, vec![PanickingStateReader; n_blocks])
 }