starknet_patricia_storage: dont cache reads in cached storage

Author: nimrod-starkware

crates/starknet_patricia_storage/src/map_storage.rs

@@ -72,7 +72,7 @@ impl Storage for MapStorage {
 }
 
 /// A storage wrapper that adds an LRU cache to an underlying storage.
-/// Only getter methods are cached.
+/// Getter methods are not cached.
 pub struct CachedStorage<S: Storage> {
     pub storage: S,
     pub cache: LruCache<DbKey, Option<DbValue>>,
@@ -228,14 +228,13 @@ impl<S: Storage> Storage for CachedStorage<S> {
     type Config = CachedStorageConfig<S::Config>;
 
     async fn get(&mut self, key: &DbKey) -> PatriciaStorageResult<Option<DbValue>> {
-        if let Some(cached_value) = self.cache.get(key) {
+        if let Some(cached_value) = self.cache.peek(key) {
             self.cached_reads.fetch_add(1, Ordering::Relaxed);
             return Ok(cached_value.clone());
         }
 
         self.reads.fetch_add(1, Ordering::Relaxed);
         let storage_value = self.storage.get(key).await?;
-        self.cache.put(key.clone(), storage_value.clone());
         Ok(storage_value)
     }
 
@@ -253,7 +252,7 @@ impl<S: Storage> Storage for CachedStorage<S> {
         let mut cached_reads = 0;
 
         for (index, key) in keys.iter().enumerate() {
-            if let Some(cached_value) = self.cache.get(key) {
+            if let Some(cached_value) = self.cache.peek(key) {
                 values[index] = cached_value.clone();
                 cached_reads += 1;
             } else {
@@ -267,12 +266,9 @@ impl<S: Storage> Storage for CachedStorage<S> {
         self.cached_reads.fetch_add(cached_reads, Ordering::Relaxed);
 
         let fetched_values = self.storage.mget(keys_to_fetch.as_slice()).await?;
-        indices_to_fetch.iter().zip(keys_to_fetch).zip(fetched_values).for_each(
-            |((index, key), value)| {
-                self.cache.put((*key).clone(), value.clone());
-                values[*index] = value;
-            },
-        );
+        indices_to_fetch.iter().zip(fetched_values).for_each(|(index, value)| {
+            values[*index] = value;
+        });
 
         Ok(values)
     }