Skip to content

Commit 1cbc50a

Browse files
committed
Merge pull request #7 from vgrafe/master
replaced (and removed) currentUrl() $scope method
2 parents 5fdb4c6 + e25d417 commit 1cbc50a

File tree

2 files changed

+33
-36
lines changed

2 files changed

+33
-36
lines changed

app/scripts/directives/sidebar/sidebar.html

Lines changed: 31 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,47 +2,49 @@
22
<div class="sidebar-nav navbar-collapse">
33
<ul class="nav in" id="side-menu">
44
<sidebar-search></sidebar-search>
5-
<li ng-class="{active: currentUrl()=='/dashboard/home'}">
6-
<a ui-sref="dashboard.home"><i class="fa fa-dashboard fa-fw"></i> Dashboard</a>
7-
</li>
8-
<li ng-class="{active: currentUrl()=='/dashboard/chart'}">
5+
<li ui-sref-active="active">
6+
<a ui-sref="dashboard.home"><i class="fa fa-dashboard fa-fw"></i> Dashboard</a>
7+
</li>
8+
<li ui-sref-active="active">
99

1010
<a ui-sref="dashboard.chart"><i class="fa fa-bar-chart-o fa-fw"></i> Charts<span></span></a>
11-
11+
1212
</li>
13-
<li ng-class="{active:currentUrl()=='/dashboard/tables'}">
13+
<li ui-sref-active="active">
1414
<a ui-sref="dashboard.table"><i class="fa fa-table fa-fw"></i> Tables</a>
1515
</li>
16-
<li ng-class="{active: currentUrl()=='/dashboard/forms'}">
16+
<li ui-sref-active="active">
1717
<a ui-sref="dashboard.form"><i class="fa fa-edit fa-fw"></i> Forms</a>
1818
</li>
1919
<li ng-class="{active: collapseVar==1}">{{dropDown}}
20-
<a href="" ng-click="check(1)"><i class="fa fa-wrench fa-fw"></i> UI Elements<span class="fa arrow"></span></a>
21-
<ul class="nav nav-second-level" collapse ="collapseVar!=1">
22-
<li ng-class="{active: currentUrl()=='/dashboard/panels-wells'}">
20+
<a href="" ng-click="check(1)"><i class="fa fa-wrench fa-fw"></i> UI Elements<span
21+
class="fa arrow"></span></a>
22+
<ul class="nav nav-second-level" collapse="collapseVar!=1">
23+
<li ui-sref-active="active">
2324
<a ui-sref="dashboard.panels-wells">Panels and Wells</a>
2425
</li>
25-
<li ng-class="{active: currentUrl()=='/dashboard/buttons'}">
26+
<li ui-sref-active="active">
2627
<a ui-sref="dashboard.buttons">Buttons</a>
2728
</li>
28-
<li ng-class="{active: currentUrl()=='/dashboard/notifications'}">
29+
<li ui-sref-active="active">
2930
<a ui-sref="dashboard.notifications">Notifications</a>
3031
</li>
31-
<li ng-class="{active: currentUrl()=='/dashboard/typography'}">
32+
<li ui-sref-active="active">
3233
<a ui-sref="dashboard.typography">Typography</a>
3334
</li>
34-
<li ng-class="{active: currentUrl()=='/dashboard/icons'}">
35+
<li ui-sref-active="active">
3536
<a ui-sref="dashboard.icons"> Icons</a>
3637
</li>
37-
<li ng-class="{active: currentUrl()=='/dashboard/grid'}">
38+
<li ui-sref-active="active">
3839
<a ui-sref="dashboard.grid">Grid</a>
3940
</li>
4041
</ul>
4142
<!-- /.nav-second-level -->
4243
</li>
4344
<li ng-class="{active: collapseVar==2}">
44-
<a href="" ng-click="check(2)"><i class="fa fa-sitemap fa-fw"></i> Multi-Level Dropdown<span class="fa arrow"></span></a>
45-
<ul class="nav nav-second-level" collapse = "collapseVar!=2">
45+
<a href="" ng-click="check(2)"><i class="fa fa-sitemap fa-fw"></i> Multi-Level Dropdown<span
46+
class="fa arrow"></span></a>
47+
<ul class="nav nav-second-level" collapse="collapseVar!=2">
4648
<li>
4749
<a href="">Second Level Item</a>
4850
</li>
@@ -64,24 +66,25 @@
6466
<li>
6567
<a href="">Third Level Item</a>
6668
</li>
67-
69+
6870
</ul>
6971
<!-- /.nav-third-level -->
7072
</li>
7173
</ul>
7274
<!-- /.nav-second-level -->
7375
</li>
7476
<li ng-class="{active:collapseVar==4}">
75-
<a href="" ng-click="check(4)"><i class="fa fa-files-o fa-fw"></i> Sample Pages<span class="fa arrow"></span></a>
76-
<ul class="nav nav-second-level"collapse="collapseVar!=4">
77-
<li ng-class="{active: selectedMenu=='blank'}">
78-
<a ui-sref="dashboard.blank" ng-click="selectedMenu='blank'">Blank Page</a>
79-
</li>
80-
<li>
81-
<a ui-sref="login">Login Page</a>
82-
</li>
83-
</ul>
84-
<!-- /.nav-second-level -->
77+
<a href="" ng-click="check(4)"><i class="fa fa-files-o fa-fw"></i> Sample Pages<span
78+
class="fa arrow"></span></a>
79+
<ul class="nav nav-second-level" collapse="collapseVar!=4">
80+
<li ng-class="{active: selectedMenu=='blank'}">
81+
<a ui-sref="dashboard.blank" ng-click="selectedMenu='blank'">Blank Page</a>
82+
</li>
83+
<li>
84+
<a ui-sref="login">Login Page</a>
85+
</li>
86+
</ul>
87+
<!-- /.nav-second-level -->
8588
</li>
8689
</ul>
8790
</div>

app/scripts/directives/sidebar/sidebar.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ angular.module('sbAdminApp')
1515
replace: true,
1616
scope: {
1717
},
18-
controller:function($scope,$location){
18+
controller:function($scope){
1919
$scope.selectedMenu = 'dashboard';
2020
$scope.collapseVar = 0;
2121
$scope.multiCollapseVar = 0;
@@ -34,13 +34,7 @@ angular.module('sbAdminApp')
3434
$scope.multiCollapseVar = 0;
3535
else
3636
$scope.multiCollapseVar = y;
37-
}
38-
39-
$scope.currentUrl = function(){
40-
return $location.path();
41-
console.log($location.path());
42-
}
43-
37+
};
4438
}
4539
}
4640
}]);

0 commit comments

Comments
 (0)