Skip to content

Commit 3ab436c

Browse files
committed
[tagCopyPaste] implement suggested changes
1 parent 9b14d81 commit 3ab436c

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

plugins/tagCopyPaste/tagCopyPaste.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,18 @@
4646
var copyButton = document.createElement("button");
4747
copyButton.className = "imageGalleryNav-copyButton btn btn-secondary";
4848
copyButton.innerText = "Copy";
49-
copyButton.onclick = () => handleCopyClick();
49+
copyButton.onclick = (event) => {
50+
event.preventDefault();
51+
handleCopyClick();
52+
}
5053

5154
var pasteButton = document.createElement("button");
5255
pasteButton.className = "imageGalleryNav-pasteButton btn btn-secondary";
5356
pasteButton.innerText = "Paste";
54-
pasteButton.onclick = () => handlePasteClick(objID, objType);
57+
pasteButton.onclick = (event) => {
58+
event.preventDefault();
59+
handlePasteClick(objID, objType);
60+
}
5561

5662
if (document.querySelector("button.imageGalleryNav-pasteButton") == null) {
5763
document.querySelector("label[for='tag_ids']").append(pasteButton);
@@ -77,7 +83,7 @@
7783
var inputTagList = tagInput.split(",") // do de-duplication later
7884

7985
// Get tags from input box and also add to tag list.
80-
const existingTagList = ("label[for='tag_ids'] + div .react-select__multi-value__label")
86+
const existingTagList = getAllInnerText("label[for='tag_ids'] + div .react-select__multi-value__label")
8187

8288
inputTagList = [...new Set([...inputTagList, ...existingTagList])].sort();
8389

@@ -88,7 +94,7 @@
8894
// Search for tag ID for each tag. If exists, add to tag ID list. If not exists, create new tag and add to tag ID list.
8995
for (const inputTag of inputTagList) {
9096
const tagID = await getTagByName(inputTag.trim());
91-
if (tagID) {
97+
if (tagID && tagID.length) {
9298
existingTags.push(inputTag);
9399
tagUpdateList.push(tagID[0]);
94100
} else {

0 commit comments

Comments
 (0)