Etag support introduced in v5.68 is not compatible with nocache tags

[mmodler]

Bug description

If a view uses nocache tags and there is a content change within such an area, the etag does not change. This is understandable, since $response->getContent() contains the following before and after the change, for example:

<span class="nocache" data-nocache=“6bd05a0d2de9b1b096bc36f02df6b6b11f2d66ec8966f7803fa0d043ececf49c88381b92”>NOCACHE_PLACEHOLDER</span>

Since the Etag does not change, clients (tested with Chrome) receive a 304 Not Modified response instead of the new content.

I think the bug was introduced with #11441

How to reproduce

• Add a nocache tag with dynamic content to a template
• Check etag in Frontened
• Change the dynamic content displayed in the nocache tag
• Check etag in Frontened again

Environment

Environment
Laravel Version: 11.47.0
PHP Version: 8.3.28

Statamic
Stache Watcher: Enabled
Static Caching: half
Version: 5.70.0 PRO

[jasonvarga]

Nice find. I think we'll need to re-evaluate the etag & not-modified after any replacements have been made here:

cms/src/StaticCaching/Middleware/Cache.php

Lines 97 to 101 in 08c8115

	} elseif (! $response->isRedirect()) {
	$this->makeReplacements($response);
	}
	return $response;

[mmodler]

Ok, i created a PR for that and re-checked the issue, especially in chrome. Etag is handled correct now.

We updated our 300+ Church Websites to v5 in december and some website admins using chrome complained about that. Good thing I looked at the code first before suspecting the server guys of changing the nginx etag config without telling me. :)

[mmodler]

If there are any reasons that the fix can't be released soon with v5.71.0, i'll go with a composer patch in the meantime.

[edalzell]

If there are any reasons that the fix can't be released soon with v5.71.0, i'll go with a composer patch in the meantime.

Always best to composer patch in things like this, as you never know when a release will happen.

[mmodler]

Already did so. It is absolutely clear that releases cannot be tailored to my personal requirements.