[6.x] Only include publish-fields padding when border enabled #13109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice. I think the padding below the group's label would be good to have. Especially once you add a description, it needs some breathing room. For reference, this is how the 
|
Contributor
Author
|
Thanks for that @daun - just updated to make it more consistent: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group fields can now have borders disabled (hoorah!)
But all that does is hide the actual border, and it creates some odd visual spacing that makes fields no longer line up.
This may be an intentional design choice - but in busier forms, looks a bit odd as widths and alignments no longer match, such as:
There is too much padding on the y-axis, and the x-axis padding changes the visual alignment.
This PR simply only adds the border to the
Fieldswhen the border for the field is enabled, resulting in:It could, perhaps, even have a minor padding on top - but then it did (strictly speaking) differ from other fields, so I went for none at all.
Personally this feels more visually pleasing - although does beg the question why given the Group and its fields have no distinguishing difference between labels - but that's a different issue and discussion 🙃