[6.x] Add a little top margin to the header-actions slot
#13494
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The button being under the text like that looks wrong anyway. 🤔 @JayGeorge ? I would've expected actions to be on the right. |
Member
|
I believe header actions are intended to be on the right. The slot was added in this commit but it's not actually used. That commit styles the updates page, which has a card panel with a button, which looks like this: 
I think the slot was committed unintentionally as it wasn't actually used in that commit. It's good to have, but clearly isn't supposed to just sit on the left under the headings. |
Member
Author
|
Should we undocument it, or fix the slot placement? |
Member
|
Both. But we could just undocument it for now. It's not urgent to fix. It'll still work, it'll just be styled differently when we fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one might be subjective, but I feel like the
header-actionsslot in thePanelcomponent could do with a little top margin to introduce some breathing space between the heading and the button.Before
After