Fix offset being specified without limit and without pagination (#176)

Author: ryanmitchell

src/Entries/EntryQueryBuilder.php

@@ -62,6 +62,11 @@ public function find($id, $columns = ['*'])
 
     public function get($columns = ['*'])
     {
+        $query = $this->builder->getQuery();
+        if ($query->offset && ! $query->limit) {
+            $query->limit = PHP_INT_MAX;
+        }
+
         $this->addTaxonomyWheres();
 
         return parent::get($columns);

tests/Data/Entries/EntryQueryBuilderTest.php

@@ -689,6 +689,21 @@ public function entries_are_found_using_offset()
         $this->assertEquals(['Post 2', 'Post 3'], $entries->map->title->all());
     }
 
+    /** @test */
+    public function entries_are_found_using_offset_but_no_limit()
+    {
+        $this->createDummyCollectionAndEntries();
+
+        $entries = Entry::query()->get();
+        $this->assertCount(3, $entries);
+        $this->assertEquals(['Post 1', 'Post 2', 'Post 3'], $entries->map->title->all());
+
+        $entries = Entry::query()->offset(1)->get();
+
+        $this->assertCount(2, $entries);
+        $this->assertEquals(['Post 2', 'Post 3'], $entries->map->title->all());
+    }
+
     /** @test */
     public function entries_can_be_retrieved_on_join_table_conditions()
     {