Prevent freezing of ImportAssets for asset meta data when importing a large number of files (#360)

* prevent freezing of ImportAssets for asset meta data when importing a large number of files

* Use lazy and map for better performance / memory usage

---------

Co-authored-by: Ryan Mitchell <[email protected]>

Author: faltjo

src/Assets/AssetContainer.php

@@ -136,7 +136,7 @@ public function metaFiles($folder = '/', $recursive = false)
 
         return $this->queryAssets()
             ->when($recursive, fn ($query) => $query->where('folder', $folder), fn ($query) => $query->where('folder', 'like', Str::replaceEnd('/', '', $folder).'/%'))
-            ->get()
-            ->pluck('path');
+            ->lazy()
+            ->map(fn ($value) => $value->path());
     }
 }

tests/Commands/ImportAssetsTest.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Http\UploadedFile;
 use Illuminate\Support\Facades\Facade;
+use Illuminate\Support\Facades\Storage;
 use PHPUnit\Framework\Attributes\Test;
 use Statamic\Contracts\Assets\Asset as AssetContract;
 use Statamic\Contracts\Assets\AssetContainer as AssetContainerContract;
@@ -46,6 +47,21 @@ public function tearDown(): void
         parent::tearDown();
     }
 
+    #[Test]
+    public function it_gets_all_meta_files_by_default()
+    {
+        $container = tap(AssetContainer::make('test')->disk('test'))->save();
+        Storage::disk('test')->put('.meta/a.txt.yaml',
+            "data:
+                    title: 'File A'
+                    size: 123
+                    last_modified: 0000000000"
+        );
+        $this->assertEquals([
+            '.meta/a.txt.yaml',
+        ], $container->metaFiles()->all());
+    }
+
     #[Test]
     public function it_imports_asset_containers_and_assets()
     {