Update old broken revisions after updating to Statamic v4.41.0 (#231)

* Update old broken revisions after updating to Statamic v4.41.0

* StyleCI

* Save id as string

Author: helloiamlukas

database/migrations/updates/add_id_to_attributes_in_revisions_table.php.stub

@@ -0,0 +1,42 @@
+<?php
+
+use Statamic\Eloquent\Database\BaseMigration as Migration;
+use Statamic\Eloquent\Revisions\RevisionModel;
+
+return new class extends Migration {
+    public function up()
+    {
+        // Extract the id from the key and add it to the attributes of the revision
+        RevisionModel::query()
+            ->whereJsonDoesntContainKey('attributes->id')
+            ->chunk(200, function ($revisions) {
+                foreach ($revisions as $revision) {
+                    $id = str($revision->key)
+                        ->afterLast('/')
+                        ->toString();
+
+                    $attributes = $revision->attributes;
+                    $attributes['id'] = $id;
+
+                    $revision->attributes = $attributes;
+                    $revision->save();
+                }
+            });
+    }
+
+    public function down()
+    {
+        // Reverse the above
+        RevisionModel::query()
+            ->whereJsonContainsKey('attributes->id')
+            ->chunk(200, function ($revisions) {
+                foreach ($revisions as $revision) {
+                    $attributes = $revision->attributes;
+                    unset($attributes['id']);
+
+                    $revision->attributes = $attributes;
+                    $revision->save();
+                }
+            });
+    }
+};

src/ServiceProvider.php

@@ -52,6 +52,7 @@ class ServiceProvider extends AddonServiceProvider
         \Statamic\Eloquent\Updates\ChangeDefaultBlueprint::class,
         \Statamic\Eloquent\Updates\DropForeignKeysOnEntriesAndForms::class,
         \Statamic\Eloquent\Updates\SplitGlobalsFromVariables::class,
+        \Statamic\Eloquent\Updates\AddIdToAttributesInRevisionsTable::class,
     ];
 
     protected $listen = [
@@ -75,20 +76,20 @@ public function boot()
         $this->publishes([$config => config_path('statamic/eloquent-driver.php')], 'statamic-eloquent-config');
 
         $this->publishes([
-            __DIR__.'/../database/migrations/create_taxonomies_table.php.stub'       => $this->migrationsPath('create_taxonomies_table.php'),
-            __DIR__.'/../database/migrations/create_terms_table.php.stub'            => $this->migrationsPath('create_terms_table.php'),
-            __DIR__.'/../database/migrations/create_globals_table.php.stub'          => $this->migrationsPath('create_globals_table.php'),
+            __DIR__.'/../database/migrations/create_taxonomies_table.php.stub' => $this->migrationsPath('create_taxonomies_table.php'),
+            __DIR__.'/../database/migrations/create_terms_table.php.stub' => $this->migrationsPath('create_terms_table.php'),
+            __DIR__.'/../database/migrations/create_globals_table.php.stub' => $this->migrationsPath('create_globals_table.php'),
             __DIR__.'/../database/migrations/create_global_variables_table.php.stub' => $this->migrationsPath('create_global_variables_table.php'),
-            __DIR__.'/../database/migrations/create_navigations_table.php.stub'      => $this->migrationsPath('create_navigations_table.php'),
+            __DIR__.'/../database/migrations/create_navigations_table.php.stub' => $this->migrationsPath('create_navigations_table.php'),
             __DIR__.'/../database/migrations/create_navigation_trees_table.php.stub' => $this->migrationsPath('create_navigation_trees_table.php'),
-            __DIR__.'/../database/migrations/create_collections_table.php.stub'      => $this->migrationsPath('create_collections_table.php'),
-            __DIR__.'/../database/migrations/create_blueprints_table.php.stub'       => $this->migrationsPath('create_blueprints_table.php'),
-            __DIR__.'/../database/migrations/create_fieldsets_table.php.stub'        => $this->migrationsPath('create_fieldsets_table.php'),
-            __DIR__.'/../database/migrations/create_forms_table.php.stub'            => $this->migrationsPath('create_forms_table.php'),
+            __DIR__.'/../database/migrations/create_collections_table.php.stub' => $this->migrationsPath('create_collections_table.php'),
+            __DIR__.'/../database/migrations/create_blueprints_table.php.stub' => $this->migrationsPath('create_blueprints_table.php'),
+            __DIR__.'/../database/migrations/create_fieldsets_table.php.stub' => $this->migrationsPath('create_fieldsets_table.php'),
+            __DIR__.'/../database/migrations/create_forms_table.php.stub' => $this->migrationsPath('create_forms_table.php'),
             __DIR__.'/../database/migrations/create_form_submissions_table.php.stub' => $this->migrationsPath('create_form_submissions_table.php'),
             __DIR__.'/../database/migrations/create_asset_containers_table.php.stub' => $this->migrationsPath('create_asset_containers_table.php'),
-            __DIR__.'/../database/migrations/create_asset_table.php.stub'            => $this->migrationsPath('create_asset_table.php'),
-            __DIR__.'/../database/migrations/create_revisions_table.php.stub'        => $this->migrationsPath('create_revisions_table.php'),
+            __DIR__.'/../database/migrations/create_asset_table.php.stub' => $this->migrationsPath('create_asset_table.php'),
+            __DIR__.'/../database/migrations/create_revisions_table.php.stub' => $this->migrationsPath('create_revisions_table.php'),
         ], 'migrations');
 
         $this->publishes([

src/Updates/AddIdToAttributesInRevisionsTable.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Statamic\Eloquent\Updates;
+
+use Statamic\UpdateScripts\UpdateScript;
+
+class AddIdToAttributesInRevisionsTable extends UpdateScript
+{
+    public function shouldUpdate($newVersion, $oldVersion)
+    {
+        return $this->isUpdatingTo('3.0.2');
+    }
+
+    public function update()
+    {
+        $source = __DIR__.'/../../database/migrations/updates/add_id_to_attributes_in_revisions_table.php.stub';
+        $dest = database_path('migrations/'.date('Y_m_d_His').'_add_id_to_attributes_in_revisions_table.php');
+
+        $this->files->copy($source, $dest);
+
+        $this->console()->info('Migration created');
+        $this->console()->comment('Remember to run `php artisan migrate` to apply it to your database.');
+    }
+}