Fix parse_url() path error on home page in Rules\ThreeSegmentUrls

StefanSchuechl · web-flow · commit 83dccac71c47 · 2020-08-25T15:43:03.000+02:00
The report queue fails as soon as it gets to the home page. This is caused by the missing path index. Same fix as abd1697 for similar bug #111 .
diff --git a/src/Reporting/Rules/ThreeSegmentUrls.php b/src/Reporting/Rules/ThreeSegmentUrls.php
@@ -27,7 +27,7 @@ public function siteWarningComment()
 
     public function processPage()
     {
-        $url = parse_url($this->page->url())['path'];
+        $url = parse_url($this->page->url())['path'] ?? '/';
         $this->slashes = substr_count($url, '/');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function siteWarningComment()`
`27`	`27`
`28`	`28`	`public function processPage()`
`29`	`29`	`{`
`30`		`- $url = parse_url($this->page->url())['path'];`
	`30`	`+ $url = parse_url($this->page->url())['path'] ?? '/';`
`31`	`31`	`$this->slashes = substr_count($url, '/');`
`32`	`32`	`}`
`33`	`33`