chore: add frozen_string_literal comment and using new ruby syntax

seuros · seuros · commit 653d1b8c3bc5 · 2025-03-19T15:55:35.000Z
diff --git a/Appraisals b/Appraisals
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # ActiveModel integrations
 appraise 'active_model_7.1' do
   gem 'activemodel', '~> 7.1.0'
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in state_machine2_activemodel.gemspec
diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 
diff --git a/gemfiles/active_model_7.1.gemfile b/gemfiles/active_model_7.1.gemfile
@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
 
+gem "mutex_m"
 gem "activemodel", "~> 7.1.0"
 
 platforms :mri do
diff --git a/gemfiles/active_model_7.2.gemfile b/gemfiles/active_model_7.2.gemfile
@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
 
+gem "mutex_m"
 gem "activemodel", "~> 7.2.0"
 
 platforms :mri do
diff --git a/gemfiles/active_model_8.0.gemfile b/gemfiles/active_model_8.0.gemfile
@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
 
+gem "mutex_m"
 gem "activemodel", "~> 8.0.0"
 
 platforms :mri do
diff --git a/gemfiles/active_model_edge.gemfile b/gemfiles/active_model_edge.gemfile
@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
 
+gem "mutex_m"
 gem "activemodel", github: "rails/rails", branch: "main"
 
 platforms :mri do
diff --git a/lib/state_machines-activemodel.rb b/lib/state_machines-activemodel.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support'
 require 'state_machines/integrations/active_model'
 
diff --git a/lib/state_machines/integrations/active_model.rb b/lib/state_machines/integrations/active_model.rb
@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'active_model'
 require 'active_support/core_ext/hash/keys'
-require 'active_support/core_ext/module/attribute_accessors.rb'
+require 'active_support/core_ext/module/attribute_accessors'
 require 'state_machines'
 require 'state_machines/integrations/base'
 require 'state_machines/integrations/active_model/version'
@@ -83,7 +85,7 @@ module Integrations #:nodoc:
     #     state_machine do
     #       ...
     #       state :first_gear, :second_gear do
-    #         validate {|vehicle| vehicle.speed_is_legal}
+    #         validate { |vehicle| vehicle.speed_is_legal }
     #       end
     #     end
     #   end
@@ -292,7 +294,7 @@ module Integrations #:nodoc:
     #   module StateMachine::Integrations::MyORM
     #     include ActiveModel
     #
-    #     mattr_accessor(:defaults) { action: :persist }
+    #     mattr_accessor(:defaults) { { action: :persist } }
     #
     #     def self.matches?(klass)
     #       defined?(::MyORM::Base) && klass <= ::MyORM::Base
@@ -324,10 +326,7 @@ def self.matching_ancestors
       def invalidate(object, attribute, message, values = [])
         if supports_validations?
           attribute = self.attribute(attribute)
-          options = values.reduce({}) do |h, (key, value)|
-            h[key] = value
-            h
-          end
+          options = values.to_h { |key, value| [key, value] }
 
           default_options = default_error_message_options(object, attribute, message)
           object.errors.add(attribute, message, **options, **default_options)
@@ -337,7 +336,7 @@ def invalidate(object, attribute, message, values = [])
       # Describes the current validation errors on the given object.  If none
       # are specific, then the default error is interpeted as a "halt".
       def errors_for(object)
-        object.errors.empty? ? 'Transition halted' : object.errors.full_messages * ', '
+        object.errors.empty? ? 'Transition halted' : object.errors.full_messages.join(', ')
       end
 
       # Resets any errors previously added when invalidating the given object
diff --git a/lib/state_machines/integrations/active_model/locale.rb b/lib/state_machines/integrations/active_model/locale.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 { en: {
   activemodel: {
     errors: {
diff --git a/lib/state_machines/integrations/active_model/version.rb b/lib/state_machines/integrations/active_model/version.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module StateMachines
   module Integrations
     module ActiveModel
diff --git a/state_machines-activemodel.gemspec b/state_machines-activemodel.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'lib/state_machines/integrations/active_model/version'
 
 Gem::Specification.new do |spec|
diff --git a/test/integration_test.rb b/test/integration_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class IntegrationTest < BaseTestCase
diff --git a/test/machine_by_default_test.rb b/test/machine_by_default_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineByDefaultTest < BaseTestCase
diff --git a/test/machine_errors_test.rb b/test/machine_errors_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineErrorsTest < BaseTestCase
diff --git a/test/machine_multiple_test.rb b/test/machine_multiple_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineMultipleTest < BaseTestCase
diff --git a/test/machine_with_callbacks_test.rb b/test/machine_with_callbacks_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithCallbacksTest < BaseTestCase
diff --git a/test/machine_with_dirty_attribute_and_custom_attributes_during_loopback_test.rb b/test/machine_with_dirty_attribute_and_custom_attributes_during_loopback_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDirtyAttributeAndCustomAttributesDuringLoopbackTest < BaseTestCase
diff --git a/test/machine_with_dirty_attribute_and_state_events_test.rb b/test/machine_with_dirty_attribute_and_state_events_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDirtyAttributeAndStateEventsTest < BaseTestCase
diff --git a/test/machine_with_dirty_attributes_and_custom_attribute_test.rb b/test/machine_with_dirty_attributes_and_custom_attribute_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDirtyAttributesAndCustomAttributeTest < BaseTestCase
diff --git a/test/machine_with_dirty_attributes_during_loopback_test.rb b/test/machine_with_dirty_attributes_during_loopback_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDirtyAttributesDuringLoopbackTest < BaseTestCase
diff --git a/test/machine_with_dirty_attributes_test.rb b/test/machine_with_dirty_attributes_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDirtyAttributesTest < BaseTestCase
diff --git a/test/machine_with_dynamic_initial_state_test.rb b/test/machine_with_dynamic_initial_state_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithDynamicInitialStateTest < BaseTestCase
diff --git a/test/machine_with_events_test.rb b/test/machine_with_events_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithEventsTest < BaseTestCase
diff --git a/test/machine_with_failed_after_callbacks_test.rb b/test/machine_with_failed_after_callbacks_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithFailedAfterCallbacksTest < BaseTestCase
diff --git a/test/machine_with_failed_before_callbacks_test.rb b/test/machine_with_failed_before_callbacks_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithFailedBeforeCallbacksTest < BaseTestCase
diff --git a/test/machine_with_initialized_aliased_attribute_test.rb b/test/machine_with_initialized_aliased_attribute_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithInitializedAliasedAttributeTest < BaseTestCase
diff --git a/test/machine_with_initialized_state_test.rb b/test/machine_with_initialized_state_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithInitializedStateTest < BaseTestCase
diff --git a/test/machine_with_internationalization_test.rb b/test/machine_with_internationalization_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 require 'i18n'
 
diff --git a/test/machine_with_model_state_attribute_test.rb b/test/machine_with_model_state_attribute_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithModelStateAttributeTest < BaseTestCase
diff --git a/test/machine_with_non_model_state_attribute_undefined_test.rb b/test/machine_with_non_model_state_attribute_undefined_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithNonModelStateAttributeUndefinedTest < BaseTestCase
diff --git a/test/machine_with_state_driven_validations_test.rb b/test/machine_with_state_driven_validations_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithStateDrivenValidationsTest < BaseTestCase
diff --git a/test/machine_with_states_test.rb b/test/machine_with_states_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithStatesTest < BaseTestCase
diff --git a/test/machine_with_static_initial_state_test.rb b/test/machine_with_static_initial_state_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithStaticInitialStateTest < BaseTestCase
diff --git a/test/machine_with_validations_and_custom_attribute_test.rb b/test/machine_with_validations_and_custom_attribute_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithValidationsAndCustomAttributeTest < BaseTestCase
diff --git a/test/machine_with_validations_test.rb b/test/machine_with_validations_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class MachineWithValidationsTest < BaseTestCase
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'debug'
 
 require 'state_machines-activemodel'

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# ActiveModel integrations`
`2`	`4`	`appraise 'active_model_7.1' do`
`3`	`5`	`gem 'activemodel', '~> 7.1.0'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`source 'https://rubygems.org'`
`2`	`4`
`3`	`5`	`# Specify your gem's dependencies in state_machine2_activemodel.gemspec`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'bundler/gem_tasks'`
`2`	`4`	`require 'rake/testtask'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'active_support'`
`2`	`4`	`require 'state_machines/integrations/active_model'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`{ en: {`
`2`	`4`	`activemodel: {`
`3`	`5`	`errors: {`