Skip to content

Commit 40e4701

Browse files
committed
Add comments about escaping the SPA router
1 parent 18fe642 commit 40e4701

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/components/landing/Navbar.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,17 @@ export function Navbar() {
121121
</div>
122122
<div className="hidden sm:ml-6 sm:block">
123123
<div className="flex space-x-4">
124+
{/* Important to open this in a new window to escape the SPA router, otherwise the link won't take us to the right page */}
124125
<NavLink href="/registry/login" target="_blank">
125126
Log in
126127
</NavLink>
127128

129+
{/* Important to open this in a new window to escape the SPA router, otherwise the link won't take us to the right page */}
128130
<ButtonLink
129131
size="small"
130132
background="blue"
131133
href="/registry/signup"
134+
target="_blank"
132135
>
133136
Sign up
134137
</ButtonLink>

0 commit comments

Comments
 (0)