REP: allow patch candidate targets to be unspecified

in that case we will include all targets, instead of none

Author: waskyo

chb/cmdline/chkx

@@ -1184,8 +1184,9 @@ def parse() -> argparse.Namespace:
     report_patchcandidates.add_argument(
         "--targets",
         nargs="*",
-        default=[],
-        help="list of target library functions to include")
+        default=['all'],
+        help="list of target library functions to include. If not passed, all "
+             "library functions found will be included.")
     report_patchcandidates.add_argument(
         "--verbose", "-v",
         action="store_true",

chb/cmdline/reportcmds.py

@@ -66,7 +66,8 @@
 from chb.util.loggingutil import chklogger
 
 if TYPE_CHECKING:
-    from chb.api.CallTarget import StubTarget
+    from chb.api.CallTarget import (
+        StubTarget, CallTarget)
     from chb.api.FunctionStub import SOFunction
     from chb.app.AppAccess import AppAccess
     from chb.app.Instruction import Instruction
@@ -1156,14 +1157,21 @@ def report_patch_candidates(args: argparse.Namespace) -> NoReturn:
     n_calls: int = 0
     libcalls = LibraryCallCallsites()
 
+    include_all = xtargets == ['all']
+
+    def include_target(target: 'CallTarget') -> bool:
+        if include_all:
+            return True
+        return target.name in xtargets
+
     for (faddr, blocks) in app.call_instructions().items():
         fn = app.function(faddr)
 
         for (baddr, instrs) in blocks.items():
             for instr in instrs:
                 n_calls += 1
                 calltgt = instr.call_target
-                if calltgt.is_so_target and calltgt.name in xtargets:
+                if calltgt.is_so_target and include_target(calltgt):
                     libcalls.add_library_callsite(faddr, instr)
 
     print("Number of calls: " + str(n_calls))