ARM: add astprov support for MLA

Author: sipma

chb/arm/opcodes/ARMMultiplyAccumulate.py

@@ -4,7 +4,7 @@
 # ------------------------------------------------------------------------------
 # The MIT License (MIT)
 #
-# Copyright (c) 2021 Aarno Labs LLC
+# Copyright (c) 2021-2025 Aarno Labs LLC
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -79,11 +79,11 @@ def xrprd(self) -> "XXpr":
 
     @property
     def result(self) -> "XXpr":
-        return self.xpr(4, "result")
+        return self.xpr(5, "result")
 
     @property
     def rresult(self) -> "XXpr":
-        return self.xpr(5, "rresult")
+        return self.xpr(6, "rresult")
 
     @property
     def result_simplified_p(self) -> str:
@@ -123,9 +123,83 @@ def __init__(self, d: "ARMDictionary", ixval: IndexedTableValue) -> None:
     def operands(self) -> List[ARMOperand]:
         return [self.armd.arm_operand(i) for i in self.args[1:]]
 
+    @property
+    def opargs(self) -> List[ARMOperand]:
+        return [self.armd.arm_operand(i) for i in self.args[1:]]
+
     def annotation(self, xdata: InstrXData) -> str:
         xd = ARMMultiplyAccumulateXData(xdata)
         if xd.is_ok:
             return xd.annotation
         else:
             return "Error value"
+
+    def ast_prov(
+            self,
+            astree: ASTInterface,
+            iaddr: str,
+            bytestring: str,
+            xdata: InstrXData) -> Tuple[
+                List[AST.ASTInstruction], List[AST.ASTInstruction]]:
+
+        annotations: List[str] = [iaddr, "MLA"]
+
+        # low-level assignment
+
+        (ll_lhs, _, _) = self.opargs[0].ast_lvalue(astree)
+        (ll_rn, _, _) = self.opargs[1].ast_rvalue(astree)
+        (ll_rm, _, _) = self.opargs[2].ast_rvalue(astree)
+        (ll_ra, _, _) = self.opargs[3].ast_rvalue(astree)
+        ll_rhs1 = astree.mk_binary_op("mult", ll_rn, ll_rm)
+        ll_rhs = astree.mk_binary_op("plus",ll_rhs1, ll_ra)
+
+        ll_assign = astree.mk_assign(
+            ll_lhs,
+            ll_rhs,
+            iaddr=iaddr,
+            bytestring=bytestring,
+            annotations=annotations)
+
+        rdefs = xdata.reachingdefs
+
+        astree.add_expr_reachingdefs(ll_rn, [rdefs[0]])
+        astree.add_expr_reachingdefs(ll_rm, [rdefs[1]])
+        astree.add_expr_reachingdefs(ll_ra, [rdefs[2]])
+
+        # high-level assignment
+
+        xd = ARMMultiplyAccumulateXData(xdata)
+        if not xd.is_ok:
+            chklogger.logger.error(
+                "Error value encountered for MLA at %s", iaddr)
+            return ([], [])
+
+        lhs = xd.vrd
+        rhs1 = xd.xrn
+        rhs2 = xd.xrm
+        rhs3 = xd.xra
+        rhs4 = xd.rresult
+
+        defuses = xdata.defuses
+        defuseshigh = xdata.defuseshigh
+
+        hl_lhs = XU.xvariable_to_ast_lval(lhs, xdata, iaddr, astree)
+        hl_rhs = XU.xxpr_to_ast_def_expr(rhs4, xdata, iaddr, astree)
+
+        hl_assign = astree.mk_assign(
+            hl_lhs,
+            hl_rhs,
+            iaddr=iaddr,
+            bytestring=bytestring,
+            annotations=annotations)
+
+        astree.add_instr_mapping(hl_assign, ll_assign)
+        astree.add_instr_address(hl_assign, [iaddr])
+        astree.add_expr_mapping(hl_rhs, ll_rhs)
+        astree.add_lval_mapping(hl_lhs, ll_lhs)
+        astree.add_expr_reachingdefs(hl_rhs, rdefs[2:])
+        astree.add_expr_reachingdefs(ll_rhs, rdefs[:2])
+        astree.add_lval_defuses(hl_lhs, defuses[0])
+        astree.add_lval_defuses_high(hl_lhs, defuseshigh[0])
+
+        return ([hl_assign], [ll_assign])