ARM: emit error if lifting support is missing

Author: sipma

chb/arm/ARMOpcode.py

@@ -167,6 +167,9 @@ def ast_prov(
                 List[AST.ASTInstruction], List[AST.ASTInstruction]]:
         """Return default; should be overridden by instruction opcodes."""
 
+        chklogger.logger.error(
+            "no lifting support available for instruction %s at address %s",
+            self.mnemonic, iaddr)
         instrs = self.ast(astree, iaddr, bytestring, xdata)
         return (instrs, instrs)
 

chb/arm/opcodes/ARMBranch.py

@@ -178,8 +178,9 @@ def ast_prov(
             return self.ast_call_prov(
                 astree, iaddr, bytestring, "Branch (B.W)", xdata)
         else:
-            return ARMOpcode.ast_prov(
+            instrs = ARMOpcode.assembly_ast(
                 self, astree, iaddr, bytestring, xdata)
+            return (instrs, instrs)
 
     def ast_call_prov(
             self,

chb/arm/opcodes/ARMCompareBranchNonzero.py

@@ -95,6 +95,17 @@ def annotation(self, xdata: InstrXData) -> str:
         tgt = str(xdata.xprs[5])
         return "if " + xpr + " != 0 goto " + tgt
 
+    def ast_prov(
+            self,
+            astree: ASTInterface,
+            iaddr: str,
+            bytestring: str,
+            xdata: InstrXData) -> Tuple[
+                List[AST.ASTInstruction], List[AST.ASTInstruction]]:
+        instrs = ARMOpcode.assembly_ast(
+            self, astree, iaddr, bytestring, xdata)
+        return (instrs, instrs)
+
     def ast_condition_prov(
             self,
             astree: ASTInterface,

chb/arm/opcodes/ARMCompareBranchZero.py

@@ -93,6 +93,17 @@ def annotation(self, xdata: InstrXData) -> str:
         tgt = str(xdata.xprs[5])
         return "if " + xpr + " goto " + tgt
 
+    def ast_prov(
+            self,
+            astree: ASTInterface,
+            iaddr: str,
+            bytestring: str,
+            xdata: InstrXData) -> Tuple[
+                List[AST.ASTInstruction], List[AST.ASTInstruction]]:
+        instrs = ARMOpcode.assembly_ast(
+            self, astree, iaddr, bytestring, xdata)
+        return (instrs, instrs)
+
     def ast_condition_prov(
             self,
             astree: ASTInterface,

chb/arm/opcodes/ARMSignedMultiplyWordT.py

@@ -4,7 +4,7 @@
 # ------------------------------------------------------------------------------
 # The MIT License (MIT)
 #
-# Copyright (c) 2023  Aarno Labs LLC
+# Copyright (c) 2023-2024  Aarno Labs LLC
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -67,4 +67,8 @@ def operands(self) -> List[ARMOperand]:
         return [self.armd.arm_operand(i) for i in self.args]
 
     def annotation(self, xdata: InstrXData) -> str:
-        return "pending"
+        lhs = str(xdata.vars[0])
+        result = xdata.xprs[2]
+        rresult = xdata.xprs[3]
+        xresult = simplify_result(xdata.args[3], xdata.args[4], result, rresult)
+        return lhs + " := " + xresult