add logging support for compare all and compare app commands

Author: waskyo

chb/cmdline/chkx

@@ -1328,6 +1328,19 @@ def parse() -> argparse.Namespace:
         help="name of patch results file (required if there are trampolines)")
     relationalcompareall.add_argument(
         "--output", "-o", help="save json output in file")
+    relationalcompareall.add_argument(
+        "--loglevel", "-log",
+        choices=UL.LogLevel.options(),
+        default="NONE",
+        help="activate logging with the given level (default to stderr)")
+    relationalcompareall.add_argument(
+        "--logfilename",
+        help="name of file to write log messages")
+    relationalcompareall.add_argument(
+        "--logfilemode",
+        choices=["a", "w"],
+        default="a",
+        help="file mode for log file: append (a, default), or write (w)")
     relationalcompareall.set_defaults(func=R.relational_compare_all_cmd)
 
     # --- relational compare app --
@@ -1343,6 +1356,19 @@ def parse() -> argparse.Namespace:
         help="name of patch results file (required if there are trampolines)")
     relationalcomparefns.add_argument(
         "--output", "-o", help="save output in file")
+    relationalcompareall.add_argument(
+        "--loglevel", "-log",
+        choices=UL.LogLevel.options(),
+        default="NONE",
+        help="activate logging with the given level (default to stderr)")
+    relationalcompareall.add_argument(
+        "--logfilename",
+        help="name of file to write log messages")
+    relationalcompareall.add_argument(
+        "--logfilemode",
+        choices=["a", "w"],
+        default="a",
+        help="file mode for log file: append (a, default), or write (w)")
     relationalcomparefns.set_defaults(func=R.relational_compare_app_cmd)
 
     # --- relational compare function --

chb/cmdline/relationalcmds.py

@@ -324,6 +324,9 @@ def _relational_compare_generate_json(xname1: str,
                                       xpatchresults: Optional[str],
                                       usermappingfile: Optional[str],
                                       addresses: List[str],
+                                      loglevel: str,
+                                      logfilename: Optional[str],
+                                      logfilemode: str,
                                      ) -> JSONResult:
     try:
         (path1, xfile1) = UC.get_path_filename(xname1)
@@ -334,6 +337,13 @@ def _relational_compare_generate_json(xname1: str,
         print(str(e.wrap()))
         exit(1)
 
+    UC.set_logging(
+        loglevel,
+        path1,
+        logfilename=logfilename,
+        mode=logfilemode,
+        msg="relational compare all")
+
     usermapping: Dict[str, str] = {}
     if usermappingfile is not None:
         if os.path.isfile(usermappingfile):
@@ -387,8 +397,13 @@ def relational_compare_all_cmd(args: argparse.Namespace) -> NoReturn:
     xpatchresults: Optional[str] = args.patch_results_file
     xoutput: str = args.output
     usermappingfile: Optional[str] = args.usermapping
+    loglevel: str = args.loglevel
+    logfilename: Optional[str] = args.logfilename
+    logfilemode: str = args.logfilemode
 
-    result = _relational_compare_generate_json(xname1, xname2, xpatchresults, usermappingfile, [])
+    result = _relational_compare_generate_json(xname1, xname2, xpatchresults,
+                                               usermappingfile, [],
+                                               loglevel, logfilename, logfilemode)
     if result.is_ok:
         jsonresult = JU.jsonok("compareall", result.content)
         exitval = 0
@@ -418,8 +433,13 @@ def relational_compare_app_cmd(args: argparse.Namespace) -> NoReturn:
     xpatchresults: Optional[str] = args.patch_results_file
     xoutput: str = args.output
     usermappingfile: Optional[str] = args.usermapping
+    loglevel: str = args.loglevel
+    logfilename: Optional[str] = args.logfilename
+    logfilemode: str = args.logfilemode
 
-    result = _relational_compare_generate_json(xname1, xname2, xpatchresults, usermappingfile, [])
+    result = _relational_compare_generate_json(xname1, xname2, xpatchresults,
+                                               usermappingfile, [],
+                                               loglevel, logfilename, logfilemode)
     if not result.is_ok:
         print("ERROR: Couldn't generate app comparison results")
         exit(1)