Skip to content

Commit 90aef38

Browse files
authored
Merge pull request #708 from staticdev/deprecation/python-38
Deprecate Python 3.8
2 parents 497c96d + 74926a8 commit 90aef38

File tree

7 files changed

+17
-23
lines changed

7 files changed

+17
-23
lines changed

.github/workflows/tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@ jobs:
1818
- { python: "3.11", os: "ubuntu-latest", session: "mypy" }
1919
- { python: "3.10", os: "ubuntu-latest", session: "mypy" }
2020
- { python: "3.9", os: "ubuntu-latest", session: "mypy" }
21-
- { python: "3.8", os: "ubuntu-latest", session: "mypy" }
2221
- { python: "3.12", os: "ubuntu-latest", session: "tests" }
2322
- { python: "3.11", os: "ubuntu-latest", session: "tests" }
2423
- { python: "3.10", os: "ubuntu-latest", session: "tests" }
2524
- { python: "3.9", os: "ubuntu-latest", session: "tests" }
26-
- { python: "3.8", os: "ubuntu-latest", session: "tests" }
2725
- { python: "3.12", os: "windows-latest", session: "tests" }
2826
- { python: "3.12", os: "macos-latest", session: "tests" }
2927
- { python: "3.12", os: "ubuntu-latest", session: "typeguard" }
@@ -124,7 +122,6 @@ jobs:
124122
mv coverage-data-3.11-ubuntu-latest/* .
125123
mv coverage-data-3.10-ubuntu-latest/* .
126124
mv coverage-data-3.9-ubuntu-latest/* .
127-
mv coverage-data-3.8-ubuntu-latest/* .
128125
hatch run coverage:run
129126
130127
- name: Create coverage report

.pre-commit-config.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,6 @@ repos:
1010
hooks:
1111
- id: prettier
1212

13-
- repo: https://github.com/asottile/pyupgrade
14-
rev: v3.19.0
15-
hooks:
16-
- id: pyupgrade
17-
args: [--py38-plus]
18-
19-
- repo: https://github.com/pycqa/isort
20-
rev: 5.13.2
21-
hooks:
22-
- id: isort
23-
args: ["--filter-files"]
24-
2513
- repo: https://github.com/pre-commit/pre-commit-hooks
2614
rev: v5.0.0
2715
hooks:
@@ -33,6 +21,18 @@ repos:
3321
- id: check-yaml
3422
- id: end-of-file-fixer
3523

24+
- repo: https://github.com/asottile/pyupgrade
25+
rev: v3.19.1
26+
hooks:
27+
- id: pyupgrade
28+
args: [--py39-plus]
29+
30+
- repo: https://github.com/pycqa/isort
31+
rev: 5.13.2
32+
hooks:
33+
- id: isort
34+
args: ["--filter-files"]
35+
3636
- repo: https://github.com/pycqa/flake8
3737
rev: 7.1.1
3838
hooks:

.readthedocs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ sphinx:
33
configuration: docs/conf.py
44
formats: all
55
python:
6-
version: 3.8
6+
version: 3.9
77
install:
88
- requirements: docs/requirements.txt
99
- path: .

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Request features on the [Issue Tracker].
3737

3838
## How to set up your development environment
3939

40-
You need Python 3.8+ and the following tools:
40+
You need Python 3.9+ and the following tools:
4141

4242
- [Hatch]
4343

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555

5656
## Requirements
5757

58-
- It works in Python 3.8+.
58+
- It works in Python 3.9+.
5959

6060
## Installation
6161

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@ license = {text = "MIT"}
99
readme = "README.md"
1010
classifiers = [
1111
"Development Status :: 5 - Production/Stable",
12-
"Programming Language :: Python :: 3.8",
1312
"Programming Language :: Python :: 3.9",
1413
"Programming Language :: Python :: 3.10",
1514
"Programming Language :: Python :: 3.11",
1615
"Programming Language :: Python :: 3.12",
1716
]
18-
requires-python = ">=3.8"
17+
requires-python = ">=3.9"
1918
dependencies = []
2019

2120
[tool.hatch.version]
@@ -58,7 +57,7 @@ run-xdoctest = [ "hatch run xdoctest:run" ]
5857
run-docs-build = [ "hatch run docs-build:run" ]
5958

6059
[[tool.hatch.envs.sessions.matrix]]
61-
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
60+
python = ["3.9", "3.10", "3.11", "3.12"]
6261

6362
[tool.hatch.envs.pre-commit]
6463
dependencies = [

src/human_readable/i18n.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ def pgettext(msgctxt: str, message: str) -> str:
8989
Returns:
9090
Translated text.
9191
"""
92-
# This GNU gettext function was added in Python 3.8, so for older versions we
93-
# reimplement it. It works by joining `msgctx` and `message` by '4' byte.
9492
return get_translation().pgettext(msgctxt, message)
9593

9694

0 commit comments

Comments
 (0)